You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/30 04:06:42 UTC
[GitHub] [camel-k] tadayosi opened a new pull request, #3409: chore(ci): regen docs & add generate workflow to test `make generate`
tadayosi opened a new pull request, #3409:
URL: https://github.com/apache/camel-k/pull/3409
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3409: chore(ci): regen docs & add generate workflow to test `make generate`
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3409:
URL: https://github.com/apache/camel-k/pull/3409#discussion_r912781881
##########
.github/workflows/generate.yml:
##########
@@ -0,0 +1,69 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: generate
+
+on:
+ pull_request:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.adoc'
+ - '**.md'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+ push:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.md'
+ - '**.adoc'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
+ cancel-in-progress: true
+
+jobs:
+ generate:
+ strategy:
+ matrix:
+ # TODO: test an all the supported OS
+ # [ubuntu-20.04, macos-latest, windows-latest]
+ os: [ubuntu-20.04]
+
+ runs-on: ${{ matrix.os }}
+ steps:
+ - name: Check out code
+ uses: actions/checkout@v2
+ - name: Install Go
+ uses: actions/setup-go@v1
+ with:
+ # make generate requires Go >=1.17
+ go-version: 1.17.x
Review Comment:
Yeah, the workflow just tests `make generate`; it makes sure the target runs fine, as I found this target is fragile and easy to be in a state of not working, e.g. it doesn't run with Go 1.16 or sometimes `go mod tidy` has tidied up too much of `go.mod` . We discover that only when we try to run the target. This workflow should find such breaking changes earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3409: chore(ci): regen docs & add generate workflow to test `make generate`
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3409:
URL: https://github.com/apache/camel-k/pull/3409#discussion_r912718854
##########
.github/workflows/generate.yml:
##########
@@ -0,0 +1,69 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: generate
+
+on:
+ pull_request:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.adoc'
+ - '**.md'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+ push:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.md'
+ - '**.adoc'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
+ cancel-in-progress: true
+
+jobs:
+ generate:
+ strategy:
+ matrix:
+ # TODO: test an all the supported OS
+ # [ubuntu-20.04, macos-latest, windows-latest]
+ os: [ubuntu-20.04]
+
+ runs-on: ${{ matrix.os }}
+ steps:
+ - name: Check out code
+ uses: actions/checkout@v2
+ - name: Install Go
+ uses: actions/setup-go@v1
+ with:
+ # make generate requires Go >=1.17
+ go-version: 1.17.x
Review Comment:
We're still on 1.16. We may need to wait #2845 before merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3409: chore(ci): regen docs & add generate workflow to test `make generate`
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3409:
URL: https://github.com/apache/camel-k/pull/3409#discussion_r912836585
##########
.github/workflows/generate.yml:
##########
@@ -0,0 +1,69 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: generate
+
+on:
+ pull_request:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.adoc'
+ - '**.md'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+ push:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.md'
+ - '**.adoc'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
+ cancel-in-progress: true
+
+jobs:
+ generate:
+ strategy:
+ matrix:
+ # TODO: test an all the supported OS
+ # [ubuntu-20.04, macos-latest, windows-latest]
+ os: [ubuntu-20.04]
+
+ runs-on: ${{ matrix.os }}
+ steps:
+ - name: Check out code
+ uses: actions/checkout@v2
+ - name: Install Go
+ uses: actions/setup-go@v1
+ with:
+ # make generate requires Go >=1.17
+ go-version: 1.17.x
Review Comment:
Thanks, the suggested name is better. In the future, it might be worth adding the 'real' generate workflow that automatically generates docs for us. But let's do it another time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3409: chore(ci): regen docs & add generate workflow to test `make generate`
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3409:
URL: https://github.com/apache/camel-k/pull/3409#discussion_r912794669
##########
.github/workflows/generate.yml:
##########
@@ -0,0 +1,69 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: generate
+
+on:
+ pull_request:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.adoc'
+ - '**.md'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+ push:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.md'
+ - '**.adoc'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
+ cancel-in-progress: true
+
+jobs:
+ generate:
+ strategy:
+ matrix:
+ # TODO: test an all the supported OS
+ # [ubuntu-20.04, macos-latest, windows-latest]
+ os: [ubuntu-20.04]
+
+ runs-on: ${{ matrix.os }}
+ steps:
+ - name: Check out code
+ uses: actions/checkout@v2
+ - name: Install Go
+ uses: actions/setup-go@v1
+ with:
+ # make generate requires Go >=1.17
+ go-version: 1.17.x
Review Comment:
Okey, so, the idea of the action is to run it just to report any problem, not to generate on behalf of the user. I'd call it `verify-generate` to avoid creating confusion on the goal of the action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3409: chore(ci): regen docs & add generate workflow to test `make generate`
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3409:
URL: https://github.com/apache/camel-k/pull/3409#issuecomment-1173459785
@squakez @phantomjinx @oscerd Could anybody review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3409: chore(ci): regen docs & add generate workflow to test `make generate`
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3409:
URL: https://github.com/apache/camel-k/pull/3409#discussion_r912768079
##########
.github/workflows/generate.yml:
##########
@@ -0,0 +1,69 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: generate
+
+on:
+ pull_request:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.adoc'
+ - '**.md'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+ push:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.md'
+ - '**.adoc'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
+ cancel-in-progress: true
+
+jobs:
+ generate:
+ strategy:
+ matrix:
+ # TODO: test an all the supported OS
+ # [ubuntu-20.04, macos-latest, windows-latest]
+ os: [ubuntu-20.04]
+
+ runs-on: ${{ matrix.os }}
+ steps:
+ - name: Check out code
+ uses: actions/checkout@v2
+ - name: Install Go
+ uses: actions/setup-go@v1
+ with:
+ # make generate requires Go >=1.17
+ go-version: 1.17.x
Review Comment:
> doesn't commit any changes to the repo
I thought it was adding the generate doc back to the repo. Can you please clarify what the action does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi merged pull request #3409: chore(ci): regen docs & add generate workflow to test `make generate`
Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3409:
URL: https://github.com/apache/camel-k/pull/3409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3409: chore(ci): regen docs & add generate workflow to test `make generate`
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3409:
URL: https://github.com/apache/camel-k/pull/3409#discussion_r912752604
##########
.github/workflows/generate.yml:
##########
@@ -0,0 +1,69 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# ---------------------------------------------------------------------------
+
+name: generate
+
+on:
+ pull_request:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.adoc'
+ - '**.md'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+ push:
+ branches:
+ - main
+ - "release-*"
+ paths-ignore:
+ - 'docs/**'
+ - 'proposals/**'
+ - '**.md'
+ - '**.adoc'
+ - 'KEYS'
+ - 'LICENSE'
+ - 'NOTICE'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
+ cancel-in-progress: true
+
+jobs:
+ generate:
+ strategy:
+ matrix:
+ # TODO: test an all the supported OS
+ # [ubuntu-20.04, macos-latest, windows-latest]
+ os: [ubuntu-20.04]
+
+ runs-on: ${{ matrix.os }}
+ steps:
+ - name: Check out code
+ uses: actions/checkout@v2
+ - name: Install Go
+ uses: actions/setup-go@v1
+ with:
+ # make generate requires Go >=1.17
+ go-version: 1.17.x
Review Comment:
Yes, but it just runs test with `make generate` and doesn't commit any changes to the repo, so it should be safe to go ahead to merge it. And after all `make generate` hasn't been working with Go 1.16.x so there's no reason to worry about backward compatibility on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org