You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/12 13:40:21 UTC
[GitHub] [pulsar] lhotari opened a new pull request #10198: Fix some ExecutorService leaks
lhotari opened a new pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198
### Motivation
Some tests don't close all ExecutorServices created in tests. There were also a few issues in production code where ExecutorServices weren't closed.
### Modifications
- consistently close ExecutorServices created in tests
- prefer the usage of Lombok's `@Cleanup("shutdownNow")` for calling the `.shutdownNow()` method.
- In tests, use `shutdownNow()` instead of `shutdown()` so that executors are closed asap instead of waiting for in-progress tasks to complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818688174
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819552456
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818688174
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-817996771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818952721
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819198148
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818442965
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818463538
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819225723
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818012073
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819010320
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819130715
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818319274
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818762591
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819258219
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819326473
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-817998712
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818952721
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818762591
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818714162
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818395268
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819225723
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818319274
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818463538
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-817998712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819198148
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818714162
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-817996776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819130715
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818442965
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819258219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819288443
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-819509382
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari removed a comment on pull request #10198: Fix some ExecutorService leaks
Posted by GitBox <gi...@apache.org>.
lhotari removed a comment on pull request #10198:
URL: https://github.com/apache/pulsar/pull/10198#issuecomment-818395268
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org