You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2024/05/17 05:01:51 UTC
[PR] MINOR: [C++] Revert change in ipc/CMakeLists.txt [arrow]
amoeba opened a new pull request, #41701:
URL: https://github.com/apache/arrow/pull/41701
### Rationale for this change
https://github.com/apache/arrow/pull/40392 introduced a mistake in the the associated CMakeLists.txt, noticed by @kou in https://github.com/apache/arrow/pull/40392#discussion_r1604344494.
### What changes are included in this PR?
A reversion of that change.
### Are these changes tested?
No.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Revert change in ipc/CMakeLists.txt [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41701:
URL: https://github.com/apache/arrow/pull/41701#issuecomment-2117035056
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit dc973c2bde2d8a4cf789805e758070290c2669b9.
There were 4 benchmark results indicating a performance regression:
- Commit Run on `ursa-i9-9960x` at [2024-05-17 05:19:17Z](https://conbench.ursa.dev/compare/runs/d2369671419849f0a35e7f6e21cf662f...9d58273f25264af4af0b01155c164279/)
- [`file-read` (Python) with compression=uncompressed, dataset=fanniemae_2016Q4, file_type=feather, output_type=dataframe](https://conbench.ursa.dev/compare/benchmarks/06646a7797687b3d80005bae63134b67...06646f9988997d0d8000a77c3c9d0306)
- [`file-read` (Python) with compression=uncompressed, dataset=fanniemae_2016Q4, file_type=feather, output_type=table](https://conbench.ursa.dev/compare/benchmarks/06646a760afd7be0800003bc5b67b2d5...06646f97c942712f80006cbc52125765)
- and 2 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/25091452425) has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Revert change in ipc/CMakeLists.txt [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba merged PR #41701:
URL: https://github.com/apache/arrow/pull/41701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [C++] Revert change in ipc/CMakeLists.txt [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #41701:
URL: https://github.com/apache/arrow/pull/41701#issuecomment-2116634758
Thanks for the quick look @mapleFU.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org