[GitHub] [hudi] boneanxs commented on a diff in pull request #8548: [WIP][HUDI-6126] Fix test `testInsertDatasetWIthTimelineTimezoneUTC`

["boneanxs (via GitHub)" <gi...@apache.org>]

boneanxs commented on code in PR #8548:
URL: https://github.com/apache/hudi/pull/8548#discussion_r1174534105


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala:
##########
@@ -1250,6 +1251,7 @@ class TestHoodieSparkSqlWriter {
 
     assertTrue(beforeWriteInstant.toEpochMilli < writeInstant.toEpochMilli,
       s"writeInstant(${writeInstant.toEpochMilli}) must always be greater than beforeWriteInstant(${beforeWriteInstant.toEpochMilli}) if writeInstant was generated with UTC timezone")
+    TimeZone.setDefault(defaultTimezone)

Review Comment:
   Should wrap with `try ... finally` incase some errors throw out before this code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org