You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/11 19:51:03 UTC
[GitHub] [arrow-rs] ryan-jacobs1 opened a new pull request, #1689: support duration in ffi
ryan-jacobs1 opened a new pull request, #1689:
URL: https://github.com/apache/arrow-rs/pull/1689
# Which issue does this PR close?
Closes #1688.
# Rationale for this change
The Duration type is implemented in Rust but not in FFI. As the type is present in Rust, it should also be present in FFI.
# What changes are included in this PR?
The Duration type is now supported in FFI.
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1689: support duration in ffi
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1689:
URL: https://github.com/apache/arrow-rs/pull/1689#discussion_r870753283
##########
arrow-pyarrow-integration-testing/tests/test_sql.py:
##########
@@ -55,6 +55,10 @@ def assert_pyarrow_leak():
pa.timestamp("us"),
pa.timestamp("us", tz="UTC"),
pa.timestamp("us", tz="Europe/Paris"),
+ pa.duration("s"),
+ pa.duration("ms"),
+ pa.duration("us"),
+ pa.duration("ns"),
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #1689: support duration in ffi
Posted by GitBox <gi...@apache.org>.
viirya merged PR #1689:
URL: https://github.com/apache/arrow-rs/pull/1689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ryan-jacobs1 commented on pull request #1689: support duration in ffi
Posted by GitBox <gi...@apache.org>.
ryan-jacobs1 commented on PR #1689:
URL: https://github.com/apache/arrow-rs/pull/1689#issuecomment-1124291191
@viirya fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1689: support duration in ffi
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1689:
URL: https://github.com/apache/arrow-rs/pull/1689#issuecomment-1124462260
Merged, thanks @ryan-jacobs1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org