You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Tanping Wang (JIRA)" <ji...@apache.org> on 2011/05/24 00:51:48 UTC
[jira] [Created] (HDFS-1986) Add an option for user to return http
or https ports regardless of security is on/off in DFSUtil.getInfoServer()
Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
----------------------------------------------------------------------------------------------------------------
Key: HDFS-1986
URL: https://issues.apache.org/jira/browse/HDFS-1986
Project: Hadoop HDFS
Issue Type: Bug
Components: tools
Affects Versions: 0.23.0
Reporter: Tanping Wang
Assignee: Tanping Wang
Priority: Minor
Fix For: 0.23.0
Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1986) Add an option for user to return http
or https ports regardless of security is on/off in DFSUtil.getInfoServer()
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-1986:
-------------------------------
Attachment: HDFS-1986.patch
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1986) Add an option for user to return
http or https ports regardless of security is on/off in
DFSUtil.getInfoServer()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043106#comment-13043106 ]
Hadoop QA commented on HDFS-1986:
---------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481281/HDFS-1986.2.patch
against trunk revision 1130734.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/692//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/692//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/692//console
This message is automatically generated.
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.2.patch, HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1986) Add an option for user to return
http or https ports regardless of security is on/off in
DFSUtil.getInfoServer()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042358#comment-13042358 ]
Hadoop QA commented on HDFS-1986:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480182/HDFS-1986.patch
against trunk revision 1129942.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestDFSUpgradeFromImage
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/673//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/673//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/673//console
This message is automatically generated.
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1986) Add an option for user to return http
or https ports regardless of security is on/off in DFSUtil.getInfoServer()
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-1986:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I committed the patch. Thank you Tanping.
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.2.patch, HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1986) Add an option for user to return
http or https ports regardless of security is on/off in
DFSUtil.getInfoServer()
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043127#comment-13043127 ]
Suresh Srinivas commented on HDFS-1986:
---------------------------------------
+1 for the change
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.2.patch, HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1986) Add an option for user to return
http or https ports regardless of security is on/off in
DFSUtil.getInfoServer()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043328#comment-13043328 ]
Hudson commented on HDFS-1986:
------------------------------
Integrated in Hadoop-Hdfs-trunk #686 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/686/])
HDFS-1986. Add option to get http/https address from DFSUtil#getInfoServer(). Contributed by Tanping Wang.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130870
Files :
* /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/tools/DFSck.java
* /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSUtil.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSUtil.java
* /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java
* /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
* /hadoop/hdfs/trunk/CHANGES.txt
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.2.patch, HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1986) Add an option for user to return
http or https ports regardless of security is on/off in
DFSUtil.getInfoServer()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043136#comment-13043136 ]
Hudson commented on HDFS-1986:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #709 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/709/])
HDFS-1986. Add option to get http/https address from DFSUtil#getInfoServer(). Contributed by Tanping Wang.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130870
Files :
* /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/tools/DFSck.java
* /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSUtil.java
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSUtil.java
* /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/ClusterJspHelper.java
* /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
* /hadoop/hdfs/trunk/CHANGES.txt
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.2.patch, HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1986) Add an option for user to return http
or https ports regardless of security is on/off in DFSUtil.getInfoServer()
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-1986:
----------------------------------
Status: Patch Available (was: Open)
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1986) Add an option for user to return http
or https ports regardless of security is on/off in DFSUtil.getInfoServer()
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-1986:
-------------------------------
Attachment: HDFS-1986.2.patch
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.2.patch, HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1986) Add an option for user to return
http or https ports regardless of security is on/off in
DFSUtil.getInfoServer()
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042295#comment-13042295 ]
Suresh Srinivas commented on HDFS-1986:
---------------------------------------
Comments:
# TestDFSUtil.java - {{InetSocketAddress is = new InetSocketAddress(1234);}} I am not clear how this maps to namenode address?
# DFSUtil.java - {{checkSecurity}} could be named {{httpsAddress}}. @param checkSecurity needs to be reworded. The method returns an address and not port. @return needs to be reworded too.
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1986) Add an option for user to return
http or https ports regardless of security is on/off in
DFSUtil.getInfoServer()
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043047#comment-13043047 ]
Tanping Wang commented on HDFS-1986:
------------------------------------
upload patch to address review comments.
> Add an option for user to return http or https ports regardless of security is on/off in DFSUtil.getInfoServer()
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1986
> URL: https://issues.apache.org/jira/browse/HDFS-1986
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1986.2.patch, HDFS-1986.patch
>
>
> Currently DFSUtil.getInfoServer gets http port with security off and httpS port with security on. However, we want to return http port regardless of security on/off for Cluster UI to use. Add in a third Boolean parameter for user to decide whether to check security or not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira