You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "li-keguo (via GitHub)" <gi...@apache.org> on 2023/07/02 15:15:43 UTC
[GitHub] [shenyu] li-keguo opened a new pull request, #4787: [type Refactor]extractor add BaseAnnotationApiBeansExtractor
li-keguo opened a new pull request, #4787:
URL: https://github.com/apache/shenyu/pull/4787
about issue #4560
work list:
- [ ] add BaseAnnotationApiBeansExtractor.
- [ ] Refactor SpringCloudApiBeansExtractor.
- [ ] Refactor SpringMvcApiBeansExtractor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] tian-pengfei merged pull request #4787: [type Refactor]extractor add BaseAnnotationApiBeansExtractor
Posted by "tian-pengfei (via GitHub)" <gi...@apache.org>.
tian-pengfei merged PR #4787:
URL: https://github.com/apache/shenyu/pull/4787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] tian-pengfei commented on pull request #4787: [type Refactor]extractor add BaseAnnotationApiBeansExtractor
Posted by "tian-pengfei (via GitHub)" <gi...@apache.org>.
tian-pengfei commented on PR #4787:
URL: https://github.com/apache/shenyu/pull/4787#issuecomment-1617243849
Wonderful improvement!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4787: [type Refactor]extractor add BaseAnnotationApiBeansExtractor
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4787:
URL: https://github.com/apache/shenyu/pull/4787#issuecomment-1616717346
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4787](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3167ab4) into [master](https://app.codecov.io/gh/apache/shenyu/commit/eca121193e0fb039dcbd3a1b85ef499227f36fd6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (eca1211) will **decrease** coverage by `0.21%`.
> The diff coverage is `48.07%`.
```diff
@@ Coverage Diff @@
## master #4787 +/- ##
============================================
- Coverage 65.62% 65.42% -0.21%
+ Complexity 8144 8141 -3
============================================
Files 1133 1135 +2
Lines 33162 33224 +62
Branches 2969 2963 -6
============================================
- Hits 21764 21736 -28
- Misses 9667 9757 +90
Partials 1731 1731
```
| [Impacted Files](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ter/extractor/BaseAnnotationApiBeansExtractor.java](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9leHRyYWN0b3IvQmFzZUFubm90YXRpb25BcGlCZWFuc0V4dHJhY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...core/register/extractor/BaseApiBeansExtractor.java](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9leHRyYWN0b3IvQmFzZUFwaUJlYW5zRXh0cmFjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nyuSpringCloudClientInfoRegisterConfiguration.java](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItY2xpZW50L3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3NwcmluZ2Jvb3Qvc3RhcnRlci9jbGllbnQvc3ByaW5nY2xvdWQvU2hlbnl1U3ByaW5nQ2xvdWRDbGllbnRJbmZvUmVnaXN0ZXJDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...henyuSpringMvcClientInfoRegisterConfiguration.java](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItY2xpZW50L3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zcHJpbmdib290L3N0YXJ0ZXIvY2xpZW50L3NwcmluZ212Yy9TaGVueXVTcHJpbmdNdmNDbGllbnRJbmZvUmVnaXN0ZXJDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/shenyu/client/core/register/ApiBean.java](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9BcGlCZWFuLmphdmE=) | `53.84% <49.12%> (-17.27%)` | :arrow_down: |
| [...ngcloud/register/SpringCloudApiBeansExtractor.java](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9yZWdpc3Rlci9TcHJpbmdDbG91ZEFwaUJlYW5zRXh0cmFjdG9yLmphdmE=) | `73.07% <75.00%> (-9.07%)` | :arrow_down: |
| [...springmvc/register/SpringMvcApiBeansExtractor.java](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvc3ByaW5nbXZjL3JlZ2lzdGVyL1NwcmluZ012Y0FwaUJlYW5zRXh0cmFjdG9yLmphdmE=) | `87.50% <94.44%> (+5.35%)` | :arrow_up: |
| [...re/register/registrar/AbstractApiDocRegistrar.java](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9yZWdpc3RyYXIvQWJzdHJhY3RBcGlEb2NSZWdpc3RyYXIuamF2YQ==) | `94.02% <100.00%> (+0.09%)` | :arrow_up: |
| [...ringcloud/register/SpringCloudApiMetaRegister.java](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9yZWdpc3Rlci9TcHJpbmdDbG91ZEFwaU1ldGFSZWdpc3Rlci5qYXZh) | `93.54% <100.00%> (+0.10%)` | :arrow_up: |
| [...t/springmvc/register/SpringMvcApiMetaRegister.java](https://app.codecov.io/gh/apache/shenyu/pull/4787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvc3ByaW5nbXZjL3JlZ2lzdGVyL1NwcmluZ012Y0FwaU1ldGFSZWdpc3Rlci5qYXZh) | `90.90% <100.00%> (+0.13%)` | :arrow_up: |
... and [18 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4787/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org