You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2020/11/03 00:03:10 UTC
Review Request 73001: RANGER-3068: Ranger Usersync is not handling
error during initialization process
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73001/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
Bugs: RANGER-3068
https://issues.apache.org/jira/browse/RANGER-3068
Repository: ranger
Description
-------
Added code to handle error during initialization as well as while updating users, group, and memberships to ranger admin
Diffs
-----
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 6a4661e60
Diff: https://reviews.apache.org/r/73001/diff/1/
Testing
-------
Patched changes to a cluster and tested error conditions.
Also tested basic regression cases.
Thanks,
Sailaja Polavarapu
Re: Review Request 73001: RANGER-3068: Ranger Usersync is not
handling error during initialization process
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73001/#review222160
-----------------------------------------------------------
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Line 328 (original), 329 (patched)
<https://reviews.apache.org/r/73001/#comment311229>
Please check the message for spellings
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 367 (patched)
<https://reviews.apache.org/r/73001/#comment311230>
Please see if this can be changed to
throw e;
here and other places in the code.
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 808 (patched)
<https://reviews.apache.org/r/73001/#comment311231>
Please print the exception in the error message such as
LOG.error("Failed to addOrUpdateUsers " + uploadedCount, e);
Here and elsewhere in the code.
- Abhay Kulkarni
On Nov. 3, 2020, 12:03 a.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73001/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2020, 12:03 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3068
> https://issues.apache.org/jira/browse/RANGER-3068
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added code to handle error during initialization as well as while updating users, group, and memberships to ranger admin
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 6a4661e60
>
>
> Diff: https://reviews.apache.org/r/73001/diff/1/
>
>
> Testing
> -------
>
> Patched changes to a cluster and tested error conditions.
> Also tested basic regression cases.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 73001: RANGER-3068: Ranger Usersync is not
handling error during initialization process
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73001/#review222161
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Nov. 3, 2020, 1:23 a.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73001/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2020, 1:23 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3068
> https://issues.apache.org/jira/browse/RANGER-3068
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added code to handle error during initialization as well as while updating users, group, and memberships to ranger admin
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 6a4661e60
>
>
> Diff: https://reviews.apache.org/r/73001/diff/2/
>
>
> Testing
> -------
>
> Patched changes to a cluster and tested error conditions.
> Also tested basic regression cases.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 73001: RANGER-3068: Ranger Usersync is not
handling error during initialization process
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73001/
-----------------------------------------------------------
(Updated Nov. 3, 2020, 1:23 a.m.)
Review request for ranger, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
Changes
-------
Incorporated review comments
Bugs: RANGER-3068
https://issues.apache.org/jira/browse/RANGER-3068
Repository: ranger
Description
-------
Added code to handle error during initialization as well as while updating users, group, and memberships to ranger admin
Diffs (updated)
-----
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 6a4661e60
Diff: https://reviews.apache.org/r/73001/diff/2/
Changes: https://reviews.apache.org/r/73001/diff/1-2/
Testing
-------
Patched changes to a cluster and tested error conditions.
Also tested basic regression cases.
Thanks,
Sailaja Polavarapu