[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4823: Enhance RoutingTable with ServerInstance

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4823: Enhance RoutingTable with ServerInstance
URL: https://github.com/apache/incubator-pinot/pull/4823#discussion_r346549182
 
 

 ##########
 File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/ConnectionPoolBrokerRequestHandler.java
 ##########
 @@ -232,6 +237,19 @@ protected BrokerResponse processBrokerRequest(long requestId, BrokerRequest orig
     return brokerResponse;
   }
 
+  // For backward-compatible
+  private Map<String, List<String>> convertToOldRoutingTable(
 
 Review comment:
   The connection-pool routing is already deprecated, and is subject to be removed, thus here we just keep it backward-compatible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org