[GitHub] [pulsar] MarvinCai opened a new pull request #3797: Support kafka timeout

[GitBox <gi...@apache.org>]

MarvinCai opened a new pull request #3797: Support kafka timeout
URL: https://github.com/apache/pulsar/pull/3797
 
 
   **Motivatio** 
   Support Kafka's ProducerConfig.REQUEST_TIMEOUT_MS_CONFIG  #1090 
   
   Previously `ProducerBuilder.sendTimeout` was set by parsing Kafka's `ProducerConfig.MAX_BLOCK_MS_CONFIG`.
   According to Kafka's [document](https://kafka.apache.org/20/documentation.html) it's for   
   
   > Controlling how long KafkaProducer.send() and KafkaProducer.partitionsFor() will block either because the buffer is full or metadata unavailable.
   
   But `ProducerBuilder.sendTimeout`  is for  
   
   > If a message is not acknowledged by the server before the sendTimeout expires, an error will be reported.
   
   And Kaska's `ProducerConfig.REQUEST_TIMEOUT_MS_CONFIG`, according to the document is for:
   > Controlling the maximum amount of time the client will wait for the response of a request.
   
   Which I think would be better fit purpose of Pulsar's `ProducerBuilder.sendTimeout`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services