You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/23 07:08:28 UTC

[GitHub] [incubator-tvm] siju-samuel commented on pull request #5887: keep parameter names from PyTorch

siju-samuel commented on pull request #5887:
URL: https://github.com/apache/incubator-tvm/pull/5887#issuecomment-647953471


   @t-vi Thanks for the PR. 
   I think this PR has slight impact in some scenarios.
   You can confirm by running the below script before and after your change.
   
   [ pytorch_pretrained_bert_uncased.py](https://gist.github.com/siju-samuel/f67aa3e1d0568c7b53876c4fb4e7a56c)
   
   I think after this PR, the `param_tensor` and `param` is not getting assinged properly in some cases..
   Please look into this. 
   Thanks in advance.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org