You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/01 11:44:27 UTC
[jira] [Commented] (LOG4NET-473) Option for file extension in
SmtpPickupDirAppender
[ https://issues.apache.org/jira/browse/LOG4NET-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984340#comment-14984340 ]
ASF GitHub Bot commented on LOG4NET-473:
----------------------------------------
GitHub user albinsunnanbo opened a pull request:
https://github.com/apache/log4net/pull/19
File extension for smtp appender
Add a configuration option for adding a file extension to the generated mails.
Updated patch from https://issues.apache.org/jira/browse/LOG4NET-473
Based on https://github.com/apache/log4net/pull/17
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/albinsunnanbo/log4net FileExtensionForSmtpAppender
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/log4net/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit 899579668d6b75711a425005fa4861fdeb3932e1
Author: Albin Sunnanbo <al...@sunnanbo.com>
Date: 2015-11-01T09:35:54Z
Create basic SmtpPickupDirAppenderTest
commit 9f0a9e0857d58cec19673de95c2a28292dfdc171
Author: Albin Sunnanbo <al...@sunnanbo.com>
Date: 2015-10-31T21:32:41Z
Add option for file extensions to the SmtpPickupDirAppender
- Especially on Windows file extensions are very handy, if you give the output files the `eml` extension you can just double click the file to open the mail in outlook.
- I have added a `FileExtension` option to the `SmtpPickupDirAppender` that can be used to specify a file extension for the generated files.
- Although a default value of `eml` would be nice I have preserved backwards compatibility of no file extension by default.
----
> Option for file extension in SmtpPickupDirAppender
> --------------------------------------------------
>
> Key: LOG4NET-473
> URL: https://issues.apache.org/jira/browse/LOG4NET-473
> Project: Log4net
> Issue Type: New Feature
> Affects Versions: 1.2.13
> Reporter: Albin Sunnanbo
> Attachments: SmtpPickupDirAppender-fileextension.patch
>
>
> Especially on Windows file extensions are very handy, if you give the output files the `eml` extension you can just double click the file to open the mail in outlook.
> I have added a `FileExtension` option to the `SmtpPickupDirAppender` that can be used to specify a file extension for the generated files.
> Although a default value of `eml` would be nice I have preserved backwards compatibility of no file extension by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)