[jira] [Commented] (HIVE-5336) HCatSchema.remove(HCatFieldSchema hcatFieldSchema) should renumber the fieldPositionMap and the fieldPositionMap should not be cached by the end user

["Sushanth Sowmyan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967316#comment-13967316 ] 

Sushanth Sowmyan commented on HIVE-5336:
----------------------------------------

Patch looks good to me, +1 on intent. It does not apply on current trunk, however, so I rebased it so we could run our precommit tests on it. Attaching that patch.

> HCatSchema.remove(HCatFieldSchema hcatFieldSchema) should renumber the  fieldPositionMap and the fieldPositionMap should not be cached by the end user
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5336
>                 URL: https://issues.apache.org/jira/browse/HIVE-5336
>             Project: Hive
>          Issue Type: Bug
>          Components: HCatalog
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-5336.1.patch.txt, HIVE-5336.2.patch.txt, HIVE-5336.3.patch
>
>
> HCatSchema.remove currently does not renumber the fieldPositionMap which can be a problem when there are interleaving append() and remove() calls.
> 1. We should document that fieldPositionMap should not be cached by the end-user
> 2. We should make sure that the fieldPositionMap gets renumbered after remove() because HcatSchema.get will otherwise return wrong FieldSchemas.



--
This message was sent by Atlassian JIRA
(v6.2#6252)