You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "sultanalieva-s (via GitHub)" <gi...@apache.org> on 2023/02/07 18:58:09 UTC

[GitHub] [beam] sultanalieva-s opened a new pull request, #25365: Refactoring: Moved hard coded environment variables' names into constants.

sultanalieva-s opened a new pull request, #25365:
URL: https://github.com/apache/beam/pull/25365

   Moved environment variables' names into constants.
   Addresses  #25202
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TSultanov commented on a diff in pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "TSultanov (via GitHub)" <gi...@apache.org>.
TSultanov commented on code in PR #25365:
URL: https://github.com/apache/beam/pull/25365#discussion_r1122922847


##########
playground/infrastructure/constants.py:
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+BEAM_ROOT_DIR_ENV_VAR_KEY = "BEAM_ROOT_DIR"
+BEAM_EXAMPLE_CATEGORIES_ENV_VAR_KEY = "BEAM_EXAMPLE_CATEGORIES"
+SERVER_ADDRESS_ENV_VAR_KEY = "SERVER_ADDRESS"
+SDK_CONFIG_ENV_VAR_KEY = "SDK_CONFIG"
+BEAM_USE_WEBGRPC_ENV_VAR_KEY = 'BEAM_USE_WEBGRPC'

Review Comment:
   ```suggestion
   BEAM_USE_WEBGRPC_ENV_VAR_KEY = "BEAM_USE_WEBGRPC"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25365:
URL: https://github.com/apache/beam/pull/25365#issuecomment-1425078686

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] sultanalieva-s commented on pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "sultanalieva-s (via GitHub)" <gi...@apache.org>.
sultanalieva-s commented on PR #25365:
URL: https://github.com/apache/beam/pull/25365#issuecomment-1423125698

   .retest
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] sultanalieva-s commented on pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "sultanalieva-s (via GitHub)" <gi...@apache.org>.
sultanalieva-s commented on PR #25365:
URL: https://github.com/apache/beam/pull/25365#issuecomment-1425366139

   Run Python Precommit
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25365:
URL: https://github.com/apache/beam/pull/25365#issuecomment-1424900629

   r: @olehborysevych 
   would you please review this contribution from a community member? : )
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem merged PR #25365:
URL: https://github.com/apache/beam/pull/25365


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25365:
URL: https://github.com/apache/beam/pull/25365#issuecomment-1424944541

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25365:
URL: https://github.com/apache/beam/pull/25365#issuecomment-1478568041

   LGTM! I'll merge once tests pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] sultanalieva-s commented on pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "sultanalieva-s (via GitHub)" <gi...@apache.org>.
sultanalieva-s commented on PR #25365:
URL: https://github.com/apache/beam/pull/25365#issuecomment-1423121511

   retest this please
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TSultanov commented on pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "TSultanov (via GitHub)" <gi...@apache.org>.
TSultanov commented on PR #25365:
URL: https://github.com/apache/beam/pull/25365#issuecomment-1451887880

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TSultanov commented on a diff in pull request #25365: Refactoring: Moved hard coded environment variables' names into constants.

Posted by "TSultanov (via GitHub)" <gi...@apache.org>.
TSultanov commented on code in PR #25365:
URL: https://github.com/apache/beam/pull/25365#discussion_r1104441227


##########
playground/infrastructure/checker.py:
##########
@@ -90,10 +91,10 @@ def check_sdk_examples(paths: List[PurePath], sdk: Sdk, root_dir: str) -> bool:
 def main():
     args = parse_args()
 
-    root_dir = os.getenv("BEAM_ROOT_DIR")
+    root_dir = os.getenv(BEAM_ROOT_DIR_ENV_VAR_KEY)
     if root_dir is None:
         raise KeyError("BEAM_ROOT_DIR environment variable should be specified in os")

Review Comment:
   Please use value from the new constant when building the error message so won't get out of sync with the actually expected value



##########
playground/infrastructure/checker.py:
##########
@@ -90,10 +91,10 @@ def check_sdk_examples(paths: List[PurePath], sdk: Sdk, root_dir: str) -> bool:
 def main():
     args = parse_args()
 
-    root_dir = os.getenv("BEAM_ROOT_DIR")
+    root_dir = os.getenv(BEAM_ROOT_DIR_ENV_VAR_KEY)
     if root_dir is None:
         raise KeyError("BEAM_ROOT_DIR environment variable should be specified in os")
-    categories_file = os.getenv("BEAM_EXAMPLE_CATEGORIES")
+    categories_file = os.getenv(BEAM_EXAMPLE_CATEGORIES_ENV_VAR_KEY)
     if categories_file is None:
         raise KeyError("BEAM_EXAMPLE_CATEGORIES environment variable should be specified in os")

Review Comment:
   Please use value from the new constant when building the error message



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org