You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/02/26 16:23:42 UTC
[GitHub] rabbah commented on a change in pull request #4307: Use custom
runtime manifest for YARN tests
rabbah commented on a change in pull request #4307: Use custom runtime manifest for YARN tests
URL: https://github.com/apache/incubator-openwhisk/pull/4307#discussion_r260367945
##########
File path: tests/src/test/scala/org/apache/openwhisk/core/containerpool/yarn/test/YARNContainerFactoryTests.scala
##########
@@ -37,10 +37,41 @@ import scala.concurrent.duration._
@RunWith(classOf[JUnitRunner])
class YARNContainerFactoryTests extends Suite with BeforeAndAfter with FlatSpecLike with ExecHelpers {
+
+ implicit val whiskConfig: WhiskConfig = new WhiskConfig(Map(wskApiHostname -> "apihost") ++ wskApiHost)
+
+ val customManifest = Some(s"""
+ |{ "runtimes": {
+ | "runtime1": [
+ | {
+ | "kind": "somekind:1",
+ | "deprecated": false,
+ | "default": true,
+ | "image": {
+ | "prefix": "openwhisk",
+ | "name": "somekind",
+ | "tag": "latest"
+ | }
+ | }
+ | ],
+ | "runtime2": [
+ | {
+ | "kind": "anotherkind:1",
+ | "deprecated": false,
+ | "default": true,
+ | "image": {
+ | "prefix": "openwhisk",
+ | "name": "anotherkind",
+ | "tag": "latest"
+ | }
+ | }
+ | ]
+ | }
+ |}
+ |""".stripMargin)
val images = Array(
- ImageName("nodejs6action", Option("openwhisk"), imageTag("nodejs:6")),
- ImageName("python3action", Option("openwhisk"), imageTag("python:3")))
Review comment:
should we delete `imageTag` - I think it's unused code now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services