You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/11/15 19:38:21 UTC

[GitHub] [trafficserver] SolidWallOfCode commented on a diff in pull request #9193: Refurbish IPAllow with libswoc.

SolidWallOfCode commented on code in PR #9193:
URL: https://github.com/apache/trafficserver/pull/9193#discussion_r1023190438


##########
src/tscpp/util/ts_diags.cc:
##########
@@ -0,0 +1,33 @@
+/** @file Support for common diagnostics between core, plugins, and libswoc.

Review Comment:
   Those changes are incidental and one reason it's still a draft. I made a 1.4.0 release of libswoc and I'll set up a PR to bring that in to 10-Dev, which should remove all of the libswoc changes in this PR. Let me check on "ts_diags.cc" - I'm working on yet another PR to make just the `Errata` changes and that's part of it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org