You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/07/12 04:02:18 UTC

[GitHub] [incubator-opendal] Xuanwo opened a new issue, #2616: faet: Add AwaitTree to allow users dump this execution tree at runtime

Xuanwo opened a new issue, #2616:
URL: https://github.com/apache/incubator-opendal/issues/2616

   `await-tree` allows developers to dump this execution tree at runtime, with the span of each Future annotated by `instrument_await`.
   
   https://github.com/risingwavelabs/await-tree
   
   ```rust
   use std::time::Duration;
   
   use await_tree::{Config, InstrumentAwait, Registry};
   use futures::future::{join, pending};
   use tokio::time::sleep;
   
   async fn bar(i: i32) {
       // `&'static str` span
       baz(i).instrument_await("baz in bar").await
   }
   
   async fn baz(i: i32) {
       // runtime `String` span is also supported
       pending()
           .instrument_await(format!("pending in baz {i}"))
           .await
   }
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] oowl commented on issue #2616: faet: Add AwaitTree to allow users dump this execution tree at runtime

Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl commented on issue #2616:
URL: https://github.com/apache/incubator-opendal/issues/2616#issuecomment-1632747426

   It seems we need to add `instrument_await` to our main logic `await` position?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] oowl closed issue #2616: feat: Add AwaitTreeLayer to allow users dump this execution tree at runtime

Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl closed issue #2616: feat: Add AwaitTreeLayer to allow users dump this execution tree at runtime
URL: https://github.com/apache/incubator-opendal/issues/2616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #2616: faet: Add AwaitTree to allow users dump this execution tree at runtime

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2616:
URL: https://github.com/apache/incubator-opendal/issues/2616#issuecomment-1632800491

   No. We should implement those logic in layer instead. OpenDAL won't introduce cost where users don't need.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] oowl commented on issue #2616: feat: Add AwaitTreeLayer to allow users dump this execution tree at runtime

Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl commented on issue #2616:
URL: https://github.com/apache/incubator-opendal/issues/2616#issuecomment-1652132679

   done https://github.com/apache/incubator-opendal/pull/2623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org