You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/26 10:31:52 UTC
[GitHub] [maven] McFoggy opened a new pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
McFoggy opened a new pull request #437:
URL: https://github.com/apache/maven/pull/437
as discussed in the dev mailing list [[1](https://mail-archives.apache.org/mod_mbox/maven-dev/202101.mbox/%3CCAGjJkv0%2BAa1ffGYnxWVYkz8_QWt7KsAYcJ0CsEe%2BMGy6h6FQ6w%40mail.gmail.com%3E)][[2](https://mail-archives.apache.org/mod_mbox/maven-dev/202101.mbox/%3CCAGjJkv2trLUX6W0UQwmsizPUNdZ6GXS9FB3ApP7w%2B7MhbBXT-g%40mail.gmail.com%3E)] this PR removes depreciation on `org.apache.maven.plugin.logging.Log` and implementations.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [X] You have run the [Core IT][core-its]
Two unrelatd ITs tests are failing locally
````
[ERROR] Errors:
[ERROR] MavenITmng5669ReadPomsOnce>AbstractMavenIntegrationTestCase.runTest:255->testWithBuildConsumer:119 » Verification
[ERROR] MavenITmng5669ReadPomsOnce>AbstractMavenIntegrationTestCase.runTest:255->testWithoutBuildConsumer:65 » Verification
````
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #437:
URL: https://github.com/apache/maven/pull/437#issuecomment-767455778
Hi @McFoggy , isnt only Log which shouldn't be deprecated and the implementation can stay deprecated if we want to forward them to slf4j internally - I suspect we will want to do it in DefaultLog but for now it uses plexus which is not desired anymore from what I understood?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] McFoggy commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
Posted by GitBox <gi...@apache.org>.
McFoggy commented on pull request #437:
URL: https://github.com/apache/maven/pull/437#issuecomment-767467591
Hi Romain,
>isn't only Log which shouldn't be deprecated
I hesitated on this. I can switch it back for the 2 implementations if it is more aligned with the long term goal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #437:
URL: https://github.com/apache/maven/pull/437#issuecomment-933016138
I consider it barely realistic to remove SLF4J API in Core and replace it with something else. All components will fail anyway, Wagon, SCM, Shared, etc. This is just too short sighted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slachiewicz commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #437:
URL: https://github.com/apache/maven/pull/437#issuecomment-767493277
One short notice - Plexus logger Log here, api and implementation is from Eclipse Plexus Sisu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #437:
URL: https://github.com/apache/maven/pull/437#issuecomment-767488286
@McFoggy not a big blocker for me since removing the deprecation on Log is the "big thing" there IMHO but think it is worth to have an implementation not deprecated (maybe default only?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slachiewicz commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #437:
URL: https://github.com/apache/maven/pull/437#issuecomment-767568731
Sorry, that should be comment to other PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] McFoggy commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
Posted by GitBox <gi...@apache.org>.
McFoggy commented on pull request #437:
URL: https://github.com/apache/maven/pull/437#issuecomment-767563490
>
>
> One short notice - Plexus logger Log here, api and implementation is from Eclipse Plexus Sisu
Sorry @slachiewicz I do not get your point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #437:
URL: https://github.com/apache/maven/pull/437#issuecomment-934773727
Proposal to supersede this https://github.com/apache/maven/pull/565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] McFoggy commented on pull request #437: [MNG-7082] - remove deprecation on org.apache.maven.plugin.logging.Log
Posted by GitBox <gi...@apache.org>.
McFoggy commented on pull request #437:
URL: https://github.com/apache/maven/pull/437#issuecomment-768091466
@rmannibucau finally I only removed depreciation on `org.apache.maven.plugin.logging.Log`, there was a consensus for this point let's stick to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org