You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/08/22 14:46:09 UTC

[GitHub] flink issue #2401: [FLINK-4443][rpc] Add support in RpcCompletenessTest for ...

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2401
  
    Thanks for your contribution @wenlong88. Your changes look good to me. I only had a comment concerning the `NativeMethod` annotation. I think that at the moment we could get along without it by considering all `RpcGateway` methods implicitly native. That would simplify decrease the complexity a little bit because we can get rid of/not introduce another annotation. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---