[GitHub] [nifi] jtstorck commented on a change in pull request #3483: NIFI-6275 ListHDFS now ignores scheme and authority when uses "Full P…

[GitBox <gi...@apache.org>]

jtstorck commented on a change in pull request #3483: NIFI-6275 ListHDFS now ignores scheme and authority when uses "Full P…
URL: https://github.com/apache/nifi/pull/3483#discussion_r329784773
 
 

 ##########
 File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java
 ##########
 @@ -527,7 +527,7 @@ private PathFilter createPathFilter(final ProcessContext context) {
         return path -> {
             final boolean accepted;
             if (FILTER_FULL_PATH_VALUE.getValue().equals(filterMode)) {
-                accepted = filePattern.matcher(path.toString()).matches();
+                accepted = filePattern.matcher(Path.getPathWithoutSchemeAndAuthority(path).toString()).matches();
 
 Review comment:
   @ijokarumawak I'm in favor of option 1.  It's a path-segment search, not a full URI search, and I initially implemented it incorrectly.  Users would most likely report issues regarding the need to include the scheme and authority in the first place.  I understand it could cause issues in existing flows for those that do include the scheme and authority if we adjust the default behavior, but I would rather the default functionality of the full-path filter mode be applied only to the path.  The migration documentation is the appropriate place to document a change like this.  Do you agree that adding another mode or an option that pertains to only the existing full path filter mode would unnecessarily complicate the configuration of the processor?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services