You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/07 01:49:49 UTC

[GitHub] [flink] HuangXingBo opened a new pull request, #20190: [FLINK-28426][python] Supports m1 wheel package in PyFlink

HuangXingBo opened a new pull request, #20190:
URL: https://github.com/apache/flink/pull/20190

   ## What is the purpose of the change
   
   *This pull request will support m1 wheel package in PyFlink*
   
   
   ## Brief change log
   
     - *Supports m1 wheel package in PyFlink*
   
   ## Verifying this change
   
   
   This change added tests and can be verified as follows:
   
     - *Manual tests in Private Azure Pipeline*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bgeng777 commented on a diff in pull request #20190: [FLINK-28426][python] Supports m1 wheel package in PyFlink

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on code in PR #20190:
URL: https://github.com/apache/flink/pull/20190#discussion_r916537808


##########
tools/azure-pipelines/build-python-wheels.yml:
##########
@@ -32,3 +26,21 @@ jobs:
         inputs:
           artifactName: 'wheel_$(Agent.OS)_$(Agent.JobName)'
           targetPath: 'flink-python/dist'
+
+  - job: build_wheels_on_macos
+    pool:
+      vmImage: 'macOS-latest'
+    steps:
+      - task: UsePythonVersion@0
+        inputs:
+          versionSpec: '3.9'

Review Comment:
   My previous understanding is wrong as it is used to specify the py version of cibuildwheel's env.
   Now, the PR LGTM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Vancior commented on a diff in pull request #20190: [FLINK-28426][python] Supports m1 wheel package in PyFlink

Posted by GitBox <gi...@apache.org>.
Vancior commented on code in PR #20190:
URL: https://github.com/apache/flink/pull/20190#discussion_r916446550


##########
tools/azure-pipelines/build-python-wheels.yml:
##########
@@ -14,15 +14,9 @@
 # limitations under the License.
 
 jobs:
-  - job: build_wheels
-    strategy:
-      matrix:
-        linux:
-          vm-label: 'ubuntu-20.04'
-        mac:
-          vm-label: 'macOS-10.15'
+  - job: build_wheels_on_Linux
     pool:
-      vmImage: $(vm-label)
+      vmImage: 'ubuntu-20.04'

Review Comment:
   might be `'ubuntu-latest'`



##########
flink-python/pyproject.toml:
##########
@@ -0,0 +1,32 @@
+################################################################################
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+[build-system]
+# Minimum requirements for the build system to execute.
+requires = [
+    "packaging==20.5; platform_machine=='arm64'",  # macos M1

Review Comment:
   packaging requirement might be relaxed to `>=20.5`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo commented on pull request #20190: [FLINK-28426][python] Supports m1 wheel package in PyFlink

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on PR #20190:
URL: https://github.com/apache/flink/pull/20190#issuecomment-1176952374

   https://dev.azure.com/hxbks2ks/FLINK-TEST/_build/results?buildId=1895&view=results Manual Test in my private Azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20190: [FLINK-28426][python] Supports m1 wheel package in PyFlink

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20190:
URL: https://github.com/apache/flink/pull/20190#issuecomment-1176955030

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4d0a083fb3bde009a06ffd5623f038ebd1985f9b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4d0a083fb3bde009a06ffd5623f038ebd1985f9b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4d0a083fb3bde009a06ffd5623f038ebd1985f9b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] bgeng777 commented on a diff in pull request #20190: [FLINK-28426][python] Supports m1 wheel package in PyFlink

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on code in PR #20190:
URL: https://github.com/apache/flink/pull/20190#discussion_r916521797


##########
tools/azure-pipelines/build-python-wheels.yml:
##########
@@ -32,3 +26,21 @@ jobs:
         inputs:
           artifactName: 'wheel_$(Agent.OS)_$(Agent.JobName)'
           targetPath: 'flink-python/dist'
+
+  - job: build_wheels_on_macos
+    pool:
+      vmImage: 'macOS-latest'
+    steps:
+      - task: UsePythonVersion@0
+        inputs:
+          versionSpec: '3.9'

Review Comment:
   Does it mean that since 1.16, users who want to run pyflink in m1 mac should at least install python3.9? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo commented on a diff in pull request #20190: [FLINK-28426][python] Supports m1 wheel package in PyFlink

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on code in PR #20190:
URL: https://github.com/apache/flink/pull/20190#discussion_r916496812


##########
tools/azure-pipelines/build-python-wheels.yml:
##########
@@ -14,15 +14,9 @@
 # limitations under the License.
 
 jobs:
-  - job: build_wheels
-    strategy:
-      matrix:
-        linux:
-          vm-label: 'ubuntu-20.04'
-        mac:
-          vm-label: 'macOS-10.15'
+  - job: build_wheels_on_Linux
     pool:
-      vmImage: $(vm-label)
+      vmImage: 'ubuntu-20.04'

Review Comment:
   Not a fixed version, it may bring us potential problems in the future. 



##########
flink-python/pyproject.toml:
##########
@@ -0,0 +1,32 @@
+################################################################################
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+[build-system]
+# Minimum requirements for the build system to execute.
+requires = [
+    "packaging==20.5; platform_machine=='arm64'",  # macos M1

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo closed pull request #20190: [FLINK-28426][python] Supports m1 wheel package in PyFlink

Posted by GitBox <gi...@apache.org>.
HuangXingBo closed pull request #20190: [FLINK-28426][python] Supports m1 wheel package in PyFlink
URL: https://github.com/apache/flink/pull/20190


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org