You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/04/01 00:35:17 UTC
Review Request 58130: SENTRY-1684 FullUpdateInitializer has a race
condition in handling results list
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58130/
-----------------------------------------------------------
Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, and Vadim Spector.
Bugs: SENTRY-1684
https://issues.apache.org/jira/browse/SENTRY-1684
Repository: sentry
Description
-------
SENTRY-1684 FullUpdateInitializer has a race condition in handling results list
Diffs
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java 146cea2b9467ce82b69bbf402933b1aa350bcd46
Diff: https://reviews.apache.org/r/58130/diff/1/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 58130: SENTRY-1684 FullUpdateInitializer has a race
condition in handling results list
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On April 6, 2017, 2:03 p.m., Na Li wrote:
> > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java
> > Line 311 (original), 314 (patched)
> > <https://reviews.apache.org/r/58130/diff/1/?file=1682896#file1682896line321>
> >
> > Under what condition will the taskCounter be negative? Should we throw exception if it is negative?
It would never be negative. It starts non-negative and will go to zero. The change expresses the desied condition more clearly - we are waiting until the value becomes zero.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58130/#review171041
-----------------------------------------------------------
On April 1, 2017, 12:35 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58130/
> -----------------------------------------------------------
>
> (Updated April 1, 2017, 12:35 a.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, and Vadim Spector.
>
>
> Bugs: SENTRY-1684
> https://issues.apache.org/jira/browse/SENTRY-1684
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1684 FullUpdateInitializer has a race condition in handling results list
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java 146cea2b9467ce82b69bbf402933b1aa350bcd46
>
>
> Diff: https://reviews.apache.org/r/58130/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 58130: SENTRY-1684 FullUpdateInitializer has a race
condition in handling results list
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58130/#review171041
-----------------------------------------------------------
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java
Line 311 (original), 314 (patched)
<https://reviews.apache.org/r/58130/#comment243876>
Under what condition will the taskCounter be negative? Should we throw exception if it is negative?
- Na Li
On April 1, 2017, 12:35 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58130/
> -----------------------------------------------------------
>
> (Updated April 1, 2017, 12:35 a.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, and Vadim Spector.
>
>
> Bugs: SENTRY-1684
> https://issues.apache.org/jira/browse/SENTRY-1684
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1684 FullUpdateInitializer has a race condition in handling results list
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java 146cea2b9467ce82b69bbf402933b1aa350bcd46
>
>
> Diff: https://reviews.apache.org/r/58130/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 58130: SENTRY-1684 FullUpdateInitializer has a race
condition in handling results list
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58130/#review171235
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On April 1, 2017, 12:35 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58130/
> -----------------------------------------------------------
>
> (Updated April 1, 2017, 12:35 a.m.)
>
>
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, and Vadim Spector.
>
>
> Bugs: SENTRY-1684
> https://issues.apache.org/jira/browse/SENTRY-1684
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1684 FullUpdateInitializer has a race condition in handling results list
>
>
> Diffs
> -----
>
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java 146cea2b9467ce82b69bbf402933b1aa350bcd46
>
>
> Diff: https://reviews.apache.org/r/58130/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>