You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/11 09:46:09 UTC

[GitHub] [apisix] griffenliu opened a new pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667

griffenliu opened a new pull request #1782:
URL: https://github.com/apache/apisix/pull/1782


   
   ### Issues resolved
   
   Fix #1667 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1782:
URL: https://github.com/apache/apisix/pull/1782#issuecomment-743597327


   new PR is on the way, so I think we can close this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis closed pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667

Posted by GitBox <gi...@apache.org>.
membphis closed pull request #1782:
URL: https://github.com/apache/apisix/pull/1782


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1782:
URL: https://github.com/apache/apisix/pull/1782#issuecomment-743091674


   @griffenliu I think your way is better. so I reopened your PR, would like to confirm this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] griffenliu closed pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667

Posted by GitBox <gi...@apache.org>.
griffenliu closed pull request #1782:
URL: https://github.com/apache/incubator-apisix/pull/1782


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1782:
URL: https://github.com/apache/incubator-apisix/pull/1782#issuecomment-652140960


   @griffenliu please take a look at this comment
   
   https://github.com/apache/incubator-apisix/issues/1667#issuecomment-652140810


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1782:
URL: https://github.com/apache/incubator-apisix/pull/1782#discussion_r448073576



##########
File path: apisix/plugin.lua
##########
@@ -237,7 +237,7 @@ function _M.filter(user_route, plugins)
     local user_plugin_conf = user_route.value.plugins
     if user_plugin_conf == nil or
        core.table.nkeys(user_plugin_conf) == 0 then
-        if local_conf and local_conf.apisix.enable_debug then
+        if local_conf and local_conf.apisix.enable_debug and not ngx.headers_sent then

Review comment:
       https://github.com/apache/incubator-apisix/issues/1667#issuecomment-652140810




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org