[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1224: [CELEBORN-291] optimize shuffleclientimpl creating client and pushdata for mappartition

["zhongqiangczq (via GitHub)" <gi...@apache.org>]

zhongqiangczq commented on code in PR #1224:
URL: https://github.com/apache/incubator-celeborn/pull/1224#discussion_r1106816829


##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -131,7 +131,7 @@ private static class ReduceFileGroups {
   // key: shuffleId
   private final Map<Integer, ReduceFileGroups> reduceFileGroupsMap = new ConcurrentHashMap<>();
 
-  private TransportClient currentClient;
+  private ConcurrentHashMap<String, TransportClient> currentClient = new ConcurrentHashMap<>();

Review Comment:
   yes, it should be cleauped in cleaup function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org