You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "amanraj2520 (via GitHub)" <gi...@apache.org> on 2023/03/25 06:19:44 UTC
[GitHub] [hive] amanraj2520 opened a new pull request, #4152: Disabled sysdb.q
amanraj2520 opened a new pull request, #4152:
URL: https://github.com/apache/hive/pull/4152
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Disabled sysdb.q test. The test is failing because of diff in BASIC_COLUMN_STATS json string.
Client Execution succeeded but contained differences (error code = 1) after executing sysdb.q
3803,3807c3803,3807
< COLUMN_STATS_ACCURATE org.apache.derby.impl.jdbc.EmbedClob@125b285b
< COLUMN_STATS_ACCURATE org.apache.derby.impl.jdbc.EmbedClob@471246f3
< COLUMN_STATS_ACCURATE org.apache.derby.impl.jdbc.EmbedClob@57c013
< COLUMN_STATS_ACCURATE org.apache.derby.impl.jdbc.EmbedClob@59f1d7ac
< COLUMN_STATS_ACCURATE org.apache.derby.impl.jdbc.EmbedClob@717777a0
—
> COLUMN_STATS_ACCURATE {"BASIC_STATS":"true","COLUMN_STATS":{"c_boolean":"true","c_float":"true","c_int":"true","key":"true","value":"true"}}
> COLUMN_STATS_ACCURATE {"BASIC_STATS":"true","COLUMN_STATS":{"c_boolean":"true","c_float":"true","c_int":"true","key":"true","value":"true"}}
> COLUMN_STATS_ACCURATE {"BASIC_STATS":"true","COLUMN_STATS":{"key":"true","value":"true"}}
> COLUMN_STATS_ACCURATE {"BASIC_STATS":"true","COLUMN_STATS":{"key":"true","value":"true"}}
> COLUMN_STATS_ACCURATE {"BASIC_STATS":"true","COLUMN_STATS":
{"key":"true","value":"true"}
}
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
There is no issue in the test. The current code prints the COL_STATS as an Object instead of a json string. Not sure why is this case. Tried a lot of ways but seems like this is not fixable at the moment. So, disabling it for now. Note that, in Hive 3.1.3 release this test was disabled so there should not be any issue in disabling it here.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
NO
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Jenkins pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #4152: HIVE-27174 : Disabled sysdb.q
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #4152:
URL: https://github.com/apache/hive/pull/4152#issuecomment-1483785911
Did you try to understand why this works on master v/s branch-3? I spent some time on this and I was able to narrow this failure down to HIVE-21741 using git bisect. Trying to understand why this works on master v/s branch-3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4152: HIVE-27174 : Disabled sysdb.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4152:
URL: https://github.com/apache/hive/pull/4152#issuecomment-1487293175
Sure @vihangk1 . Will close the revert test. One thing is we will still need https://github.com/apache/hive/pull/4157. This fixes a different issue in sysdb.q. If you go to the original sysdb.q test failure, you will observe these extra differences on top of BASIC_STATS difference. We need to backport this ticket for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4152: Disabled sysdb.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4152:
URL: https://github.com/apache/hive/pull/4152#issuecomment-1483739974
@vihangk1 I have tried a lot of ways in my local but this test does not seem fixable from my side. If possible you can give it a try otherwise we can disable this test in branch-3. Note that this test was already disabled in Hive-3.1.3 release branch. Also there is no problem in the test, it is just the diff between printing the object and the actual json string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4152: HIVE-27174 : Disabled sysdb.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4152:
URL: https://github.com/apache/hive/pull/4152#issuecomment-1487297723
https://issues.apache.org/jira/browse/HIVE-27057 Created this ticket to followup on this test fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on pull request #4152: HIVE-27174 : Disabled sysdb.q
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4152:
URL: https://github.com/apache/hive/pull/4152#issuecomment-1484590603
@vihangk1 I see that in this #HIVE-21741, there were some changes related to INDEX_PARAMS from varchar to Clob. My hunch is that somewhere because of that this issue comes. Any luck from your side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #4152: HIVE-27174 : Disabled sysdb.q
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #4152:
URL: https://github.com/apache/hive/pull/4152#issuecomment-1487218944
Hi @amanraj2520 Sorry for the delay in response, I was out of town. I tried to debug it and from what I see, the class name is being returned by the jdbc `ResultSet` itself when we query the `PARAM_VALUE` using the JDBC Storage Handler. I don't see why the master branch gives the string value and branch-3 gives the class name.
I think instead of reverting those patches, we should disable this test for now and follow up in a separate ticket to determine if this should block 3.2. or not. I am okay merging this PR instead of reverting the offending commits in this case because those are important fixes to have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 merged pull request #4152: HIVE-27174 : Disabled sysdb.q
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 merged PR #4152:
URL: https://github.com/apache/hive/pull/4152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #4152: HIVE-27174 : Disabled sysdb.q
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #4152:
URL: https://github.com/apache/hive/pull/4152#issuecomment-1487857546
Thanks @amanraj2520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org