You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/15 22:49:15 UTC
[GitHub] [airflow] whatnick opened a new pull request #13094: #13081 add note block to 2.x migration docs
whatnick opened a new pull request #13094:
URL: https://github.com/apache/airflow/pull/13094
closes: #13081
Added 2.x upgrading note in the OAuth section. Affect 1.10.14 bridge release as well. Auto-upgrade in our environment to 1.10.14 caused a minor OAuth2 login downtime. We will create a note in the official helm-chart repo as well for the *secret_key* to be highlighted similar to the *fernet_key*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] whatnick commented on pull request #13094: #13081 add note block to 2.x migration docs
Posted by GitBox <gi...@apache.org>.
whatnick commented on pull request #13094:
URL: https://github.com/apache/airflow/pull/13094#issuecomment-748671374
> The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
Is this ready to merge should I perform the rebase activity or wait a bit more for a final approval from @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pindge commented on a change in pull request #13094: #13081 add note block to 2.x migration docs
Posted by GitBox <gi...@apache.org>.
pindge commented on a change in pull request #13094:
URL: https://github.com/apache/airflow/pull/13094#discussion_r543744684
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -352,7 +359,7 @@ respect to the Kubernetes Executor. This is called out below for users of the Ku
**Upgrade KubernetesExecutor settings**
-*The KubernetesExecutor Will No Longer Read from the airflow.cfg for Base Pod Configurations.*
+*The KubernetesExecutor Will t` Longer Read from the airflow.cfg for Base Pod Configurations.*
Review comment:
typo!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13094: #13081 add note block to 2.x migration docs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13094:
URL: https://github.com/apache/airflow/pull/13094#issuecomment-749251848
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] whatnick commented on a change in pull request #13094: #13081 add note block to 2.x migration docs
Posted by GitBox <gi...@apache.org>.
whatnick commented on a change in pull request #13094:
URL: https://github.com/apache/airflow/pull/13094#discussion_r543753923
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -352,7 +359,7 @@ respect to the Kubernetes Executor. This is called out below for users of the Ku
**Upgrade KubernetesExecutor settings**
-*The KubernetesExecutor Will No Longer Read from the airflow.cfg for Base Pod Configurations.*
+*The KubernetesExecutor Will t` Longer Read from the airflow.cfg for Base Pod Configurations.*
Review comment:
Thanks fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13094: #13081 add note block to 2.x migration docs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13094:
URL: https://github.com/apache/airflow/pull/13094#issuecomment-745616079
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13094: #13081 add note block to 2.x migration docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13094:
URL: https://github.com/apache/airflow/pull/13094#issuecomment-746914707
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13094: #13081 add note block to 2.x migration docs
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13094:
URL: https://github.com/apache/airflow/pull/13094#discussion_r544719346
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -325,6 +325,14 @@ the only supported UI.
**Breaking Change in OAuth**
+.. note::
+
+ When multiple replicas of the airflow-web are running they
Review comment:
```suggestion
When multiple replicas of the airflow webserver are running they
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #13094: #13081 add note block to 2.x migration docs
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #13094:
URL: https://github.com/apache/airflow/pull/13094#discussion_r544191088
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -325,6 +325,13 @@ the only supported UI.
**Breaking Change in OAuth**
+.. note::
+
+ When multiple replicas of the airflow-web pods are running in Kubernetes they
+ need to share the same *secret_key* to access the same user session across pods. Inject
+ this via the environment and rotate it regularly like the fernet_key to ensure security.
+ The 1.10.14 bridge-release has this feature.
Review comment:
This is too specific:
- Don't mention pods; this applies in or out of kubernetes usage.
- Specifying via environment is not required -- any config mechanism is valid.
- Please remove reference to rotating keys
- _All_ versions had this feature, it's just the previously they all had an insecure default so it wasn't noticed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13094: #13081 add note block to 2.x migration docs
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13094:
URL: https://github.com/apache/airflow/pull/13094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org