You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "victordott (via GitHub)" <gi...@apache.org> on 2023/02/01 10:12:02 UTC
[GitHub] [airflow] victordott opened a new pull request, #29285: Constrain Paramiko version to prevent auth SFTP issues
victordott opened a new pull request, #29285:
URL: https://github.com/apache/airflow/pull/29285
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This pr constraints the Paramiko version to prevent authentication errors in the Airflow SFTP sensor.
This fix relates to the following issue in Paramiko: https://github.com/paramiko/paramiko/issues/1839
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29285: Constrain Paramiko version to prevent auth SFTP issues
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29285:
URL: https://github.com/apache/airflow/pull/29285#issuecomment-1412937420
We do not change constraints in constraint branches. They are generated automatically from https://github.com/apache/airflow/blob/main/airflow/providers/ssh/provider.yaml - and if you want to limit the next release of providers, then you should be adding appropriate limits there.
But since you seem to be upper-binding it, you need to explain why - why 2.8.1, what should be remove to fix it and why this is is a problem from everyone affected.
if this is not a critical problem affecting a lot of users (it does not seem so) and not affecting a lot of people, there is no reason why such big "downgrade" should be needed. First of all - why 2.8.1 rather than 2.9.0 for example or 2.11.0 for example ? By looking here https://pypi.org/project/paramiko/#history - there were 15 releases since 2.8.1 so there is no way we would accept such downgrade without having a really good reason for it.
If you think you should do such a change, you should make a PR changing provider.yaml and justify it explaining the actual "best" limit you can do with explanation on when the limit should be removed (see https://github.com/apache/airflow#approach-to-dependencies-of-airflow)
> Whenever we upper-bound such a dependency, we should always comment why we are doing it - i.e. we should have a good reason why dependency is upper-bound. And we should also mention what is the condition to remove the binding.
And BTW. By the nature of constraints - if your particular problem is exhibited even in version from the constraints, then you are free to downgrade this particular dependency. You can even install airflow with constraints first and follow it with `pip install dependency==X.Y.Z. This is perfectly valid and correct use case - especially in the case where the problem you experience is specific for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #29285: Constrain Paramiko version to prevent auth SFTP issues
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #29285: Constrain Paramiko version to prevent auth SFTP issues
URL: https://github.com/apache/airflow/pull/29285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29285: Constrain Paramiko version to prevent auth SFTP issues
Posted by boring-cyborg.
boring-cyborg[bot] commented on PR #29285:
URL: https://github.com/apache/airflow/pull/29285#issuecomment-1411804635
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org