[GitHub] [activemq] mattrpav commented on a diff in pull request #908: [AMQ-9107] Remove consumers more efficiently in ManagedRegionBroker

[GitBox <gi...@apache.org>]

mattrpav commented on code in PR #908:
URL: https://github.com/apache/activemq/pull/908#discussion_r994672165


##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ManagedRegionBroker.java:
##########
@@ -215,6 +217,7 @@ public ObjectName registerSubscription(ConnectionContext context, Subscription s
                 registerSubscription(objectName, sub.getConsumerInfo(), key, view);
             }
             subscriptionMap.put(sub, objectName);
+            consumerSubscriptionMap.put(sub.getConsumerInfo(), sub);

Review Comment:
   Was this tested with an offline durable topic subscription? I'm thinking this will return null here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org