You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/04/03 14:28:49 UTC
Review Request 58149: Remove hardcoding of /usr/hdp by AMBARI-20543
needed for IBM Power
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58149/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-20664
https://issues.apache.org/jira/browse/AMBARI-20664
Repository: ambari
Description
-------
<https://issues.apache.org/jira/browse/AMBARI-20543> hardcoded /usr/hdp inside
common-services for several services. It should instead use `stack_root`,
which was one of the comments during the code review.
An Ambari Upgrade from 2.5.0 to 2.5.1 should fix those properties via the
Upgrade Catalog.
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml 4b4008d
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml d883ec2
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 5a028bd
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml e2ef1b1
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py a4de8fa
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py cab9102
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml bf7d750
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml 99d38e2
ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml 99d38e2
ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml ee7478b
Diff: https://reviews.apache.org/r/58149/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 58149: Remove hardcoding of /usr/hdp by
AMBARI-20543 needed for IBM Power
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58149/#review170876
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On \u041a\u0432\u0456\u0442\u0435\u043d\u044c 3, 2017, 2:28 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58149/
> -----------------------------------------------------------
>
> (Updated \u041a\u0432\u0456\u0442\u0435\u043d\u044c 3, 2017, 2:28 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20664
> https://issues.apache.org/jira/browse/AMBARI-20664
>
>
> Repository: ambari
>
>
> Description
> -------
>
> <https://issues.apache.org/jira/browse/AMBARI-20543> hardcoded /usr/hdp inside
> common-services for several services. It should instead use `stack_root`,
> which was one of the comments during the code review.
>
> An Ambari Upgrade from 2.5.0 to 2.5.1 should fix those properties via the
> Upgrade Catalog.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml 4b4008d
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml d883ec2
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 5a028bd
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml e2ef1b1
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py a4de8fa
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py cab9102
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml bf7d750
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml 99d38e2
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml 99d38e2
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml ee7478b
>
>
> Diff: https://reviews.apache.org/r/58149/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58149: Remove hardcoding of /usr/hdp by
AMBARI-20543 needed for IBM Power
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58149/#review170936
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 3, 2017, 2:28 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58149/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 2:28 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20664
> https://issues.apache.org/jira/browse/AMBARI-20664
>
>
> Repository: ambari
>
>
> Description
> -------
>
> <https://issues.apache.org/jira/browse/AMBARI-20543> hardcoded /usr/hdp inside
> common-services for several services. It should instead use `stack_root`,
> which was one of the comments during the code review.
>
> An Ambari Upgrade from 2.5.0 to 2.5.1 should fix those properties via the
> Upgrade Catalog.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml 4b4008d
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml d883ec2
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 5a028bd
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml e2ef1b1
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py a4de8fa
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py cab9102
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml bf7d750
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml 99d38e2
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml 99d38e2
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml ee7478b
>
>
> Diff: https://reviews.apache.org/r/58149/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>