[jira] [Commented] (AIRFLOW-6530) Allow for custom Statsd client

["Ash Berlin-Taylor (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012905#comment-17012905 ] 

Ash Berlin-Taylor commented on AIRFLOW-6530:
--------------------------------------------

Yes, something like that makes sense. You can use the import_string from airflow/utils/module_loading and then set the default to be 'statsd.StatsClient'

> Allow for custom Statsd client
> ------------------------------
>
>                 Key: AIRFLOW-6530
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6530
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: scheduler, webserver
>    Affects Versions: 1.10.7
>            Reporter: Usman Arshad
>            Assignee: Usman Arshad
>            Priority: Major
>              Labels: features
>             Fix For: 1.10.8
>
>
> We are currently using Airflow at Skyscanner and we have a custom implementation of Statsd which offers features which wires in nicely into our metrics platform/tooling.
> I'm quite sure that other companies who are using Airflow would also find great benefit in being able to utilise their own custom Statsd client, therefore i am proposing this addition.
>  
> The proposed solution looks something along the lines of changing this:
> {code:java}
> statsd = StatsClient(
>     host=conf.get('scheduler', 'statsd_host'),
>     port=conf.getint('scheduler', 'statsd_port'),
>     prefix=conf.get('scheduler', 'statsd_prefix'))
> {code}
>  Into
> {code:java}
> statsd = conf.get('STATSD_CLIENT') or StatsClient(
>     host=conf.get('scheduler', 'statsd_host'),
>     port=conf.getint('scheduler', 'statsd_port'),
>     prefix=conf.get('scheduler', 'statsd_prefix'))
> {code}
> Note: Psuedocode, not actual code
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)