You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/18 14:33:32 UTC

[GitHub] [flink] twalthr commented on a change in pull request #14681: [FLINK-21009] Can not disable certain options in Elasticsearch 7 connector

twalthr commented on a change in pull request #14681:
URL: https://github.com/apache/flink/pull/14681#discussion_r559587204



##########
File path: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
##########
@@ -402,6 +405,18 @@ protected BulkProcessor buildBulkProcessor(BulkProcessor.Listener listener) {
         return bulkProcessorBuilder.build();
     }
 
+    private void configureBulkSize(BulkProcessor.Builder bulkProcessorBuilder) {

Review comment:
       nit: I would vote for code consistency with `bulkProcessorFlushIntervalMillis` here by removing this method?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org