[GitHub] [flink] lirui-apache commented on a diff in pull request #20376: [FLINK-27384] solve the problem that the latest data cannot be read under the creat…

[GitBox <gi...@apache.org>]

lirui-apache commented on code in PR #20376:
URL: https://github.com/apache/flink/pull/20376#discussion_r932083340


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HivePartitionFetcherContextBase.java:
##########
@@ -137,21 +133,17 @@ public List<ComparablePartitionValue> getComparablePartitionValueList() throws E
                 }
                 break;
             case CREATE_TIME:
+                Map<List<String>, Long> partValuesToCreateTime = new HashMap<>();
                 partitionNames =
                         metaStoreClient.listPartitionNames(
                                 tablePath.getDatabaseName(),
                                 tablePath.getObjectName(),
                                 Short.MAX_VALUE);
-                List<String> newNames =
-                        partitionNames.stream()
-                                .filter(
-                                        n ->
-                                                !partValuesToCreateTime.containsKey(
-                                                        extractPartitionValues(n)))
-                                .collect(Collectors.toList());
                 List<Partition> newPartitions =

Review Comment:
   Since we're not trying to get only "new" partitions, please rename this variable to reflect that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org