You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@stratos.apache.org by Gayan Gunarathne <ga...@wso2.com> on 2014/09/11 09:28:06 UTC

MQTT client library for Stratos messaging component.

Hi All,

Based on the discussion[1] and our initial research, we are going to use
the following client library for the Stratos MQTT based message component.

http://www.eclipse.org/paho/

We have done initial research[2] of the functionality of that library with
both java[3] and python[4].

Please feel free to share if you have any thoughts on this.


[1] Messaging protocol with Stratos python cartridge agent
[2] https://github.com/gayangunarathne/MQTT-Pub-Sub
[3] https://repo.eclipse.org/content/repositories/paho-releases/
[4] http://www.eclipse.org/paho/clients/python/

Thanks,
Gayan



-- 
Best Regards,

Gayan Gunarathne
Technical Lead
WSO2 Inc. (http://wso2.com)
email  : gayang@wso2.com  | mobile : +94 766819985

Re: MQTT client library for Stratos messaging component.

Posted by Nirmal Fernando <ni...@gmail.com>.

I'll remove it Gayan. Thanks.

On Thu, Sep 25, 2014 at 9:52 AM, Gayan Gunarathne <ga...@wso2.com> wrote:

> Yeah Nirmal, Seems it mistakenly added.I think we can remove this.
>
> Thanks,
> Gayan
>
> On Thu, Sep 25, 2014 at 9:26 AM, Nirmal Fernando <ni...@gmail.com>
> wrote:
>
>> Hi Gayan,
>>
>> I think we have mistakenly added a git sub module
>> https://github.com/apache/stratos/tree/docker-integration/tools/cartridge_agent
>> ? Could you please check?
>>
>> On Wed, Sep 24, 2014 at 4:22 PM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>> This is resolved.
>>>
>>> Pull request :  https://github.com/apache/stratos/pull/58
>>> Commit ID : d789aa66ca55b9fda0662865fce818c390a4f043
>>>
>>> I also updated the JIRA(STRATOS-820
>>> <https://issues.apache.org/jira/browse/STRATOS-820>)
>>>
>>> Thanks,
>>> Gayan
>>>
>>> On Wed, Sep 24, 2014 at 10:50 AM, Nirmal Fernando <
>>> nirmal070125@gmail.com> wrote:
>>>
>>>> Logged a jira https://issues.apache.org/jira/browse/STRATOS-820
>>>>
>>>> On Wed, Sep 24, 2014 at 10:28 AM, Nirmal Fernando <
>>>> nirmal070125@gmail.com> wrote:
>>>>
>>>>> Hi Gayan,
>>>>>
>>>>> With this PR, I am seen following error at Stratos back-end. I am
>>>>> running locally built stratos with an activemq. What am I missing?
>>>>>
>>>>> [2014-09-24 10:23:56,924]  INFO
>>>>> {org.apache.stratos.manager.publisher.InstanceNotificationPublisher} -
>>>>> Publishing Instance Cleanup Event: [cluster] test2.php.domain
>>>>>
>>>>> [2014-09-24 10:24:21,031] ERROR
>>>>> {org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Error while
>>>>> publishing to the topic: tenant/#
>>>>>
>>>>> Client is connected (32100)
>>>>>
>>>>> at
>>>>> org.eclipse.paho.client.mqttv3.internal.ExceptionHelper.createMqttException(ExceptionHelper.java:27)
>>>>>
>>>>> at
>>>>> org.eclipse.paho.client.mqttv3.MqttAsyncClient.connect(MqttAsyncClient.java:452)
>>>>>
>>>>> at
>>>>> org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:236)
>>>>>
>>>>> at
>>>>> org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:229)
>>>>>
>>>>> at
>>>>> org.apache.stratos.messaging.broker.publish.TopicPublisher.publish(TopicPublisher.java:82)
>>>>>
>>>>> at
>>>>> org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:51)
>>>>>
>>>>> at
>>>>> org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:45)
>>>>>
>>>>> at
>>>>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$TenantSubscribedEventPublisher.run(CartridgeSubscriptionUtils.java:174)
>>>>>
>>>>> at
>>>>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$1.execute(CartridgeSubscriptionUtils.java:191)
>>>>>
>>>>> at
>>>>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils.publishTenantSubscribedEvent(CartridgeSubscriptionUtils.java:195)
>>>>>
>>>>> at
>>>>> org.apache.stratos.manager.manager.CartridgeSubscriptionManager.registerCartridgeSubscription(CartridgeSubscriptionManager.java:357)
>>>>>
>>>>> at
>>>>> org.apache.stratos.manager.manager.CartridgeSubscriptionManager.subscribeToCartridgeWithProperties(CartridgeSubscriptionManager.java:150)
>>>>>
>>>>> at
>>>>> org.apache.stratos.rest.endpoint.services.ServiceUtils.subscribe(ServiceUtils.java:991)
>>>>>
>>>>> at
>>>>> org.apache.stratos.rest.endpoint.services.StratosAdmin.subscribe(StratosAdmin.java:401)
>>>>>
>>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>>>>
>>>>> at
>>>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>>>>
>>>>> at
>>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>>>>
>>>>> at java.lang.reflect.Method.invoke(Method.java:597)
>>>>>
>>>>> at
>>>>> org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
>>>>>
>>>>> at
>>>>> org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
>>>>>
>>>>> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:194)
>>>>>
>>>>> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:100)
>>>>>
>>>>> at
>>>>> org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:57)
>>>>>
>>>>> at
>>>>> org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:93)
>>>>>
>>>>> at
>>>>> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:271)
>>>>>
>>>>> at
>>>>> org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
>>>>>
>>>>> at
>>>>> org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:239)
>>>>>
>>>>> at
>>>>> org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:223)
>>>>>
>>>>> at
>>>>> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:203)
>>>>>
>>>>> at
>>>>> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:137)
>>>>>
>>>>> at
>>>>> org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:159)
>>>>>
>>>>> at
>>>>> org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:286)
>>>>>
>>>>> at
>>>>> org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:264)
>>>>>
>>>>> at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
>>>>>
>>>>> at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
>>>>>
>>>>> at
>>>>> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
>>>>>
>>>>> at
>>>>> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
>>>>>
>>>>> at
>>>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
>>>>>
>>>>> at
>>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
>>>>>
>>>>> at
>>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
>>>>>
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.CompositeValve.continueInvocation(CompositeValve.java:178)
>>>>>
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.CarbonTomcatValve$1.invoke(CarbonTomcatValve.java:47)
>>>>>
>>>>> at
>>>>> org.wso2.carbon.webapp.mgt.TenantLazyLoaderValve.invoke(TenantLazyLoaderValve.java:56)
>>>>>
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.TomcatValveContainer.invokeValves(TomcatValveContainer.java:47)
>>>>>
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.CompositeValve.invoke(CompositeValve.java:141)
>>>>>
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.CarbonStuckThreadDetectionValve.invoke(CarbonStuckThreadDetectionValve.java:156)
>>>>>
>>>>> at
>>>>> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:936)
>>>>>
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.CarbonContextCreatorValve.invoke(CarbonContextCreatorValve.java:52)
>>>>>
>>>>> at
>>>>> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
>>>>>
>>>>> at
>>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)
>>>>>
>>>>> at
>>>>> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004)
>>>>>
>>>>> at
>>>>> org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
>>>>>
>>>>> at
>>>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653)
>>>>>
>>>>> at
>>>>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
>>>>>
>>>>> at
>>>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
>>>>>
>>>>> at java.lang.Thread.run(Thread.java:695)
>>>>>
>>>>> [2014-09-24 10:24:21,051]  INFO
>>>>> {org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Will try to
>>>>> re-publish in 60 sec
>>>>>
>>>>> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com>
>>>>> wrote:
>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> I have changed the Stratos messaging model to support MQTT.
>>>>>>
>>>>>> Please find the pull request for this.
>>>>>>
>>>>>> https://github.com/apache/stratos/pull/47
>>>>>>
>>>>>>
>>>>>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>>>>>
>>>>>> Thanks,
>>>>>> Gayan
>>>>>>
>>>>>>
>>>>>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi All,
>>>>>>>
>>>>>>> Based on the discussion[1] and our initial research, we are going to
>>>>>>> use the following client library for the Stratos MQTT based message
>>>>>>> component.
>>>>>>>
>>>>>>> http://www.eclipse.org/paho/
>>>>>>>
>>>>>>> We have done initial research[2] of the functionality of that
>>>>>>> library with both java[3] and python[4].
>>>>>>>
>>>>>>> Please feel free to share if you have any thoughts on this.
>>>>>>>
>>>>>>>
>>>>>>> [1] Messaging protocol with Stratos python cartridge agent
>>>>>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>>>>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>>>>>> [4] http://www.eclipse.org/paho/clients/python/
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Gayan
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Best Regards,
>>>>>>>
>>>>>>> Gayan Gunarathne
>>>>>>> Technical Lead
>>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Best Regards,
>>>>>>
>>>>>> Gayan Gunarathne
>>>>>> Technical Lead
>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>> Nirmal
>>>>>
>>>>> Nirmal Fernando.
>>>>> PPMC Member & Committer of Apache Stratos,
>>>>> Senior Software Engineer, WSO2 Inc.
>>>>>
>>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>> Nirmal
>>>>
>>>> Nirmal Fernando.
>>>> PPMC Member & Committer of Apache Stratos,
>>>> Senior Software Engineer, WSO2 Inc.
>>>>
>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>>
>>> Gayan Gunarathne
>>> Technical Lead
>>> WSO2 Inc. (http://wso2.com)
>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>
>>>
>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
> Best Regards,
>
> Gayan Gunarathne
> Technical Lead
> WSO2 Inc. (http://wso2.com)
> email  : gayang@wso2.com  | mobile : +94 766819985
>
>



-- 
Best Regards,
Nirmal

Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.

Blog: http://nirmalfdo.blogspot.com/

Re: MQTT client library for Stratos messaging component.

Posted by Gayan Gunarathne <ga...@wso2.com>.

Yeah Nirmal, Seems it mistakenly added.I think we can remove this.

Thanks,
Gayan

On Thu, Sep 25, 2014 at 9:26 AM, Nirmal Fernando <ni...@gmail.com>
wrote:

> Hi Gayan,
>
> I think we have mistakenly added a git sub module
> https://github.com/apache/stratos/tree/docker-integration/tools/cartridge_agent
> ? Could you please check?
>
> On Wed, Sep 24, 2014 at 4:22 PM, Gayan Gunarathne <ga...@wso2.com> wrote:
>
>> This is resolved.
>>
>> Pull request :  https://github.com/apache/stratos/pull/58
>> Commit ID : d789aa66ca55b9fda0662865fce818c390a4f043
>>
>> I also updated the JIRA(STRATOS-820
>> <https://issues.apache.org/jira/browse/STRATOS-820>)
>>
>> Thanks,
>> Gayan
>>
>> On Wed, Sep 24, 2014 at 10:50 AM, Nirmal Fernando <nirmal070125@gmail.com
>> > wrote:
>>
>>> Logged a jira https://issues.apache.org/jira/browse/STRATOS-820
>>>
>>> On Wed, Sep 24, 2014 at 10:28 AM, Nirmal Fernando <
>>> nirmal070125@gmail.com> wrote:
>>>
>>>> Hi Gayan,
>>>>
>>>> With this PR, I am seen following error at Stratos back-end. I am
>>>> running locally built stratos with an activemq. What am I missing?
>>>>
>>>> [2014-09-24 10:23:56,924]  INFO
>>>> {org.apache.stratos.manager.publisher.InstanceNotificationPublisher} -
>>>> Publishing Instance Cleanup Event: [cluster] test2.php.domain
>>>>
>>>> [2014-09-24 10:24:21,031] ERROR
>>>> {org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Error while
>>>> publishing to the topic: tenant/#
>>>>
>>>> Client is connected (32100)
>>>>
>>>> at
>>>> org.eclipse.paho.client.mqttv3.internal.ExceptionHelper.createMqttException(ExceptionHelper.java:27)
>>>>
>>>> at
>>>> org.eclipse.paho.client.mqttv3.MqttAsyncClient.connect(MqttAsyncClient.java:452)
>>>>
>>>> at
>>>> org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:236)
>>>>
>>>> at
>>>> org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:229)
>>>>
>>>> at
>>>> org.apache.stratos.messaging.broker.publish.TopicPublisher.publish(TopicPublisher.java:82)
>>>>
>>>> at
>>>> org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:51)
>>>>
>>>> at
>>>> org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:45)
>>>>
>>>> at
>>>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$TenantSubscribedEventPublisher.run(CartridgeSubscriptionUtils.java:174)
>>>>
>>>> at
>>>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$1.execute(CartridgeSubscriptionUtils.java:191)
>>>>
>>>> at
>>>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils.publishTenantSubscribedEvent(CartridgeSubscriptionUtils.java:195)
>>>>
>>>> at
>>>> org.apache.stratos.manager.manager.CartridgeSubscriptionManager.registerCartridgeSubscription(CartridgeSubscriptionManager.java:357)
>>>>
>>>> at
>>>> org.apache.stratos.manager.manager.CartridgeSubscriptionManager.subscribeToCartridgeWithProperties(CartridgeSubscriptionManager.java:150)
>>>>
>>>> at
>>>> org.apache.stratos.rest.endpoint.services.ServiceUtils.subscribe(ServiceUtils.java:991)
>>>>
>>>> at
>>>> org.apache.stratos.rest.endpoint.services.StratosAdmin.subscribe(StratosAdmin.java:401)
>>>>
>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>>>
>>>> at
>>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>>>
>>>> at
>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>>>
>>>> at java.lang.reflect.Method.invoke(Method.java:597)
>>>>
>>>> at
>>>> org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
>>>>
>>>> at
>>>> org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
>>>>
>>>> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:194)
>>>>
>>>> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:100)
>>>>
>>>> at
>>>> org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:57)
>>>>
>>>> at
>>>> org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:93)
>>>>
>>>> at
>>>> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:271)
>>>>
>>>> at
>>>> org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
>>>>
>>>> at
>>>> org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:239)
>>>>
>>>> at
>>>> org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:223)
>>>>
>>>> at
>>>> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:203)
>>>>
>>>> at
>>>> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:137)
>>>>
>>>> at
>>>> org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:159)
>>>>
>>>> at
>>>> org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:286)
>>>>
>>>> at
>>>> org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:264)
>>>>
>>>> at
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
>>>>
>>>> at
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
>>>>
>>>> at
>>>> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
>>>>
>>>> at
>>>> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
>>>>
>>>> at
>>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
>>>>
>>>> at
>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
>>>>
>>>> at
>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
>>>>
>>>> at
>>>> org.wso2.carbon.tomcat.ext.valves.CompositeValve.continueInvocation(CompositeValve.java:178)
>>>>
>>>> at
>>>> org.wso2.carbon.tomcat.ext.valves.CarbonTomcatValve$1.invoke(CarbonTomcatValve.java:47)
>>>>
>>>> at
>>>> org.wso2.carbon.webapp.mgt.TenantLazyLoaderValve.invoke(TenantLazyLoaderValve.java:56)
>>>>
>>>> at
>>>> org.wso2.carbon.tomcat.ext.valves.TomcatValveContainer.invokeValves(TomcatValveContainer.java:47)
>>>>
>>>> at
>>>> org.wso2.carbon.tomcat.ext.valves.CompositeValve.invoke(CompositeValve.java:141)
>>>>
>>>> at
>>>> org.wso2.carbon.tomcat.ext.valves.CarbonStuckThreadDetectionValve.invoke(CarbonStuckThreadDetectionValve.java:156)
>>>>
>>>> at
>>>> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:936)
>>>>
>>>> at
>>>> org.wso2.carbon.tomcat.ext.valves.CarbonContextCreatorValve.invoke(CarbonContextCreatorValve.java:52)
>>>>
>>>> at
>>>> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
>>>>
>>>> at
>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)
>>>>
>>>> at
>>>> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004)
>>>>
>>>> at
>>>> org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
>>>>
>>>> at
>>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653)
>>>>
>>>> at
>>>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
>>>>
>>>> at
>>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
>>>>
>>>> at java.lang.Thread.run(Thread.java:695)
>>>>
>>>> [2014-09-24 10:24:21,051]  INFO
>>>> {org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Will try to
>>>> re-publish in 60 sec
>>>>
>>>> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> I have changed the Stratos messaging model to support MQTT.
>>>>>
>>>>> Please find the pull request for this.
>>>>>
>>>>> https://github.com/apache/stratos/pull/47
>>>>>
>>>>>
>>>>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>>>>
>>>>> Thanks,
>>>>> Gayan
>>>>>
>>>>>
>>>>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>>>>> wrote:
>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> Based on the discussion[1] and our initial research, we are going to
>>>>>> use the following client library for the Stratos MQTT based message
>>>>>> component.
>>>>>>
>>>>>> http://www.eclipse.org/paho/
>>>>>>
>>>>>> We have done initial research[2] of the functionality of that library
>>>>>> with both java[3] and python[4].
>>>>>>
>>>>>> Please feel free to share if you have any thoughts on this.
>>>>>>
>>>>>>
>>>>>> [1] Messaging protocol with Stratos python cartridge agent
>>>>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>>>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>>>>> [4] http://www.eclipse.org/paho/clients/python/
>>>>>>
>>>>>> Thanks,
>>>>>> Gayan
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Best Regards,
>>>>>>
>>>>>> Gayan Gunarathne
>>>>>> Technical Lead
>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>>
>>>>> Gayan Gunarathne
>>>>> Technical Lead
>>>>> WSO2 Inc. (http://wso2.com)
>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>> Nirmal
>>>>
>>>> Nirmal Fernando.
>>>> PPMC Member & Committer of Apache Stratos,
>>>> Senior Software Engineer, WSO2 Inc.
>>>>
>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>> Nirmal
>>>
>>> Nirmal Fernando.
>>> PPMC Member & Committer of Apache Stratos,
>>> Senior Software Engineer, WSO2 Inc.
>>>
>>> Blog: http://nirmalfdo.blogspot.com/
>>>
>>
>>
>>
>> --
>> Best Regards,
>>
>> Gayan Gunarathne
>> Technical Lead
>> WSO2 Inc. (http://wso2.com)
>> email  : gayang@wso2.com  | mobile : +94 766819985
>>
>>
>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>



-- 
Best Regards,

Gayan Gunarathne
Technical Lead
WSO2 Inc. (http://wso2.com)
email  : gayang@wso2.com  | mobile : +94 766819985

Re: MQTT client library for Stratos messaging component.

Posted by Nirmal Fernando <ni...@gmail.com>.

Hi Gayan,

I think we have mistakenly added a git sub module
https://github.com/apache/stratos/tree/docker-integration/tools/cartridge_agent
? Could you please check?

On Wed, Sep 24, 2014 at 4:22 PM, Gayan Gunarathne <ga...@wso2.com> wrote:

> This is resolved.
>
> Pull request :  https://github.com/apache/stratos/pull/58
> Commit ID : d789aa66ca55b9fda0662865fce818c390a4f043
>
> I also updated the JIRA(STRATOS-820
> <https://issues.apache.org/jira/browse/STRATOS-820>)
>
> Thanks,
> Gayan
>
> On Wed, Sep 24, 2014 at 10:50 AM, Nirmal Fernando <ni...@gmail.com>
> wrote:
>
>> Logged a jira https://issues.apache.org/jira/browse/STRATOS-820
>>
>> On Wed, Sep 24, 2014 at 10:28 AM, Nirmal Fernando <nirmal070125@gmail.com
>> > wrote:
>>
>>> Hi Gayan,
>>>
>>> With this PR, I am seen following error at Stratos back-end. I am
>>> running locally built stratos with an activemq. What am I missing?
>>>
>>> [2014-09-24 10:23:56,924]  INFO
>>> {org.apache.stratos.manager.publisher.InstanceNotificationPublisher} -
>>> Publishing Instance Cleanup Event: [cluster] test2.php.domain
>>>
>>> [2014-09-24 10:24:21,031] ERROR
>>> {org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Error while
>>> publishing to the topic: tenant/#
>>>
>>> Client is connected (32100)
>>>
>>> at
>>> org.eclipse.paho.client.mqttv3.internal.ExceptionHelper.createMqttException(ExceptionHelper.java:27)
>>>
>>> at
>>> org.eclipse.paho.client.mqttv3.MqttAsyncClient.connect(MqttAsyncClient.java:452)
>>>
>>> at org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:236)
>>>
>>> at org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:229)
>>>
>>> at
>>> org.apache.stratos.messaging.broker.publish.TopicPublisher.publish(TopicPublisher.java:82)
>>>
>>> at
>>> org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:51)
>>>
>>> at
>>> org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:45)
>>>
>>> at
>>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$TenantSubscribedEventPublisher.run(CartridgeSubscriptionUtils.java:174)
>>>
>>> at
>>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$1.execute(CartridgeSubscriptionUtils.java:191)
>>>
>>> at
>>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils.publishTenantSubscribedEvent(CartridgeSubscriptionUtils.java:195)
>>>
>>> at
>>> org.apache.stratos.manager.manager.CartridgeSubscriptionManager.registerCartridgeSubscription(CartridgeSubscriptionManager.java:357)
>>>
>>> at
>>> org.apache.stratos.manager.manager.CartridgeSubscriptionManager.subscribeToCartridgeWithProperties(CartridgeSubscriptionManager.java:150)
>>>
>>> at
>>> org.apache.stratos.rest.endpoint.services.ServiceUtils.subscribe(ServiceUtils.java:991)
>>>
>>> at
>>> org.apache.stratos.rest.endpoint.services.StratosAdmin.subscribe(StratosAdmin.java:401)
>>>
>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>>
>>> at
>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>>
>>> at
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>>
>>> at java.lang.reflect.Method.invoke(Method.java:597)
>>>
>>> at
>>> org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
>>>
>>> at
>>> org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
>>>
>>> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:194)
>>>
>>> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:100)
>>>
>>> at
>>> org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:57)
>>>
>>> at
>>> org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:93)
>>>
>>> at
>>> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:271)
>>>
>>> at
>>> org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
>>>
>>> at
>>> org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:239)
>>>
>>> at
>>> org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:223)
>>>
>>> at
>>> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:203)
>>>
>>> at
>>> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:137)
>>>
>>> at
>>> org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:159)
>>>
>>> at
>>> org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:286)
>>>
>>> at
>>> org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:264)
>>>
>>> at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
>>>
>>> at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
>>>
>>> at
>>> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
>>>
>>> at
>>> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
>>>
>>> at
>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
>>>
>>> at
>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
>>>
>>> at
>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
>>>
>>> at
>>> org.wso2.carbon.tomcat.ext.valves.CompositeValve.continueInvocation(CompositeValve.java:178)
>>>
>>> at
>>> org.wso2.carbon.tomcat.ext.valves.CarbonTomcatValve$1.invoke(CarbonTomcatValve.java:47)
>>>
>>> at
>>> org.wso2.carbon.webapp.mgt.TenantLazyLoaderValve.invoke(TenantLazyLoaderValve.java:56)
>>>
>>> at
>>> org.wso2.carbon.tomcat.ext.valves.TomcatValveContainer.invokeValves(TomcatValveContainer.java:47)
>>>
>>> at
>>> org.wso2.carbon.tomcat.ext.valves.CompositeValve.invoke(CompositeValve.java:141)
>>>
>>> at
>>> org.wso2.carbon.tomcat.ext.valves.CarbonStuckThreadDetectionValve.invoke(CarbonStuckThreadDetectionValve.java:156)
>>>
>>> at
>>> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:936)
>>>
>>> at
>>> org.wso2.carbon.tomcat.ext.valves.CarbonContextCreatorValve.invoke(CarbonContextCreatorValve.java:52)
>>>
>>> at
>>> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
>>>
>>> at
>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)
>>>
>>> at
>>> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004)
>>>
>>> at
>>> org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
>>>
>>> at
>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653)
>>>
>>> at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
>>>
>>> at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
>>>
>>> at java.lang.Thread.run(Thread.java:695)
>>>
>>> [2014-09-24 10:24:21,051]  INFO
>>> {org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Will try to
>>> re-publish in 60 sec
>>>
>>> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> I have changed the Stratos messaging model to support MQTT.
>>>>
>>>> Please find the pull request for this.
>>>>
>>>> https://github.com/apache/stratos/pull/47
>>>>
>>>>
>>>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>>>
>>>> Thanks,
>>>> Gayan
>>>>
>>>>
>>>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> Based on the discussion[1] and our initial research, we are going to
>>>>> use the following client library for the Stratos MQTT based message
>>>>> component.
>>>>>
>>>>> http://www.eclipse.org/paho/
>>>>>
>>>>> We have done initial research[2] of the functionality of that library
>>>>> with both java[3] and python[4].
>>>>>
>>>>> Please feel free to share if you have any thoughts on this.
>>>>>
>>>>>
>>>>> [1] Messaging protocol with Stratos python cartridge agent
>>>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>>>> [4] http://www.eclipse.org/paho/clients/python/
>>>>>
>>>>> Thanks,
>>>>> Gayan
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>>
>>>>> Gayan Gunarathne
>>>>> Technical Lead
>>>>> WSO2 Inc. (http://wso2.com)
>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>>
>>>> Gayan Gunarathne
>>>> Technical Lead
>>>> WSO2 Inc. (http://wso2.com)
>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>> Nirmal
>>>
>>> Nirmal Fernando.
>>> PPMC Member & Committer of Apache Stratos,
>>> Senior Software Engineer, WSO2 Inc.
>>>
>>> Blog: http://nirmalfdo.blogspot.com/
>>>
>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
> Best Regards,
>
> Gayan Gunarathne
> Technical Lead
> WSO2 Inc. (http://wso2.com)
> email  : gayang@wso2.com  | mobile : +94 766819985
>
>



-- 
Best Regards,
Nirmal

Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.

Blog: http://nirmalfdo.blogspot.com/

Re: MQTT client library for Stratos messaging component.

Posted by Gayan Gunarathne <ga...@wso2.com>.

This is resolved.

Pull request :  https://github.com/apache/stratos/pull/58
Commit ID : d789aa66ca55b9fda0662865fce818c390a4f043

I also updated the JIRA(STRATOS-820
<https://issues.apache.org/jira/browse/STRATOS-820>)

Thanks,
Gayan

On Wed, Sep 24, 2014 at 10:50 AM, Nirmal Fernando <ni...@gmail.com>
wrote:

> Logged a jira https://issues.apache.org/jira/browse/STRATOS-820
>
> On Wed, Sep 24, 2014 at 10:28 AM, Nirmal Fernando <ni...@gmail.com>
> wrote:
>
>> Hi Gayan,
>>
>> With this PR, I am seen following error at Stratos back-end. I am running
>> locally built stratos with an activemq. What am I missing?
>>
>> [2014-09-24 10:23:56,924]  INFO
>> {org.apache.stratos.manager.publisher.InstanceNotificationPublisher} -
>> Publishing Instance Cleanup Event: [cluster] test2.php.domain
>>
>> [2014-09-24 10:24:21,031] ERROR
>> {org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Error while
>> publishing to the topic: tenant/#
>>
>> Client is connected (32100)
>>
>> at
>> org.eclipse.paho.client.mqttv3.internal.ExceptionHelper.createMqttException(ExceptionHelper.java:27)
>>
>> at
>> org.eclipse.paho.client.mqttv3.MqttAsyncClient.connect(MqttAsyncClient.java:452)
>>
>> at org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:236)
>>
>> at org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:229)
>>
>> at
>> org.apache.stratos.messaging.broker.publish.TopicPublisher.publish(TopicPublisher.java:82)
>>
>> at
>> org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:51)
>>
>> at
>> org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:45)
>>
>> at
>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$TenantSubscribedEventPublisher.run(CartridgeSubscriptionUtils.java:174)
>>
>> at
>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$1.execute(CartridgeSubscriptionUtils.java:191)
>>
>> at
>> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils.publishTenantSubscribedEvent(CartridgeSubscriptionUtils.java:195)
>>
>> at
>> org.apache.stratos.manager.manager.CartridgeSubscriptionManager.registerCartridgeSubscription(CartridgeSubscriptionManager.java:357)
>>
>> at
>> org.apache.stratos.manager.manager.CartridgeSubscriptionManager.subscribeToCartridgeWithProperties(CartridgeSubscriptionManager.java:150)
>>
>> at
>> org.apache.stratos.rest.endpoint.services.ServiceUtils.subscribe(ServiceUtils.java:991)
>>
>> at
>> org.apache.stratos.rest.endpoint.services.StratosAdmin.subscribe(StratosAdmin.java:401)
>>
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>
>> at
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>
>> at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>
>> at java.lang.reflect.Method.invoke(Method.java:597)
>>
>> at
>> org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
>>
>> at
>> org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
>>
>> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:194)
>>
>> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:100)
>>
>> at
>> org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:57)
>>
>> at
>> org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:93)
>>
>> at
>> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:271)
>>
>> at
>> org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
>>
>> at
>> org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:239)
>>
>> at
>> org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:223)
>>
>> at
>> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:203)
>>
>> at
>> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:137)
>>
>> at
>> org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:159)
>>
>> at
>> org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:286)
>>
>> at
>> org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:264)
>>
>> at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
>>
>> at
>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
>>
>> at
>> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
>>
>> at
>> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
>>
>> at
>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
>>
>> at
>> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
>>
>> at
>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
>>
>> at
>> org.wso2.carbon.tomcat.ext.valves.CompositeValve.continueInvocation(CompositeValve.java:178)
>>
>> at
>> org.wso2.carbon.tomcat.ext.valves.CarbonTomcatValve$1.invoke(CarbonTomcatValve.java:47)
>>
>> at
>> org.wso2.carbon.webapp.mgt.TenantLazyLoaderValve.invoke(TenantLazyLoaderValve.java:56)
>>
>> at
>> org.wso2.carbon.tomcat.ext.valves.TomcatValveContainer.invokeValves(TomcatValveContainer.java:47)
>>
>> at
>> org.wso2.carbon.tomcat.ext.valves.CompositeValve.invoke(CompositeValve.java:141)
>>
>> at
>> org.wso2.carbon.tomcat.ext.valves.CarbonStuckThreadDetectionValve.invoke(CarbonStuckThreadDetectionValve.java:156)
>>
>> at
>> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:936)
>>
>> at
>> org.wso2.carbon.tomcat.ext.valves.CarbonContextCreatorValve.invoke(CarbonContextCreatorValve.java:52)
>>
>> at
>> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
>>
>> at
>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)
>>
>> at
>> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004)
>>
>> at
>> org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
>>
>> at
>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653)
>>
>> at
>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
>>
>> at
>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
>>
>> at java.lang.Thread.run(Thread.java:695)
>>
>> [2014-09-24 10:24:21,051]  INFO
>> {org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Will try to
>> re-publish in 60 sec
>>
>> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>> Hi All,
>>>
>>> I have changed the Stratos messaging model to support MQTT.
>>>
>>> Please find the pull request for this.
>>>
>>> https://github.com/apache/stratos/pull/47
>>>
>>>
>>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>>
>>> Thanks,
>>> Gayan
>>>
>>>
>>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> Based on the discussion[1] and our initial research, we are going to
>>>> use the following client library for the Stratos MQTT based message
>>>> component.
>>>>
>>>> http://www.eclipse.org/paho/
>>>>
>>>> We have done initial research[2] of the functionality of that library
>>>> with both java[3] and python[4].
>>>>
>>>> Please feel free to share if you have any thoughts on this.
>>>>
>>>>
>>>> [1] Messaging protocol with Stratos python cartridge agent
>>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>>> [4] http://www.eclipse.org/paho/clients/python/
>>>>
>>>> Thanks,
>>>> Gayan
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>>
>>>> Gayan Gunarathne
>>>> Technical Lead
>>>> WSO2 Inc. (http://wso2.com)
>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>>
>>> Gayan Gunarathne
>>> Technical Lead
>>> WSO2 Inc. (http://wso2.com)
>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>
>>>
>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>



-- 
Best Regards,

Gayan Gunarathne
Technical Lead
WSO2 Inc. (http://wso2.com)
email  : gayang@wso2.com  | mobile : +94 766819985

Re: MQTT client library for Stratos messaging component.

Posted by Nirmal Fernando <ni...@gmail.com>.

Logged a jira https://issues.apache.org/jira/browse/STRATOS-820

On Wed, Sep 24, 2014 at 10:28 AM, Nirmal Fernando <ni...@gmail.com>
wrote:

> Hi Gayan,
>
> With this PR, I am seen following error at Stratos back-end. I am running
> locally built stratos with an activemq. What am I missing?
>
> [2014-09-24 10:23:56,924]  INFO
> {org.apache.stratos.manager.publisher.InstanceNotificationPublisher} -
> Publishing Instance Cleanup Event: [cluster] test2.php.domain
>
> [2014-09-24 10:24:21,031] ERROR
> {org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Error while
> publishing to the topic: tenant/#
>
> Client is connected (32100)
>
> at
> org.eclipse.paho.client.mqttv3.internal.ExceptionHelper.createMqttException(ExceptionHelper.java:27)
>
> at
> org.eclipse.paho.client.mqttv3.MqttAsyncClient.connect(MqttAsyncClient.java:452)
>
> at org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:236)
>
> at org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:229)
>
> at
> org.apache.stratos.messaging.broker.publish.TopicPublisher.publish(TopicPublisher.java:82)
>
> at
> org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:51)
>
> at
> org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:45)
>
> at
> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$TenantSubscribedEventPublisher.run(CartridgeSubscriptionUtils.java:174)
>
> at
> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$1.execute(CartridgeSubscriptionUtils.java:191)
>
> at
> org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils.publishTenantSubscribedEvent(CartridgeSubscriptionUtils.java:195)
>
> at
> org.apache.stratos.manager.manager.CartridgeSubscriptionManager.registerCartridgeSubscription(CartridgeSubscriptionManager.java:357)
>
> at
> org.apache.stratos.manager.manager.CartridgeSubscriptionManager.subscribeToCartridgeWithProperties(CartridgeSubscriptionManager.java:150)
>
> at
> org.apache.stratos.rest.endpoint.services.ServiceUtils.subscribe(ServiceUtils.java:991)
>
> at
> org.apache.stratos.rest.endpoint.services.StratosAdmin.subscribe(StratosAdmin.java:401)
>
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>
> at java.lang.reflect.Method.invoke(Method.java:597)
>
> at
> org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
>
> at
> org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
>
> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:194)
>
> at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:100)
>
> at
> org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:57)
>
> at
> org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:93)
>
> at
> org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:271)
>
> at
> org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
>
> at
> org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:239)
>
> at
> org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:223)
>
> at
> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:203)
>
> at
> org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:137)
>
> at
> org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:159)
>
> at
> org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:286)
>
> at
> org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:264)
>
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
>
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
>
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
>
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
>
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
>
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
>
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
>
> at
> org.wso2.carbon.tomcat.ext.valves.CompositeValve.continueInvocation(CompositeValve.java:178)
>
> at
> org.wso2.carbon.tomcat.ext.valves.CarbonTomcatValve$1.invoke(CarbonTomcatValve.java:47)
>
> at
> org.wso2.carbon.webapp.mgt.TenantLazyLoaderValve.invoke(TenantLazyLoaderValve.java:56)
>
> at
> org.wso2.carbon.tomcat.ext.valves.TomcatValveContainer.invokeValves(TomcatValveContainer.java:47)
>
> at
> org.wso2.carbon.tomcat.ext.valves.CompositeValve.invoke(CompositeValve.java:141)
>
> at
> org.wso2.carbon.tomcat.ext.valves.CarbonStuckThreadDetectionValve.invoke(CarbonStuckThreadDetectionValve.java:156)
>
> at
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:936)
>
> at
> org.wso2.carbon.tomcat.ext.valves.CarbonContextCreatorValve.invoke(CarbonContextCreatorValve.java:52)
>
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
>
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)
>
> at
> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004)
>
> at
> org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
>
> at
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653)
>
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
>
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
>
> at java.lang.Thread.run(Thread.java:695)
>
> [2014-09-24 10:24:21,051]  INFO
> {org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Will try to
> re-publish in 60 sec
>
> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com> wrote:
>
>> Hi All,
>>
>> I have changed the Stratos messaging model to support MQTT.
>>
>> Please find the pull request for this.
>>
>> https://github.com/apache/stratos/pull/47
>>
>>
>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>
>> Thanks,
>> Gayan
>>
>>
>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>> Hi All,
>>>
>>> Based on the discussion[1] and our initial research, we are going to use
>>> the following client library for the Stratos MQTT based message component.
>>>
>>> http://www.eclipse.org/paho/
>>>
>>> We have done initial research[2] of the functionality of that library
>>> with both java[3] and python[4].
>>>
>>> Please feel free to share if you have any thoughts on this.
>>>
>>>
>>> [1] Messaging protocol with Stratos python cartridge agent
>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>> [4] http://www.eclipse.org/paho/clients/python/
>>>
>>> Thanks,
>>> Gayan
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>>
>>> Gayan Gunarathne
>>> Technical Lead
>>> WSO2 Inc. (http://wso2.com)
>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>
>>>
>>
>>
>>
>> --
>> Best Regards,
>>
>> Gayan Gunarathne
>> Technical Lead
>> WSO2 Inc. (http://wso2.com)
>> email  : gayang@wso2.com  | mobile : +94 766819985
>>
>>
>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>



-- 
Best Regards,
Nirmal

Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.

Blog: http://nirmalfdo.blogspot.com/

Re: MQTT client library for Stratos messaging component.

Posted by Nirmal Fernando <ni...@gmail.com>.

Hi Gayan,

With this PR, I am seen following error at Stratos back-end. I am running
locally built stratos with an activemq. What am I missing?

[2014-09-24 10:23:56,924]  INFO
{org.apache.stratos.manager.publisher.InstanceNotificationPublisher} -
Publishing Instance Cleanup Event: [cluster] test2.php.domain

[2014-09-24 10:24:21,031] ERROR
{org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Error while
publishing to the topic: tenant/#

Client is connected (32100)

at
org.eclipse.paho.client.mqttv3.internal.ExceptionHelper.createMqttException(ExceptionHelper.java:27)

at
org.eclipse.paho.client.mqttv3.MqttAsyncClient.connect(MqttAsyncClient.java:452)

at org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:236)

at org.eclipse.paho.client.mqttv3.MqttClient.connect(MqttClient.java:229)

at
org.apache.stratos.messaging.broker.publish.TopicPublisher.publish(TopicPublisher.java:82)

at
org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:51)

at
org.apache.stratos.messaging.broker.publish.EventPublisher.publish(EventPublisher.java:45)

at
org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$TenantSubscribedEventPublisher.run(CartridgeSubscriptionUtils.java:174)

at
org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils$1.execute(CartridgeSubscriptionUtils.java:191)

at
org.apache.stratos.manager.subscription.utils.CartridgeSubscriptionUtils.publishTenantSubscribedEvent(CartridgeSubscriptionUtils.java:195)

at
org.apache.stratos.manager.manager.CartridgeSubscriptionManager.registerCartridgeSubscription(CartridgeSubscriptionManager.java:357)

at
org.apache.stratos.manager.manager.CartridgeSubscriptionManager.subscribeToCartridgeWithProperties(CartridgeSubscriptionManager.java:150)

at
org.apache.stratos.rest.endpoint.services.ServiceUtils.subscribe(ServiceUtils.java:991)

at
org.apache.stratos.rest.endpoint.services.StratosAdmin.subscribe(StratosAdmin.java:401)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)

at
org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)

at
org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)

at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:194)

at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:100)

at
org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:57)

at
org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:93)

at
org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:271)

at
org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)

at
org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:239)

at
org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:223)

at
org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:203)

at
org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:137)

at
org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:159)

at
org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:286)

at
org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:264)

at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)

at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)

at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)

at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)

at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)

at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)

at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)

at
org.wso2.carbon.tomcat.ext.valves.CompositeValve.continueInvocation(CompositeValve.java:178)

at
org.wso2.carbon.tomcat.ext.valves.CarbonTomcatValve$1.invoke(CarbonTomcatValve.java:47)

at
org.wso2.carbon.webapp.mgt.TenantLazyLoaderValve.invoke(TenantLazyLoaderValve.java:56)

at
org.wso2.carbon.tomcat.ext.valves.TomcatValveContainer.invokeValves(TomcatValveContainer.java:47)

at
org.wso2.carbon.tomcat.ext.valves.CompositeValve.invoke(CompositeValve.java:141)

at
org.wso2.carbon.tomcat.ext.valves.CarbonStuckThreadDetectionValve.invoke(CarbonStuckThreadDetectionValve.java:156)

at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:936)

at
org.wso2.carbon.tomcat.ext.valves.CarbonContextCreatorValve.invoke(CarbonContextCreatorValve.java:52)

at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)

at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)

at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004)

at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)

at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1653)

at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)

at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)

at java.lang.Thread.run(Thread.java:695)

[2014-09-24 10:24:21,051]  INFO
{org.apache.stratos.messaging.broker.publish.TopicPublisher} -  Will try to
re-publish in 60 sec

On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com> wrote:

> Hi All,
>
> I have changed the Stratos messaging model to support MQTT.
>
> Please find the pull request for this.
>
> https://github.com/apache/stratos/pull/47
>
>
> Also I have updated the relevant JIRA(STRATOS-791) as well.
>
> Thanks,
> Gayan
>
>
> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
> wrote:
>
>> Hi All,
>>
>> Based on the discussion[1] and our initial research, we are going to use
>> the following client library for the Stratos MQTT based message component.
>>
>> http://www.eclipse.org/paho/
>>
>> We have done initial research[2] of the functionality of that library
>> with both java[3] and python[4].
>>
>> Please feel free to share if you have any thoughts on this.
>>
>>
>> [1] Messaging protocol with Stratos python cartridge agent
>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>> [4] http://www.eclipse.org/paho/clients/python/
>>
>> Thanks,
>> Gayan
>>
>>
>>
>> --
>> Best Regards,
>>
>> Gayan Gunarathne
>> Technical Lead
>> WSO2 Inc. (http://wso2.com)
>> email  : gayang@wso2.com  | mobile : +94 766819985
>>
>>
>
>
>
> --
> Best Regards,
>
> Gayan Gunarathne
> Technical Lead
> WSO2 Inc. (http://wso2.com)
> email  : gayang@wso2.com  | mobile : +94 766819985
>
>



-- 
Best Regards,
Nirmal

Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.

Blog: http://nirmalfdo.blogspot.com/

Re: MQTT client library for Stratos messaging component.

Posted by Manula Chathurika Thantriwatte <ma...@wso2.com>.

Hi Gayan,

+1 for re-format code with new coding standards. I think you can use
IntelliJ IDEA reformat code option format the code.

On Tue, Sep 23, 2014 at 12:43 PM, Gayan Gunarathne <ga...@wso2.com> wrote:

> Hi Chamila,
>
> Thanks for sharing this.But this is not resolve the current code
> formatting issue as those two comparing files has two different
> formats.Those diff changes happen not only with the white spaces.
>
> As a long term solutions to this,shall we re-format our whole java code
> base into new coding standards[1] in a one commit as suggested above and
> maintain the same coding standard with every source file.WDYT?
>
> [1][Discuss] Coding Standards & Best Practices Guidelines
>
> Thanks,
> Gayan
>
>
>
> On Tue, Sep 23, 2014 at 1:59 AM, Chamila De Alwis <ch...@wso2.com>
> wrote:
>
>> Hi Gayan,
>>
>> May be following tips would help to separate your existing changes in to
>> formatting and business logic without reformatting. [1] deals with removing
>> white space from the changes, but additionally [2], git add -p, allows
>> selecting the sections that need to be staged for a particular commit.
>>
>> [1] -
>> http://stackoverflow.com/questions/3515597/git-add-only-non-whitespace-changes
>> [2] -
>> http://johnkary.net/blog/git-add-p-the-most-powerful-git-feature-youre-not-using-yet/
>>
>>
>> Regards,
>> Chamila de Alwis
>> Software Engineer | WSO2 | +94772207163
>> Blog: code.chamiladealwis.com
>>
>>
>>
>> On Mon, Sep 22, 2014 at 5:48 PM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>>
>>> What is the code format template are we following previously? This is to
>>> revert the code with the previous code format.
>>>
>>> Thanks,
>>> Gayan
>>>
>>> On Mon, Sep 22, 2014 at 5:03 PM, Isuru Haththotuwa <is...@apache.org>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Sep 22, 2014 at 4:45 PM, Isuru Perera <is...@wso2.com> wrote:
>>>>
>>>>> Hi Gayan,
>>>>>
>>>>> IMHO, the formatting should be done with a different commit.
>>>>>
>>>> +1
>>>>
>>>>> The problem is that you have done logic changes along with formatting.
>>>>> I can't figure out what you changed in the code to support MQTT.
>>>>>
>>>>> As a practice, I usually try to keep the diff minimum when doing code
>>>>> changes and do formatting changes in a different commit. I suggest others
>>>>> to do the same. Then we can make sure that the code history is easy to
>>>>> understand.
>>>>>
>>>>> Just my 2 cents! :)
>>>>>
>>>>> Best Regards,
>>>>>
>>>>> On Mon, Sep 22, 2014 at 4:20 PM, Gayan Gunarathne <ga...@wso2.com>
>>>>> wrote:
>>>>>
>>>>>> Hi Isuru,
>>>>>>
>>>>>> Yeah.It is formatted according to the discussion[1].In the GIT source
>>>>>> comparing window it may show white spaces due to this.Is n't?
>>>>>>
>>>>>> Please find the following code as it is formatted as the
>>>>>> discussion[1].
>>>>>>
>>>>>>
>>>>>> https://github.com/gayangunarathne/stratos/blob/msgtopichierachchy-1/components/org.apache.stratos.cartridge.agent/src/main/java/org/apache/stratos/cartridge/agent/event/publisher/CartridgeAgentEventPublisher.java
>>>>>>
>>>>>> [1]  Coding Standards & Best Practices Guidelines
>>>>>>
>>>>>> Thanks,
>>>>>> Gayan
>>>>>>
>>>>>> On Mon, Sep 22, 2014 at 3:42 PM, Isuru Perera <is...@wso2.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Your PR seems to be messed up due to white space changes :(
>>>>>>>
>>>>>>> Did you format classes?
>>>>>>>
>>>>>>> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi All,
>>>>>>>>
>>>>>>>> I have changed the Stratos messaging model to support MQTT.
>>>>>>>>
>>>>>>>> Please find the pull request for this.
>>>>>>>>
>>>>>>>> https://github.com/apache/stratos/pull/47
>>>>>>>>
>>>>>>>>
>>>>>>>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Gayan
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <gayang@wso2.com
>>>>>>>> > wrote:
>>>>>>>>
>>>>>>>>> Hi All,
>>>>>>>>>
>>>>>>>>> Based on the discussion[1] and our initial research, we are going
>>>>>>>>> to use the following client library for the Stratos MQTT based message
>>>>>>>>> component.
>>>>>>>>>
>>>>>>>>> http://www.eclipse.org/paho/
>>>>>>>>>
>>>>>>>>> We have done initial research[2] of the functionality of that
>>>>>>>>> library with both java[3] and python[4].
>>>>>>>>>
>>>>>>>>> Please feel free to share if you have any thoughts on this.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> [1] Messaging protocol with Stratos python cartridge agent
>>>>>>>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>>>>>>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>>>>>>>> [4] http://www.eclipse.org/paho/clients/python/
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Gayan
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Best Regards,
>>>>>>>>>
>>>>>>>>> Gayan Gunarathne
>>>>>>>>> Technical Lead
>>>>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Best Regards,
>>>>>>>>
>>>>>>>> Gayan Gunarathne
>>>>>>>> Technical Lead
>>>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Isuru Perera
>>>>>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>>>>>>> Lean . Enterprise . Middleware
>>>>>>>
>>>>>>> about.me/chrishantha
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Best Regards,
>>>>>>
>>>>>> Gayan Gunarathne
>>>>>> Technical Lead
>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Isuru Perera
>>>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>>>>> Lean . Enterprise . Middleware
>>>>>
>>>>> about.me/chrishantha
>>>>>
>>>>> --
>>>>> <http://about.me/chrishantha>
>>>>> Thanks and Regards,
>>>>>
>>>>> Isuru H.
>>>>> <http://about.me/chrishantha>
>>>>> +94 716 358 048 <http://about.me/chrishantha>* <http://wso2.com/>*
>>>>>
>>>>>
>>>>> * <http://wso2.com/>*
>>>>>
>>>>>
>>>>>
>>>
>>>
>>> --
>>> Best Regards,
>>>
>>> Gayan Gunarathne
>>> Technical Lead
>>> WSO2 Inc. (http://wso2.com)
>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>
>>>
>>
>>
>
>
> --
> Best Regards,
>
> Gayan Gunarathne
> Technical Lead
> WSO2 Inc. (http://wso2.com)
> email  : gayang@wso2.com  | mobile : +94 766819985
>
>



-- 
Regards,
Manula Chathurika Thantriwatte
Software Engineer
WSO2 Inc. : http://wso2.com
lean . enterprise . middleware

email : manulac@wso2.com / manula@apache.org
phone : +94 772492511
blog : http://manulachathurika.blogspot.com/

Re: MQTT client library for Stratos messaging component.

Posted by Gayan Gunarathne <ga...@wso2.com>.

Hi Chamila,

Thanks for sharing this.But this is not resolve the current code formatting
issue as those two comparing files has two different formats.Those diff
changes happen not only with the white spaces.

As a long term solutions to this,shall we re-format our whole java code
base into new coding standards[1] in a one commit as suggested above and
maintain the same coding standard with every source file.WDYT?

[1][Discuss] Coding Standards & Best Practices Guidelines

Thanks,
Gayan



On Tue, Sep 23, 2014 at 1:59 AM, Chamila De Alwis <ch...@wso2.com> wrote:

> Hi Gayan,
>
> May be following tips would help to separate your existing changes in to
> formatting and business logic without reformatting. [1] deals with removing
> white space from the changes, but additionally [2], git add -p, allows
> selecting the sections that need to be staged for a particular commit.
>
> [1] -
> http://stackoverflow.com/questions/3515597/git-add-only-non-whitespace-changes
> [2] -
> http://johnkary.net/blog/git-add-p-the-most-powerful-git-feature-youre-not-using-yet/
>
>
> Regards,
> Chamila de Alwis
> Software Engineer | WSO2 | +94772207163
> Blog: code.chamiladealwis.com
>
>
>
> On Mon, Sep 22, 2014 at 5:48 PM, Gayan Gunarathne <ga...@wso2.com> wrote:
>
>>
>> What is the code format template are we following previously? This is to
>> revert the code with the previous code format.
>>
>> Thanks,
>> Gayan
>>
>> On Mon, Sep 22, 2014 at 5:03 PM, Isuru Haththotuwa <is...@apache.org>
>> wrote:
>>
>>>
>>>
>>> On Mon, Sep 22, 2014 at 4:45 PM, Isuru Perera <is...@wso2.com> wrote:
>>>
>>>> Hi Gayan,
>>>>
>>>> IMHO, the formatting should be done with a different commit.
>>>>
>>> +1
>>>
>>>> The problem is that you have done logic changes along with formatting.
>>>> I can't figure out what you changed in the code to support MQTT.
>>>>
>>>> As a practice, I usually try to keep the diff minimum when doing code
>>>> changes and do formatting changes in a different commit. I suggest others
>>>> to do the same. Then we can make sure that the code history is easy to
>>>> understand.
>>>>
>>>> Just my 2 cents! :)
>>>>
>>>> Best Regards,
>>>>
>>>> On Mon, Sep 22, 2014 at 4:20 PM, Gayan Gunarathne <ga...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi Isuru,
>>>>>
>>>>> Yeah.It is formatted according to the discussion[1].In the GIT source
>>>>> comparing window it may show white spaces due to this.Is n't?
>>>>>
>>>>> Please find the following code as it is formatted as the discussion[1].
>>>>>
>>>>>
>>>>> https://github.com/gayangunarathne/stratos/blob/msgtopichierachchy-1/components/org.apache.stratos.cartridge.agent/src/main/java/org/apache/stratos/cartridge/agent/event/publisher/CartridgeAgentEventPublisher.java
>>>>>
>>>>> [1]  Coding Standards & Best Practices Guidelines
>>>>>
>>>>> Thanks,
>>>>> Gayan
>>>>>
>>>>> On Mon, Sep 22, 2014 at 3:42 PM, Isuru Perera <is...@wso2.com> wrote:
>>>>>
>>>>>> Your PR seems to be messed up due to white space changes :(
>>>>>>
>>>>>> Did you format classes?
>>>>>>
>>>>>> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi All,
>>>>>>>
>>>>>>> I have changed the Stratos messaging model to support MQTT.
>>>>>>>
>>>>>>> Please find the pull request for this.
>>>>>>>
>>>>>>> https://github.com/apache/stratos/pull/47
>>>>>>>
>>>>>>>
>>>>>>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Gayan
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi All,
>>>>>>>>
>>>>>>>> Based on the discussion[1] and our initial research, we are going
>>>>>>>> to use the following client library for the Stratos MQTT based message
>>>>>>>> component.
>>>>>>>>
>>>>>>>> http://www.eclipse.org/paho/
>>>>>>>>
>>>>>>>> We have done initial research[2] of the functionality of that
>>>>>>>> library with both java[3] and python[4].
>>>>>>>>
>>>>>>>> Please feel free to share if you have any thoughts on this.
>>>>>>>>
>>>>>>>>
>>>>>>>> [1] Messaging protocol with Stratos python cartridge agent
>>>>>>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>>>>>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>>>>>>> [4] http://www.eclipse.org/paho/clients/python/
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Gayan
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Best Regards,
>>>>>>>>
>>>>>>>> Gayan Gunarathne
>>>>>>>> Technical Lead
>>>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Best Regards,
>>>>>>>
>>>>>>> Gayan Gunarathne
>>>>>>> Technical Lead
>>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Isuru Perera
>>>>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>>>>>> Lean . Enterprise . Middleware
>>>>>>
>>>>>> about.me/chrishantha
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>>
>>>>> Gayan Gunarathne
>>>>> Technical Lead
>>>>> WSO2 Inc. (http://wso2.com)
>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Isuru Perera
>>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>>>> Lean . Enterprise . Middleware
>>>>
>>>> about.me/chrishantha
>>>>
>>>> --
>>>> <http://about.me/chrishantha>
>>>> Thanks and Regards,
>>>>
>>>> Isuru H.
>>>> <http://about.me/chrishantha>
>>>> +94 716 358 048 <http://about.me/chrishantha>* <http://wso2.com/>*
>>>>
>>>>
>>>> * <http://wso2.com/>*
>>>>
>>>>
>>>>
>>
>>
>> --
>> Best Regards,
>>
>> Gayan Gunarathne
>> Technical Lead
>> WSO2 Inc. (http://wso2.com)
>> email  : gayang@wso2.com  | mobile : +94 766819985
>>
>>
>
>


-- 
Best Regards,

Gayan Gunarathne
Technical Lead
WSO2 Inc. (http://wso2.com)
email  : gayang@wso2.com  | mobile : +94 766819985

Re: MQTT client library for Stratos messaging component.

Posted by Chamila De Alwis <ch...@wso2.com>.

Hi Gayan,

May be following tips would help to separate your existing changes in to
formatting and business logic without reformatting. [1] deals with removing
white space from the changes, but additionally [2], git add -p, allows
selecting the sections that need to be staged for a particular commit.

[1] -
http://stackoverflow.com/questions/3515597/git-add-only-non-whitespace-changes
[2] -
http://johnkary.net/blog/git-add-p-the-most-powerful-git-feature-youre-not-using-yet/


Regards,
Chamila de Alwis
Software Engineer | WSO2 | +94772207163
Blog: code.chamiladealwis.com



On Mon, Sep 22, 2014 at 5:48 PM, Gayan Gunarathne <ga...@wso2.com> wrote:

>
> What is the code format template are we following previously? This is to
> revert the code with the previous code format.
>
> Thanks,
> Gayan
>
> On Mon, Sep 22, 2014 at 5:03 PM, Isuru Haththotuwa <is...@apache.org>
> wrote:
>
>>
>>
>> On Mon, Sep 22, 2014 at 4:45 PM, Isuru Perera <is...@wso2.com> wrote:
>>
>>> Hi Gayan,
>>>
>>> IMHO, the formatting should be done with a different commit.
>>>
>> +1
>>
>>> The problem is that you have done logic changes along with formatting. I
>>> can't figure out what you changed in the code to support MQTT.
>>>
>>> As a practice, I usually try to keep the diff minimum when doing code
>>> changes and do formatting changes in a different commit. I suggest others
>>> to do the same. Then we can make sure that the code history is easy to
>>> understand.
>>>
>>> Just my 2 cents! :)
>>>
>>> Best Regards,
>>>
>>> On Mon, Sep 22, 2014 at 4:20 PM, Gayan Gunarathne <ga...@wso2.com>
>>> wrote:
>>>
>>>> Hi Isuru,
>>>>
>>>> Yeah.It is formatted according to the discussion[1].In the GIT source
>>>> comparing window it may show white spaces due to this.Is n't?
>>>>
>>>> Please find the following code as it is formatted as the discussion[1].
>>>>
>>>>
>>>> https://github.com/gayangunarathne/stratos/blob/msgtopichierachchy-1/components/org.apache.stratos.cartridge.agent/src/main/java/org/apache/stratos/cartridge/agent/event/publisher/CartridgeAgentEventPublisher.java
>>>>
>>>> [1]  Coding Standards & Best Practices Guidelines
>>>>
>>>> Thanks,
>>>> Gayan
>>>>
>>>> On Mon, Sep 22, 2014 at 3:42 PM, Isuru Perera <is...@wso2.com> wrote:
>>>>
>>>>> Your PR seems to be messed up due to white space changes :(
>>>>>
>>>>> Did you format classes?
>>>>>
>>>>> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com>
>>>>> wrote:
>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> I have changed the Stratos messaging model to support MQTT.
>>>>>>
>>>>>> Please find the pull request for this.
>>>>>>
>>>>>> https://github.com/apache/stratos/pull/47
>>>>>>
>>>>>>
>>>>>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>>>>>
>>>>>> Thanks,
>>>>>> Gayan
>>>>>>
>>>>>>
>>>>>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi All,
>>>>>>>
>>>>>>> Based on the discussion[1] and our initial research, we are going to
>>>>>>> use the following client library for the Stratos MQTT based message
>>>>>>> component.
>>>>>>>
>>>>>>> http://www.eclipse.org/paho/
>>>>>>>
>>>>>>> We have done initial research[2] of the functionality of that
>>>>>>> library with both java[3] and python[4].
>>>>>>>
>>>>>>> Please feel free to share if you have any thoughts on this.
>>>>>>>
>>>>>>>
>>>>>>> [1] Messaging protocol with Stratos python cartridge agent
>>>>>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>>>>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>>>>>> [4] http://www.eclipse.org/paho/clients/python/
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Gayan
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Best Regards,
>>>>>>>
>>>>>>> Gayan Gunarathne
>>>>>>> Technical Lead
>>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Best Regards,
>>>>>>
>>>>>> Gayan Gunarathne
>>>>>> Technical Lead
>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Isuru Perera
>>>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>>>>> Lean . Enterprise . Middleware
>>>>>
>>>>> about.me/chrishantha
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>>
>>>> Gayan Gunarathne
>>>> Technical Lead
>>>> WSO2 Inc. (http://wso2.com)
>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Isuru Perera
>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>>> Lean . Enterprise . Middleware
>>>
>>> about.me/chrishantha
>>>
>>> --
>>> <http://about.me/chrishantha>
>>> Thanks and Regards,
>>>
>>> Isuru H.
>>> <http://about.me/chrishantha>
>>> +94 716 358 048 <http://about.me/chrishantha>* <http://wso2.com/>*
>>>
>>>
>>> * <http://wso2.com/>*
>>>
>>>
>>>
>
>
> --
> Best Regards,
>
> Gayan Gunarathne
> Technical Lead
> WSO2 Inc. (http://wso2.com)
> email  : gayang@wso2.com  | mobile : +94 766819985
>
>

Re: MQTT client library for Stratos messaging component.

Posted by Gayan Gunarathne <ga...@wso2.com>.

What is the code format template are we following previously? This is to
revert the code with the previous code format.

Thanks,
Gayan

On Mon, Sep 22, 2014 at 5:03 PM, Isuru Haththotuwa <is...@apache.org>
wrote:

>
>
> On Mon, Sep 22, 2014 at 4:45 PM, Isuru Perera <is...@wso2.com> wrote:
>
>> Hi Gayan,
>>
>> IMHO, the formatting should be done with a different commit.
>>
> +1
>
>> The problem is that you have done logic changes along with formatting. I
>> can't figure out what you changed in the code to support MQTT.
>>
>> As a practice, I usually try to keep the diff minimum when doing code
>> changes and do formatting changes in a different commit. I suggest others
>> to do the same. Then we can make sure that the code history is easy to
>> understand.
>>
>> Just my 2 cents! :)
>>
>> Best Regards,
>>
>> On Mon, Sep 22, 2014 at 4:20 PM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>> Hi Isuru,
>>>
>>> Yeah.It is formatted according to the discussion[1].In the GIT source
>>> comparing window it may show white spaces due to this.Is n't?
>>>
>>> Please find the following code as it is formatted as the discussion[1].
>>>
>>>
>>> https://github.com/gayangunarathne/stratos/blob/msgtopichierachchy-1/components/org.apache.stratos.cartridge.agent/src/main/java/org/apache/stratos/cartridge/agent/event/publisher/CartridgeAgentEventPublisher.java
>>>
>>> [1]  Coding Standards & Best Practices Guidelines
>>>
>>> Thanks,
>>> Gayan
>>>
>>> On Mon, Sep 22, 2014 at 3:42 PM, Isuru Perera <is...@wso2.com> wrote:
>>>
>>>> Your PR seems to be messed up due to white space changes :(
>>>>
>>>> Did you format classes?
>>>>
>>>> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> I have changed the Stratos messaging model to support MQTT.
>>>>>
>>>>> Please find the pull request for this.
>>>>>
>>>>> https://github.com/apache/stratos/pull/47
>>>>>
>>>>>
>>>>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>>>>
>>>>> Thanks,
>>>>> Gayan
>>>>>
>>>>>
>>>>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>>>>> wrote:
>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> Based on the discussion[1] and our initial research, we are going to
>>>>>> use the following client library for the Stratos MQTT based message
>>>>>> component.
>>>>>>
>>>>>> http://www.eclipse.org/paho/
>>>>>>
>>>>>> We have done initial research[2] of the functionality of that library
>>>>>> with both java[3] and python[4].
>>>>>>
>>>>>> Please feel free to share if you have any thoughts on this.
>>>>>>
>>>>>>
>>>>>> [1] Messaging protocol with Stratos python cartridge agent
>>>>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>>>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>>>>> [4] http://www.eclipse.org/paho/clients/python/
>>>>>>
>>>>>> Thanks,
>>>>>> Gayan
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Best Regards,
>>>>>>
>>>>>> Gayan Gunarathne
>>>>>> Technical Lead
>>>>>> WSO2 Inc. (http://wso2.com)
>>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>>
>>>>> Gayan Gunarathne
>>>>> Technical Lead
>>>>> WSO2 Inc. (http://wso2.com)
>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Isuru Perera
>>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>>>> Lean . Enterprise . Middleware
>>>>
>>>> about.me/chrishantha
>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>>
>>> Gayan Gunarathne
>>> Technical Lead
>>> WSO2 Inc. (http://wso2.com)
>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>
>>>
>>
>>
>>
>> --
>> Isuru Perera
>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>> Lean . Enterprise . Middleware
>>
>> about.me/chrishantha
>>
>> --
>> <http://about.me/chrishantha>
>> Thanks and Regards,
>>
>> Isuru H.
>> <http://about.me/chrishantha>
>> +94 716 358 048 <http://about.me/chrishantha>* <http://wso2.com/>*
>>
>>
>> * <http://wso2.com/>*
>>
>>
>>


-- 
Best Regards,

Gayan Gunarathne
Technical Lead
WSO2 Inc. (http://wso2.com)
email  : gayang@wso2.com  | mobile : +94 766819985

Re: MQTT client library for Stratos messaging component.

Posted by Isuru Haththotuwa <is...@apache.org>.

On Mon, Sep 22, 2014 at 4:45 PM, Isuru Perera <is...@wso2.com> wrote:

> Hi Gayan,
>
> IMHO, the formatting should be done with a different commit.
>
+1

> The problem is that you have done logic changes along with formatting. I
> can't figure out what you changed in the code to support MQTT.
>
> As a practice, I usually try to keep the diff minimum when doing code
> changes and do formatting changes in a different commit. I suggest others
> to do the same. Then we can make sure that the code history is easy to
> understand.
>
> Just my 2 cents! :)
>
> Best Regards,
>
> On Mon, Sep 22, 2014 at 4:20 PM, Gayan Gunarathne <ga...@wso2.com> wrote:
>
>> Hi Isuru,
>>
>> Yeah.It is formatted according to the discussion[1].In the GIT source
>> comparing window it may show white spaces due to this.Is n't?
>>
>> Please find the following code as it is formatted as the discussion[1].
>>
>>
>> https://github.com/gayangunarathne/stratos/blob/msgtopichierachchy-1/components/org.apache.stratos.cartridge.agent/src/main/java/org/apache/stratos/cartridge/agent/event/publisher/CartridgeAgentEventPublisher.java
>>
>> [1]  Coding Standards & Best Practices Guidelines
>>
>> Thanks,
>> Gayan
>>
>> On Mon, Sep 22, 2014 at 3:42 PM, Isuru Perera <is...@wso2.com> wrote:
>>
>>> Your PR seems to be messed up due to white space changes :(
>>>
>>> Did you format classes?
>>>
>>> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> I have changed the Stratos messaging model to support MQTT.
>>>>
>>>> Please find the pull request for this.
>>>>
>>>> https://github.com/apache/stratos/pull/47
>>>>
>>>>
>>>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>>>
>>>> Thanks,
>>>> Gayan
>>>>
>>>>
>>>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> Based on the discussion[1] and our initial research, we are going to
>>>>> use the following client library for the Stratos MQTT based message
>>>>> component.
>>>>>
>>>>> http://www.eclipse.org/paho/
>>>>>
>>>>> We have done initial research[2] of the functionality of that library
>>>>> with both java[3] and python[4].
>>>>>
>>>>> Please feel free to share if you have any thoughts on this.
>>>>>
>>>>>
>>>>> [1] Messaging protocol with Stratos python cartridge agent
>>>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>>>> [4] http://www.eclipse.org/paho/clients/python/
>>>>>
>>>>> Thanks,
>>>>> Gayan
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>>
>>>>> Gayan Gunarathne
>>>>> Technical Lead
>>>>> WSO2 Inc. (http://wso2.com)
>>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>>
>>>> Gayan Gunarathne
>>>> Technical Lead
>>>> WSO2 Inc. (http://wso2.com)
>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Isuru Perera
>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>>> Lean . Enterprise . Middleware
>>>
>>> about.me/chrishantha
>>>
>>
>>
>>
>> --
>> Best Regards,
>>
>> Gayan Gunarathne
>> Technical Lead
>> WSO2 Inc. (http://wso2.com)
>> email  : gayang@wso2.com  | mobile : +94 766819985
>>
>>
>
>
>
> --
> Isuru Perera
> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
> Lean . Enterprise . Middleware
>
> about.me/chrishantha
>
> --
> <http://about.me/chrishantha>
> Thanks and Regards,
>
> Isuru H.
> <http://about.me/chrishantha>
> +94 716 358 048 <http://about.me/chrishantha>* <http://wso2.com/>*
>
>
> * <http://wso2.com/>*
>
>
>

Re: MQTT client library for Stratos messaging component.

Posted by Isuru Perera <is...@wso2.com>.

Hi Gayan,

IMHO, the formatting should be done with a different commit. The problem is
that you have done logic changes along with formatting. I can't figure out
what you changed in the code to support MQTT.

As a practice, I usually try to keep the diff minimum when doing code
changes and do formatting changes in a different commit. I suggest others
to do the same. Then we can make sure that the code history is easy to
understand.

Just my 2 cents! :)

Best Regards,

On Mon, Sep 22, 2014 at 4:20 PM, Gayan Gunarathne <ga...@wso2.com> wrote:

> Hi Isuru,
>
> Yeah.It is formatted according to the discussion[1].In the GIT source
> comparing window it may show white spaces due to this.Is n't?
>
> Please find the following code as it is formatted as the discussion[1].
>
>
> https://github.com/gayangunarathne/stratos/blob/msgtopichierachchy-1/components/org.apache.stratos.cartridge.agent/src/main/java/org/apache/stratos/cartridge/agent/event/publisher/CartridgeAgentEventPublisher.java
>
> [1]  Coding Standards & Best Practices Guidelines
>
> Thanks,
> Gayan
>
> On Mon, Sep 22, 2014 at 3:42 PM, Isuru Perera <is...@wso2.com> wrote:
>
>> Your PR seems to be messed up due to white space changes :(
>>
>> Did you format classes?
>>
>> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>> Hi All,
>>>
>>> I have changed the Stratos messaging model to support MQTT.
>>>
>>> Please find the pull request for this.
>>>
>>> https://github.com/apache/stratos/pull/47
>>>
>>>
>>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>>
>>> Thanks,
>>> Gayan
>>>
>>>
>>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> Based on the discussion[1] and our initial research, we are going to
>>>> use the following client library for the Stratos MQTT based message
>>>> component.
>>>>
>>>> http://www.eclipse.org/paho/
>>>>
>>>> We have done initial research[2] of the functionality of that library
>>>> with both java[3] and python[4].
>>>>
>>>> Please feel free to share if you have any thoughts on this.
>>>>
>>>>
>>>> [1] Messaging protocol with Stratos python cartridge agent
>>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>>> [4] http://www.eclipse.org/paho/clients/python/
>>>>
>>>> Thanks,
>>>> Gayan
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>>
>>>> Gayan Gunarathne
>>>> Technical Lead
>>>> WSO2 Inc. (http://wso2.com)
>>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>>
>>> Gayan Gunarathne
>>> Technical Lead
>>> WSO2 Inc. (http://wso2.com)
>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>
>>>
>>
>>
>>
>> --
>> Isuru Perera
>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>> Lean . Enterprise . Middleware
>>
>> about.me/chrishantha
>>
>
>
>
> --
> Best Regards,
>
> Gayan Gunarathne
> Technical Lead
> WSO2 Inc. (http://wso2.com)
> email  : gayang@wso2.com  | mobile : +94 766819985
>
>



-- 
Isuru Perera
Senior Software Engineer | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware

about.me/chrishantha

Re: MQTT client library for Stratos messaging component.

Posted by Gayan Gunarathne <ga...@wso2.com>.

Hi Isuru,

Yeah.It is formatted according to the discussion[1].In the GIT source
comparing window it may show white spaces due to this.Is n't?

Please find the following code as it is formatted as the discussion[1].

https://github.com/gayangunarathne/stratos/blob/msgtopichierachchy-1/components/org.apache.stratos.cartridge.agent/src/main/java/org/apache/stratos/cartridge/agent/event/publisher/CartridgeAgentEventPublisher.java

[1]  Coding Standards & Best Practices Guidelines

Thanks,
Gayan

On Mon, Sep 22, 2014 at 3:42 PM, Isuru Perera <is...@wso2.com> wrote:

> Your PR seems to be messed up due to white space changes :(
>
> Did you format classes?
>
> On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com> wrote:
>
>> Hi All,
>>
>> I have changed the Stratos messaging model to support MQTT.
>>
>> Please find the pull request for this.
>>
>> https://github.com/apache/stratos/pull/47
>>
>>
>> Also I have updated the relevant JIRA(STRATOS-791) as well.
>>
>> Thanks,
>> Gayan
>>
>>
>> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>> Hi All,
>>>
>>> Based on the discussion[1] and our initial research, we are going to use
>>> the following client library for the Stratos MQTT based message component.
>>>
>>> http://www.eclipse.org/paho/
>>>
>>> We have done initial research[2] of the functionality of that library
>>> with both java[3] and python[4].
>>>
>>> Please feel free to share if you have any thoughts on this.
>>>
>>>
>>> [1] Messaging protocol with Stratos python cartridge agent
>>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>>> [4] http://www.eclipse.org/paho/clients/python/
>>>
>>> Thanks,
>>> Gayan
>>>
>>>
>>>
>>> --
>>> Best Regards,
>>>
>>> Gayan Gunarathne
>>> Technical Lead
>>> WSO2 Inc. (http://wso2.com)
>>> email  : gayang@wso2.com  | mobile : +94 766819985
>>>
>>>
>>
>>
>>
>> --
>> Best Regards,
>>
>> Gayan Gunarathne
>> Technical Lead
>> WSO2 Inc. (http://wso2.com)
>> email  : gayang@wso2.com  | mobile : +94 766819985
>>
>>
>
>
>
> --
> Isuru Perera
> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
> Lean . Enterprise . Middleware
>
> about.me/chrishantha
>



-- 
Best Regards,

Gayan Gunarathne
Technical Lead
WSO2 Inc. (http://wso2.com)
email  : gayang@wso2.com  | mobile : +94 766819985

Re: MQTT client library for Stratos messaging component.

Posted by Isuru Perera <is...@wso2.com>.

Your PR seems to be messed up due to white space changes :(

Did you format classes?

On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne <ga...@wso2.com> wrote:

> Hi All,
>
> I have changed the Stratos messaging model to support MQTT.
>
> Please find the pull request for this.
>
> https://github.com/apache/stratos/pull/47
>
>
> Also I have updated the relevant JIRA(STRATOS-791) as well.
>
> Thanks,
> Gayan
>
>
> On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com>
> wrote:
>
>> Hi All,
>>
>> Based on the discussion[1] and our initial research, we are going to use
>> the following client library for the Stratos MQTT based message component.
>>
>> http://www.eclipse.org/paho/
>>
>> We have done initial research[2] of the functionality of that library
>> with both java[3] and python[4].
>>
>> Please feel free to share if you have any thoughts on this.
>>
>>
>> [1] Messaging protocol with Stratos python cartridge agent
>> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
>> [3] https://repo.eclipse.org/content/repositories/paho-releases/
>> [4] http://www.eclipse.org/paho/clients/python/
>>
>> Thanks,
>> Gayan
>>
>>
>>
>> --
>> Best Regards,
>>
>> Gayan Gunarathne
>> Technical Lead
>> WSO2 Inc. (http://wso2.com)
>> email  : gayang@wso2.com  | mobile : +94 766819985
>>
>>
>
>
>
> --
> Best Regards,
>
> Gayan Gunarathne
> Technical Lead
> WSO2 Inc. (http://wso2.com)
> email  : gayang@wso2.com  | mobile : +94 766819985
>
>



-- 
Isuru Perera
Senior Software Engineer | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware

about.me/chrishantha

Re: MQTT client library for Stratos messaging component.

Posted by Gayan Gunarathne <ga...@wso2.com>.

Hi All,

I have changed the Stratos messaging model to support MQTT.

Please find the pull request for this.

https://github.com/apache/stratos/pull/47


Also I have updated the relevant JIRA(STRATOS-791) as well.

Thanks,
Gayan


On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne <ga...@wso2.com> wrote:

> Hi All,
>
> Based on the discussion[1] and our initial research, we are going to use
> the following client library for the Stratos MQTT based message component.
>
> http://www.eclipse.org/paho/
>
> We have done initial research[2] of the functionality of that library with
> both java[3] and python[4].
>
> Please feel free to share if you have any thoughts on this.
>
>
> [1] Messaging protocol with Stratos python cartridge agent
> [2] https://github.com/gayangunarathne/MQTT-Pub-Sub
> [3] https://repo.eclipse.org/content/repositories/paho-releases/
> [4] http://www.eclipse.org/paho/clients/python/
>
> Thanks,
> Gayan
>
>
>
> --
> Best Regards,
>
> Gayan Gunarathne
> Technical Lead
> WSO2 Inc. (http://wso2.com)
> email  : gayang@wso2.com  | mobile : +94 766819985
>
>



-- 
Best Regards,

Gayan Gunarathne
Technical Lead
WSO2 Inc. (http://wso2.com)
email  : gayang@wso2.com  | mobile : +94 766819985