You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/15 10:17:38 UTC
[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request
#4324: add downloadRoot for frontend-maven-plugin
cherrylzhao opened a new pull request #4324: add downloadRoot for frontend-maven-plugin
URL: https://github.com/apache/incubator-shardingsphere/pull/4324
`frontend-maven-plugin` will download node and npm from `https://nodejs.org/dist` by default, this is very slow for china's network. we can use a mirror site(`http://npm.taobao.org/mirrors/node/`) to speed up the build of ui-frontend module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4324: add
downloadRoot for frontend-maven-plugin
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4324: add downloadRoot for frontend-maven-plugin
URL: https://github.com/apache/incubator-shardingsphere/pull/4324#issuecomment-586577672
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=h1) Report
> Merging [#4324](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=desc) into [4.0.1](https://codecov.io/gh/apache/incubator-shardingsphere/commit/b1ef1665462005823767c3a87c0a419a4d8f91da?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 4.0.1 #4324 +/- ##
=========================================
Coverage 63.33% 63.33%
Complexity 876 876
=========================================
Files 1057 1057
Lines 17001 17001
Branches 2739 2739
=========================================
Hits 10767 10767
Misses 5631 5631
Partials 603 603
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=footer). Last update [b1ef166...4749e06](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue
#4324: add downloadRoot for frontend-maven-plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4324: add downloadRoot for frontend-maven-plugin
URL: https://github.com/apache/incubator-shardingsphere/pull/4324#issuecomment-586577672
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=h1) Report
> Merging [#4324](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=desc) into [4.0.1](https://codecov.io/gh/apache/incubator-shardingsphere/commit/b1ef1665462005823767c3a87c0a419a4d8f91da?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 4.0.1 #4324 +/- ##
=========================================
Coverage 63.33% 63.33%
Complexity 876 876
=========================================
Files 1057 1057
Lines 17001 17001
Branches 2739 2739
=========================================
Hits 10767 10767
Misses 5631 5631
Partials 603 603
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=footer). Last update [b1ef166...71943f3](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4324?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4324: add downloadRoot for frontend-maven-plugin
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4324: add downloadRoot for frontend-maven-plugin
URL: https://github.com/apache/incubator-shardingsphere/pull/4324#issuecomment-586577920
## Pull Request Test Coverage Report for [Build 9575](https://coveralls.io/builds/28757124)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **67.462%**
---
| Totals | [](https://coveralls.io/builds/28757124) |
| :-- | --: |
| Change from base [Build 9529](https://coveralls.io/builds/28728353): | 0.0% |
| Covered Lines: | 11306 |
| Relevant Lines: | 16759 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4324:
add downloadRoot for frontend-maven-plugin
Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on issue #4324: add downloadRoot for frontend-maven-plugin
URL: https://github.com/apache/incubator-shardingsphere/pull/4324#issuecomment-586690482
just close, it's bettor to prepare node_modules in local side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4324: add downloadRoot for frontend-maven-plugin
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4324: add downloadRoot for frontend-maven-plugin
URL: https://github.com/apache/incubator-shardingsphere/pull/4324#issuecomment-586577920
## Pull Request Test Coverage Report for [Build 1747](https://coveralls.io/builds/28751136)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.006%**) to **67.468%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28751136/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28751136) |
| :-- | --: |
| Change from base [Build 9529](https://coveralls.io/builds/28728353): | 0.006% |
| Covered Lines: | 11307 |
| Relevant Lines: | 16759 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao closed pull request #4324:
add downloadRoot for frontend-maven-plugin
Posted by GitBox <gi...@apache.org>.
cherrylzhao closed pull request #4324: add downloadRoot for frontend-maven-plugin
URL: https://github.com/apache/incubator-shardingsphere/pull/4324
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4324: add
downloadRoot for frontend-maven-plugin
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4324: add downloadRoot for frontend-maven-plugin
URL: https://github.com/apache/incubator-shardingsphere/pull/4324#issuecomment-586577920
## Pull Request Test Coverage Report for [Build 9567](https://coveralls.io/builds/28750275)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **67.462%**
---
| Totals | [](https://coveralls.io/builds/28750275) |
| :-- | --: |
| Change from base [Build 9529](https://coveralls.io/builds/28728353): | 0.0% |
| Covered Lines: | 11306 |
| Relevant Lines: | 16759 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services