You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "FlechazoW (via GitHub)" <gi...@apache.org> on 2023/03/30 07:30:01 UTC
[GitHub] [hudi] FlechazoW opened a new pull request, #8324: [Typo][Hoodie Metadata]Fix a typo for parameter in HoodieMetadata.
FlechazoW opened a new pull request, #8324:
URL: https://github.com/apache/hudi/pull/8324
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
[Typo][Hoodie Metadata]Fix a typo for parameter in HoodieMetadata.
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8324: [Typo][Hoodie Metadata]Fix a typo for parameter in HoodieMetadata.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8324:
URL: https://github.com/apache/hudi/pull/8324#issuecomment-1489846153
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0e5b8c41f712cc6b6680bb67bde5caf077c4ded",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15989",
"triggerID" : "e0e5b8c41f712cc6b6680bb67bde5caf077c4ded",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0e5b8c41f712cc6b6680bb67bde5caf077c4ded Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15989)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8324: [Typo][Hoodie Metadata]Fix a typo for parameter in HoodieMetadata.
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8324:
URL: https://github.com/apache/hudi/pull/8324#discussion_r1152944922
##########
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java:
##########
@@ -83,22 +83,22 @@ public abstract class BaseTableMetadata implements HoodieTableMetadata {
protected final HoodieTableMetaClient dataMetaClient;
protected final Option<HoodieMetadataMetrics> metrics;
protected final HoodieMetadataConfig metadataConfig;
- // Directory used for Spillable Map when merging records
- protected final String spillableMapDirectory;
+ // Directory used for Splittable Map when merging records
+ protected final String splittableMapDirectory;
Review Comment:
It's spill not split
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua closed pull request #8324: [Typo][Hoodie Metadata]Fix a typo for parameter in HoodieMetadata.
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua closed pull request #8324: [Typo][Hoodie Metadata]Fix a typo for parameter in HoodieMetadata.
URL: https://github.com/apache/hudi/pull/8324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #8324: [Typo][Hoodie Metadata]Fix a typo for parameter in HoodieMetadata.
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8324:
URL: https://github.com/apache/hudi/pull/8324#issuecomment-1491105231
Closing this as the spelling is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8324: [Typo][Hoodie Metadata]Fix a typo for parameter in HoodieMetadata.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8324:
URL: https://github.com/apache/hudi/pull/8324#issuecomment-1489837196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0e5b8c41f712cc6b6680bb67bde5caf077c4ded",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e0e5b8c41f712cc6b6680bb67bde5caf077c4ded",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0e5b8c41f712cc6b6680bb67bde5caf077c4ded UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8324: [Typo][Hoodie Metadata]Fix a typo for parameter in HoodieMetadata.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8324:
URL: https://github.com/apache/hudi/pull/8324#issuecomment-1490239044
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0e5b8c41f712cc6b6680bb67bde5caf077c4ded",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15989",
"triggerID" : "e0e5b8c41f712cc6b6680bb67bde5caf077c4ded",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0e5b8c41f712cc6b6680bb67bde5caf077c4ded Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15989)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org