You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/25 20:18:41 UTC

[GitHub] [airflow] potiuk commented on issue #6434: Revert "[AIRFLOW-5746] move FakeDateTime into the only place it is used (#6416)"

potiuk commented on issue #6434: Revert "[AIRFLOW-5746] move FakeDateTime into the only place it is used (#6416)"
URL: https://github.com/apache/airflow/pull/6434#issuecomment-546498093
 
 
   > I have to look at the whole test again, because it is possible that there is actually a better solution. For now I wanted to restore the state not worse than it was before.
   
   Yet - for some reason - (not sure why) they were imported and they were impacting the new contributors installing environment and running the db init. That was a blocker from using development environment which I think is a valid reason to fix it properly rather than revert (as we know reverting will impact the new contributors).
   
   I think we should look for a good, robust solution rather than reverse to something that we already know blocks people from contributing to Airflow.
   
   J.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services