You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/22 06:54:43 UTC

[GitHub] [couchdb] jaydoane opened a new pull request #2592: Clean up after mango tests

jaydoane opened a new pull request #2592: Clean up after mango tests
URL: https://github.com/apache/couchdb/pull/2592
 
 
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   Mango Python tests don't always clean up after themselves. This deletes databases and documents created by the tests.
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ```
   nosetests --nocapture src/mango/test
   ```
   
   Before this PR, running the tests as above will leave databases and users docs around. With this PR applied, those databases and docs get deleted.
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] jaydoane commented on issue #2592: Clean up after mango tests

Posted by GitBox <gi...@apache.org>.
jaydoane commented on issue #2592: Clean up after mango tests
URL: https://github.com/apache/couchdb/pull/2592#issuecomment-591253253
 
 
   I couldn't figure out how to re-target to master without pulling in 150 other commits, so I just cherry picked onto a new branch and opened a [new PR](https://github.com/apache/couchdb/pull/2600)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] garrensmith commented on issue #2592: Clean up after mango tests

Posted by GitBox <gi...@apache.org>.
garrensmith commented on issue #2592: Clean up after mango tests
URL: https://github.com/apache/couchdb/pull/2592#issuecomment-590248646
 
 
   @jaydoane could you target this against master. We can then rebase it onto the fdb branch later. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] jaydoane closed pull request #2592: Clean up after mango tests

Posted by GitBox <gi...@apache.org>.
jaydoane closed pull request #2592: Clean up after mango tests
URL: https://github.com/apache/couchdb/pull/2592
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] jaydoane commented on issue #2592: Clean up after mango tests

Posted by GitBox <gi...@apache.org>.
jaydoane commented on issue #2592: Clean up after mango tests
URL: https://github.com/apache/couchdb/pull/2592#issuecomment-590122745
 
 
   I think we'll also want these on master and maintenance branches, like the docs changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services