You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vesense <gi...@git.apache.org> on 2016/06/08 05:37:21 UTC
[GitHub] storm pull request #1472: STORM-1888: add description for shell command
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1472
STORM-1888: add description for shell command
This can be cherry-picked to 1.x-branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-1888
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1472
----
commit ff86c3869b3b38b660f39c76f2aac4cd7e9ba69d
Author: Xin Wang <be...@163.com>
Date: 2016-06-08T05:36:25Z
STORM-1888: add description for shell command
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1472: STORM-1888: add description for shell command
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1472#discussion_r68023943
--- Diff: bin/storm.py ---
@@ -485,6 +485,11 @@ def kill_workers(*args):
extrajars=[USER_CONF_DIR, os.path.join(STORM_DIR, "bin")])
def shell(resourcesdir, command, *args):
+ """Syntax: [storm shell resourcesdir command args]
+
+ Makes constructing jar and uploading to nimbus for using non JVM languages
--- End diff --
I feel this line misses behavior "executing command".
I'd like to have this line changed like
`Archives resources to jar and uploads jar to Nimbus, and executes following arguments on "local". Useful for non JVM languages.`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1472: STORM-1888: add description for shell command
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1472
@HeartSaVioR Updated and rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1472: STORM-1888: add description for shell command
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1472
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1472: STORM-1888: add description for shell command
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1472#discussion_r68058773
--- Diff: bin/storm.py ---
@@ -485,6 +485,11 @@ def kill_workers(*args):
extrajars=[USER_CONF_DIR, os.path.join(STORM_DIR, "bin")])
def shell(resourcesdir, command, *args):
+ """Syntax: [storm shell resourcesdir command args]
+
+ Makes constructing jar and uploading to nimbus for using non JVM languages
--- End diff --
Thanks @HeartSaVioR This is even better. Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1472: STORM-1888: add description for shell command
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1472
+1 Thanks @vesense for following up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---