You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/06/24 07:47:36 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

Apache9 commented on a change in pull request #3417:
URL: https://github.com/apache/hbase/pull/3417#discussion_r657707350



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1106,6 +1156,38 @@ private void finishActiveMasterInitialization(MonitoredTask status)
     }
   }
 
+  private void createMissingCFsInMetaDuringUpgrade(
+      TableDescriptor metaDescriptor) throws IOException {
+    TableDescriptor newMetaDesc =
+        TableDescriptorBuilder.newBuilder(metaDescriptor)
+            .setColumnFamily(FSTableDescriptors.getTableFamilyDesc(conf))
+            .setColumnFamily(FSTableDescriptors.getReplBarrierFamilyDesc())
+            .build();
+    long pid = this.modifyTable(TableName.META_TABLE_NAME, () -> newMetaDesc,

Review comment:
       This procedure could be done without ClusterSchemaService?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org