[jira] [Commented] (FLUME-2966) NULL text in a TextMessage from a JMS source in Flume can lead to NPE

["Siddharth Ahuja (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15463788#comment-15463788 ] 

Siddharth Ahuja commented on FLUME-2966:
----------------------------------------

Sorry, was away on leave [~bessbd]. Just posted a patch for review. Please kindly advise if I needed to do something else for getting this reviewed.Thanks!

> NULL text in a TextMessage from a JMS source in Flume can lead to NPE
> ---------------------------------------------------------------------
>
>                 Key: FLUME-2966
>                 URL: https://issues.apache.org/jira/browse/FLUME-2966
>             Project: Flume
>          Issue Type: Bug
>            Reporter: Siddharth Ahuja
>            Assignee: Siddharth Ahuja
>         Attachments: FLUME-2966-0.patch
>
>
> Code at https://github.com/apache/flume/blob/trunk/flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/DefaultJMSMessageConverter.java#L103 does not check for a NULL text in a TextMessage from a Flume JMS source. This can lead to a NullPointerException here: {code}textMessage.getText().getBytes(charset){code} while trying to de-reference a null text from the textmessage.
> We should probably skip these like the NULL Objects in the ObjectMessage just below at: https://github.com/apache/flume/blob/trunk/flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/DefaultJMSMessageConverter.java#L107.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)