You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by al...@apache.org on 2016/10/05 14:55:23 UTC
[1/2] nifi git commit: NIFI-1615 - Add GitHbub pull request template
to address some of the reocurring PR mistakes
Repository: nifi
Updated Branches:
refs/heads/0.x 4e6f9d396 -> 5d3f3c9a9
refs/heads/master 75d0c74d2 -> 7fd293f33
NIFI-1615 - Add GitHbub pull request template to address some of the reocurring PR mistakes
Signed-off-by: Aldrin Piri <al...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/nifi/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi/commit/7fd293f3
Tree: http://git-wip-us.apache.org/repos/asf/nifi/tree/7fd293f3
Diff: http://git-wip-us.apache.org/repos/asf/nifi/diff/7fd293f3
Branch: refs/heads/master
Commit: 7fd293f3390ab4785bdbe53069ddffeee529a4ed
Parents: 75d0c74
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Authored: Thu Oct 6 00:52:54 2016 +1100
Committer: Aldrin Piri <al...@apache.org>
Committed: Wed Oct 5 10:52:16 2016 -0400
----------------------------------------------------------------------
.github/PULL_REQUEST_TEMPLATE.md | 43 +++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/nifi/blob/7fd293f3/.github/PULL_REQUEST_TEMPLATE.md
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 0000000..c57e0dc
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,43 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+Thank you for submitting a contribution to Apache NiFi.
+
+In order to streamline the review of the contribution we ask you
+to ensure the following steps have been taken:
+
+### For all changes:
+- [] Is there a JIRA ticket associated with this PR? Is it referenced
+ in the commit message?
+
+- [] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
+
+- [] Has your PR been rebased against the latest commit within the target branch (typically master)?
+
+- [] Is your initial contribution a single, squashed commit?
+
+### For code changes:
+- [] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
+- [] Have you written or updated unit tests to verify your changes?
+- [] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
+- [] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
+- [] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
+- [] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
+
+### For documentation related changes:
+- [] Have you ensured that format looks appropriate for the output in which it is rendered?
+
+### Note:
+Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
[2/2] nifi git commit: NIFI-1615 - Add GitHbub pull request template
to address some of the reocurring PR mistakes
Posted by al...@apache.org.
NIFI-1615 - Add GitHbub pull request template to address some of the reocurring PR mistakes
Signed-off-by: Aldrin Piri <al...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/nifi/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi/commit/5d3f3c9a
Tree: http://git-wip-us.apache.org/repos/asf/nifi/tree/5d3f3c9a
Diff: http://git-wip-us.apache.org/repos/asf/nifi/diff/5d3f3c9a
Branch: refs/heads/0.x
Commit: 5d3f3c9a904f3485dc4781665c7196902e11e34a
Parents: 4e6f9d3
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Authored: Thu Oct 6 00:52:54 2016 +1100
Committer: Aldrin Piri <al...@apache.org>
Committed: Wed Oct 5 10:54:46 2016 -0400
----------------------------------------------------------------------
.github/PULL_REQUEST_TEMPLATE.md | 43 +++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/nifi/blob/5d3f3c9a/.github/PULL_REQUEST_TEMPLATE.md
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 0000000..c57e0dc
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,43 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+Thank you for submitting a contribution to Apache NiFi.
+
+In order to streamline the review of the contribution we ask you
+to ensure the following steps have been taken:
+
+### For all changes:
+- [] Is there a JIRA ticket associated with this PR? Is it referenced
+ in the commit message?
+
+- [] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
+
+- [] Has your PR been rebased against the latest commit within the target branch (typically master)?
+
+- [] Is your initial contribution a single, squashed commit?
+
+### For code changes:
+- [] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
+- [] Have you written or updated unit tests to verify your changes?
+- [] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
+- [] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
+- [] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
+- [] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
+
+### For documentation related changes:
+- [] Have you ensured that format looks appropriate for the output in which it is rendered?
+
+### Note:
+Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.