You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/30 09:14:38 UTC
[GitHub] [spark] Ngone51 opened a new pull request #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scaka
Ngone51 opened a new pull request #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scaka
URL: https://github.com/apache/spark/pull/28070
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606770860
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606003110
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606476038
**[Test build #120635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120635/testReport)** for PR 28070 at commit [`50e329f`](https://github.com/apache/spark/commit/50e329f4de13a72ca365166233f1335d988e6cf9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605997370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25293/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605884801
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25285/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070: [SPARK-31010][SQL]
Add Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606137951
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120590/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #28070: [SPARK-31010][SQL] Add
Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605883541
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606599975
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120635/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605884784
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070: [SPARK-31010][SQL]
Add Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605884784
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28070: [SPARK-31010][SQL] Add
Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605996668
**[Test build #120590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120590/testReport)** for PR 28070 at commit [`bef033c`](https://github.com/apache/spark/commit/bef033c060c9ddcdbdcae7b990e7d091def8d465).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070: [SPARK-31010][SQL]
Add Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605884801
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25285/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606757276
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070: [SPARK-31010][SQL]
Add Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606137938
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606137951
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120590/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606476789
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25337/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#discussion_r400665878
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -4864,9 +4864,12 @@ object functions {
"information. Spark may blindly pass null to the Scala closure with primitive-type " +
"argument, and the closure will see the default value of the Java type for the null " +
"argument, e.g. `udf((x: Int) => x, IntegerType)`, the result is 0 for null input. " +
- "You could use typed Scala UDF APIs (e.g. `udf((x: Int) => x)`) to avoid this problem, " +
- s"or set ${SQLConf.LEGACY_ALLOW_UNTYPED_SCALA_UDF.key} to true and use this API with " +
- s"caution."
+ "To get rid of this error, you could:\n" +
+ "1. use typed Scala UDF APIs, e.g. `udf((x: Int) => x)`\n" +
+ "2. use Java UDF APIs, e.g. `udf(new UDF1[String, Int] { override def call(s: String): " +
Review comment:
Yes, and I tested manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606476782
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28070: [SPARK-31010][SQL] Add
Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606136799
**[Test build #120590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120590/testReport)** for PR 28070 at commit [`bef033c`](https://github.com/apache/spark/commit/bef033c060c9ddcdbdcae7b990e7d091def8d465).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#discussion_r400205939
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -4864,9 +4864,10 @@ object functions {
"information. Spark may blindly pass null to the Scala closure with primitive-type " +
"argument, and the closure will see the default value of the Java type for the null " +
"argument, e.g. `udf((x: Int) => x, IntegerType)`, the result is 0 for null input. " +
- "You could use typed Scala UDF APIs (e.g. `udf((x: Int) => x)`) to avoid this problem, " +
- s"or set ${SQLConf.LEGACY_ALLOW_UNTYPED_SCALA_UDF.key} to true and use this API with " +
- s"caution."
+ "You could use typed Scala UDF APIs (e.g. `udf((x: Int) => x)`) or Java UDF (e.g. " +
+ "`udf(new UDF1[String, Int] { override def call(s: String): Int = s.length() }, " +
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606476782
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606607732
**[Test build #120647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120647/testReport)** for PR 28070 at commit [`50e329f`](https://github.com/apache/spark/commit/50e329f4de13a72ca365166233f1335d988e6cf9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070: [SPARK-31010][SQL]
Add Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606003124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120582/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#discussion_r400079846
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -4864,9 +4864,10 @@ object functions {
"information. Spark may blindly pass null to the Scala closure with primitive-type " +
"argument, and the closure will see the default value of the Java type for the null " +
"argument, e.g. `udf((x: Int) => x, IntegerType)`, the result is 0 for null input. " +
- "You could use typed Scala UDF APIs (e.g. `udf((x: Int) => x)`) to avoid this problem, " +
- s"or set ${SQLConf.LEGACY_ALLOW_UNTYPED_SCALA_UDF.key} to true and use this API with " +
- s"caution."
+ "You could use typed Scala UDF APIs (e.g. `udf((x: Int) => x)`) or Java UDF (e.g. " +
+ "`udf(new UDF1[String, Int] { override def call(s: String): Int = s.length() }, " +
Review comment:
does Java UDF support scala `Int`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606757276
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606599573
**[Test build #120635 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120635/testReport)** for PR 28070 at commit [`50e329f`](https://github.com/apache/spark/commit/50e329f4de13a72ca365166233f1335d988e6cf9).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070: [SPARK-31010][SQL]
Add Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606003110
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28070: [SPARK-31010][SQL] Add
Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606002134
**[Test build #120582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120582/testReport)** for PR 28070 at commit [`42e18a3`](https://github.com/apache/spark/commit/42e18a3dc9ee65a6fcfd02369eff8b16ba68d016).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#discussion_r400082499
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -4864,9 +4864,10 @@ object functions {
"information. Spark may blindly pass null to the Scala closure with primitive-type " +
"argument, and the closure will see the default value of the Java type for the null " +
"argument, e.g. `udf((x: Int) => x, IntegerType)`, the result is 0 for null input. " +
- "You could use typed Scala UDF APIs (e.g. `udf((x: Int) => x)`) to avoid this problem, " +
- s"or set ${SQLConf.LEGACY_ALLOW_UNTYPED_SCALA_UDF.key} to true and use this API with " +
- s"caution."
+ "You could use typed Scala UDF APIs (e.g. `udf((x: Int) => x)`) or Java UDF (e.g. " +
+ "`udf(new UDF1[String, Int] { override def call(s: String): Int = s.length() }, " +
+ "IntegerType)`) if input types are all non primitive to avoid this problem or set " +
+ "${SQLConf.LEGACY_ALLOW_UNTYPED_SCALA_UDF.key} to true and use this API with caution."
Review comment:
now there are 3 workarounds, can we list them nicely?
```
"To get rid of this error, you could:\n" +
"1. use typed Scala UDF, e.g. ...\n" +
"2. use Java UDF, e.g. ..., if input types... \n" +
"3. set .... "
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28070: [SPARK-31010][SQL] Add
Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605884133
**[Test build #120582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120582/testReport)** for PR 28070 at commit [`42e18a3`](https://github.com/apache/spark/commit/42e18a3dc9ee65a6fcfd02369eff8b16ba68d016).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606604635
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25347/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606137938
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605997359
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606003124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120582/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606476038
**[Test build #120635 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120635/testReport)** for PR 28070 at commit [`50e329f`](https://github.com/apache/spark/commit/50e329f4de13a72ca365166233f1335d988e6cf9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070: [SPARK-31010][SQL]
Add Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605997359
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605996668
**[Test build #120590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120590/testReport)** for PR 28070 at commit [`bef033c`](https://github.com/apache/spark/commit/bef033c060c9ddcdbdcae7b990e7d091def8d465).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606757292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120647/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606599968
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606604019
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606757292
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120647/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606604623
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606476789
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25337/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606756250
**[Test build #120647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120647/testReport)** for PR 28070 at commit [`50e329f`](https://github.com/apache/spark/commit/50e329f4de13a72ca365166233f1335d988e6cf9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606599968
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606604623
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606607732
**[Test build #120647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120647/testReport)** for PR 28070 at commit [`50e329f`](https://github.com/apache/spark/commit/50e329f4de13a72ca365166233f1335d988e6cf9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070: [SPARK-31010][SQL]
Add Java UDF suggestion in error message of untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605997370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25293/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606604635
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25347/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#discussion_r400201722
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -4864,9 +4864,12 @@ object functions {
"information. Spark may blindly pass null to the Scala closure with primitive-type " +
"argument, and the closure will see the default value of the Java type for the null " +
"argument, e.g. `udf((x: Int) => x, IntegerType)`, the result is 0 for null input. " +
- "You could use typed Scala UDF APIs (e.g. `udf((x: Int) => x)`) to avoid this problem, " +
- s"or set ${SQLConf.LEGACY_ALLOW_UNTYPED_SCALA_UDF.key} to true and use this API with " +
- s"caution."
+ "To get rid of this error, you could:\n" +
+ "1. use typed Scala UDF APIs, e.g. `udf((x: Int) => x)`\n" +
+ "2. use Java UDF APIs, e.g. `udf(new UDF1[String, Int] { override def call(s: String): " +
Review comment:
does Java UDF support scala `Int`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606979401
thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28070:
[SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped
Scala UDF
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28070: [SPARK-31010][SQL] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-605884133
**[Test build #120582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120582/testReport)** for PR 28070 at commit [`42e18a3`](https://github.com/apache/spark/commit/42e18a3dc9ee65a6fcfd02369eff8b16ba68d016).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28070:
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of
untyped Scala UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28070: [SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF
URL: https://github.com/apache/spark/pull/28070#issuecomment-606599975
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120635/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org