You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/10/31 09:32:54 UTC

Review Request 15115: CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15115/
-----------------------------------------------------------

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-4335
    https://issues.apache.org/jira/browse/CLOUDSTACK-4335


Repository: cloudstack-git


Description
-------

test_deployVmSharedNetworkWithoutIpRange creates a shared network
without start and end ip. This is no longer permitted and creation
of shared network will fail with error insufficient capacity. So
remove this test which is invalid.


Diffs
-----

  test/integration/component/test_shared_network_offering.py 85f0892 

Diff: https://reviews.apache.org/r/15115/diff/


Testing
-------


Thanks,

Girish Shilamkar


Re: Review Request 15115: CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15115/#review27893
-----------------------------------------------------------


Commit 733c355eaa364e5402876b1347b206454b3bec66 in branch refs/heads/4.2 from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=733c355 ]

CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange

test_deployVmSharedNetworkWithoutIpRange creates a shared network
without start and end ip. This is no longer permitted and creation
of shared network will fail with error "insufficient capacity". So
remove this test which is invalid.

Signed-off-by: Girish Shilamkar <gi...@clogeny.com>


- ASF Subversion and Git Services


On Oct. 31, 2013, 8:32 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15115/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 8:32 a.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4335
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4335
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> test_deployVmSharedNetworkWithoutIpRange creates a shared network
> without start and end ip. This is no longer permitted and creation
> of shared network will fail with error insufficient capacity. So
> remove this test which is invalid.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_shared_network_offering.py 85f0892 
> 
> Diff: https://reviews.apache.org/r/15115/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>


Re: Review Request 15115: CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange

Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15115/#review27888
-----------------------------------------------------------

Ship it!


Ship It!

- Santhosh Edukulla


On Oct. 31, 2013, 8:32 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15115/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 8:32 a.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4335
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4335
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> test_deployVmSharedNetworkWithoutIpRange creates a shared network
> without start and end ip. This is no longer permitted and creation
> of shared network will fail with error insufficient capacity. So
> remove this test which is invalid.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_shared_network_offering.py 85f0892 
> 
> Diff: https://reviews.apache.org/r/15115/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>


Re: Review Request 15115: CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15115/#review27891
-----------------------------------------------------------


Commit 58179d28840a37e6b098d731d4fe6e6e5ea8ecf9 in branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=58179d2 ]

CLOUDSTACK-4335: Delete test_deployVmSharedNetworkWithoutIpRange

test_deployVmSharedNetworkWithoutIpRange creates a shared network
without start and end ip. This is no longer permitted and creation
of shared network will fail with error "insufficient capacity". So
remove this test which is invalid.

Signed-off-by: Girish Shilamkar <gi...@clogeny.com>


- ASF Subversion and Git Services


On Oct. 31, 2013, 8:32 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15115/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 8:32 a.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4335
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4335
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> test_deployVmSharedNetworkWithoutIpRange creates a shared network
> without start and end ip. This is no longer permitted and creation
> of shared network will fail with error insufficient capacity. So
> remove this test which is invalid.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_shared_network_offering.py 85f0892 
> 
> Diff: https://reviews.apache.org/r/15115/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>