You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/29 07:34:19 UTC
[GitHub] [flink] danny0405 opened a new pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
danny0405 opened a new pull request #14801:
URL: https://github.com/apache/flink/pull/14801
…rationException
## What is the purpose of the change
Fix the sql statement: `vFloat in (1.0, 2.0, 3.0)`, currently it throws `UnsupportedOperationException`.
## Brief change log
*(for example:)*
- Copy `RexLiteral` from Calcite release 1.26.0 code and add the fix lines
- Add test cases
## Verifying this change
Added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14801:
URL: https://github.com/apache/flink/pull/14801#issuecomment-769642883
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12639",
"triggerID" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"triggerType" : "PUSH"
}, {
"hash" : "a2b4b41dc506d000de6ff4f234b4bd9db4c7fa47",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a2b4b41dc506d000de6ff4f234b4bd9db4c7fa47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 955d4e54ae6bf8dfff1a847378c31ed23cc193e0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12639)
* a2b4b41dc506d000de6ff4f234b4bd9db4c7fa47 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #14801:
URL: https://github.com/apache/flink/pull/14801#discussion_r567901514
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala
##########
@@ -1121,6 +1122,27 @@ class CatalogTableITCase(isStreamingMode: Boolean) extends AbstractTestBase {
expectedProperty.put("k2", "b")
assertEquals(expectedProperty, database.getProperties)
}
+
+ @Test
+ def testFloatIn(): Unit = {
+ val source = tableEnv.fromValues(
+ DataTypes.ROW(
+ DataTypes.FIELD("f0", DataTypes.FLOAT()),
+ DataTypes.FIELD("f1", DataTypes.FLOAT()),
+ DataTypes.FIELD("f2", DataTypes.FLOAT())),
+ toRow(1.0f, 11.0f, 12.0f),
+ toRow(2.0f, 21.0f, 22.0f),
+ toRow(3.0f, 31.0f, 32.0f),
+ toRow(4.0f, 41.0f, 42.0f),
+ toRow(5.0f, 51.0f, 52.0f)
+ )
+ tableEnv.createTemporaryView("myTable", source)
+ val query =
+ """
+ |select * from myTable where f0 in (1.0, 2.0, 3.0)
+ |""".stripMargin
+ tableEnv.executeSql(query).collect()
Review comment:
Please verify the result.
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala
##########
@@ -1121,6 +1122,27 @@ class CatalogTableITCase(isStreamingMode: Boolean) extends AbstractTestBase {
expectedProperty.put("k2", "b")
assertEquals(expectedProperty, database.getProperties)
Review comment:
`CatalogTableITCase` is mostly for testing the interaction with the catalog. Can we move this test to `CalcITCase`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14801:
URL: https://github.com/apache/flink/pull/14801#issuecomment-769642883
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12639",
"triggerID" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 955d4e54ae6bf8dfff1a847378c31ed23cc193e0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12639)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #14801:
URL: https://github.com/apache/flink/pull/14801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14801:
URL: https://github.com/apache/flink/pull/14801#issuecomment-769642883
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12639",
"triggerID" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"triggerType" : "PUSH"
}, {
"hash" : "a2b4b41dc506d000de6ff4f234b4bd9db4c7fa47",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12770",
"triggerID" : "a2b4b41dc506d000de6ff4f234b4bd9db4c7fa47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 955d4e54ae6bf8dfff1a847378c31ed23cc193e0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12639)
* a2b4b41dc506d000de6ff4f234b4bd9db4c7fa47 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12770)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14801:
URL: https://github.com/apache/flink/pull/14801#issuecomment-769642883
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 955d4e54ae6bf8dfff1a847378c31ed23cc193e0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14801:
URL: https://github.com/apache/flink/pull/14801#issuecomment-769636192
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 955d4e54ae6bf8dfff1a847378c31ed23cc193e0 (Fri Jan 29 07:38:37 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20942).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14801:
URL: https://github.com/apache/flink/pull/14801#issuecomment-769642883
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12639",
"triggerID" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 955d4e54ae6bf8dfff1a847378c31ed23cc193e0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12639)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14801:
URL: https://github.com/apache/flink/pull/14801#issuecomment-769636192
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a2b4b41dc506d000de6ff4f234b4bd9db4c7fa47 (Fri May 28 08:16:02 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #14801:
URL: https://github.com/apache/flink/pull/14801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14801:
URL: https://github.com/apache/flink/pull/14801#issuecomment-769642883
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14801: [FLINK-20942][planner] Digest of FLOAT literals throws UnsupportedOpe…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14801:
URL: https://github.com/apache/flink/pull/14801#issuecomment-769642883
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12639",
"triggerID" : "955d4e54ae6bf8dfff1a847378c31ed23cc193e0",
"triggerType" : "PUSH"
}, {
"hash" : "a2b4b41dc506d000de6ff4f234b4bd9db4c7fa47",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12770",
"triggerID" : "a2b4b41dc506d000de6ff4f234b4bd9db4c7fa47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a2b4b41dc506d000de6ff4f234b4bd9db4c7fa47 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12770)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org