[jira] [Commented] (MAHOUT-882) TopItems.getTopUsers ignores rescoring

["Sean Owen (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149039#comment-13149039 ] 

Sean Owen commented on MAHOUT-882:
----------------------------------

Ugh, that's been there for ages. I'll fix it and SimilarUser and adjust tests.
                
> TopItems.getTopUsers ignores rescoring
> --------------------------------------
>
>                 Key: MAHOUT-882
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-882
>             Project: Mahout
>          Issue Type: Bug
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 0.6
>
>
> I believe TopUsers.getTopUsers() is not properly handling the rescoredSimilarity:
> {code}
> TopItems.getTopUsers:
> double rescoredSimilarity = rescorer == null ? similarity : rescorer.rescore(userID, similarity);
>       if (!Double.isNaN(rescoredSimilarity) && (!full || rescoredSimilarity > lowestTopValue)) {
>         topUsers.add(new SimilarUser(userID, similarity));
> {code}
> It is checking rescoredSimilarity for everything, but then not passing it in like getTopItems does.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira