[GitHub] [openwebbeans] philippkunz commented on a change in pull request #28: [OWB-1330] Cdi parameter resolver

[GitBox <gi...@apache.org>]

philippkunz commented on a change in pull request #28:
URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439849366



##########
File path: webbeans-junit5/src/test/java/org/apache/openwebbeans/junit5/parameter/ParameterResolutionTest.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.openwebbeans.junit5.parameter;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import org.apache.openwebbeans.junit5.Cdi;
+import org.apache.openwebbeans.junit5.bean.MyService;
+import org.junit.jupiter.api.Test;
+
+@Cdi(classes = MyService.class)
+class ParameterResolutionTest
+{
+    @Test

Review comment:
       Ok. Convinced as an example to document. When worth to document I guess we also can keep in the tests. The `OnlyFirstParameterResolver` might for that purpose be a little too minimalistic resolving only parameters that meet `parameterContext.getIndex() == 0` and then to the value null.
   Is it correct that the documentation is behind that subversion link you posted somewhere and hence not in the git repository? If so, can we delay changes to the docs until after this here is merged?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org