[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1812: [NETBEANS-3538]:Added Delete Action for Java Modular Project

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1812: [NETBEANS-3538]:Added Delete Action for Java Modular Project
URL: https://github.com/apache/netbeans/pull/1812#discussion_r373834519
 
 

 ##########
 File path: java/java.api.common/src/org/netbeans/modules/java/api/common/project/ui/MultiModuleNodeFactory.java
 ##########
 @@ -465,6 +466,100 @@ public boolean equals(@NullAllowed final Object other) {
                     new DynLkp());
         }
 
+        @Override
+        public boolean canDestroy() {
+            return true;
+        }
+
+        @Override
+        public void destroy() {
 
 Review comment:
   Why did the delete routine grow from 20 lines (original commit to nearly 100 lines)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists