[GitHub] [arrow-rs] jychen7 commented on a diff in pull request #3663: object_store: add Path::from_url_path

["jychen7 (via GitHub)" <gi...@apache.org>]

jychen7 commented on code in PR #3663:
URL: https://github.com/apache/arrow-rs/pull/3663#discussion_r1096719267


##########
object_store/src/path/mod.rs:
##########
@@ -162,6 +162,13 @@ impl Path {
         })
     }
 
+    /// Parse a url encoded string as a [`Path`], returning a [`Error`] if invalid,
+    /// as defined on the docstring for [`Path`]
+    pub fn from_url_path(path: impl AsRef<str>) -> Result<Self, Error> {

Review Comment:
   make sense, let me do it later today
   
   ps: then we can name it `from_url(url: impl AsRef<URL>)` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org