You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/23 09:56:42 UTC

[GitHub] [incubator-superset] brylie opened a new pull request #11015: Reorganize steps

brylie opened a new pull request #11015:
URL: https://github.com/apache/incubator-superset/pull/11015


   Reorganize steps to
   1. run db migrations
   2. create default roles/permissions
   3. create admin user
   4. (optional) load examples
   
   ### ADDITIONAL INFORMATION
   - [X] Has associated issue: #10769
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter commented on pull request #11015: Reorganize steps

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11015:
URL: https://github.com/apache/incubator-superset/pull/11015#issuecomment-697276763


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11015?src=pr&el=h1) Report
   > Merging [#11015](https://codecov.io/gh/apache/incubator-superset/pull/11015?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/02ab5cc644295051c7e789d27164ad87714e7855?el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11015/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11015?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11015      +/-   ##
   ==========================================
   + Coverage   65.77%   65.79%   +0.01%     
   ==========================================
     Files         816      816              
     Lines       38376    38376              
     Branches     3606     3606              
   ==========================================
   + Hits        25241    25248       +7     
   + Misses      13027    13020       -7     
     Partials      108      108              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `57.14% <ø> (+0.13%)` | :arrow_up: |
   | #javascript | `61.71% <ø> (ø)` | |
   | #python | `61.39% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11015?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/messageToasts/components/Toast.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11015/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC50c3g=) | `100.00% <0.00%> (+3.03%)` | :arrow_up: |
   | [...perset-frontend/src/messageToasts/actions/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11015/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC5qcw==) | `100.00% <0.00%> (+8.33%)` | :arrow_up: |
   | [superset-frontend/src/components/FlashProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11015/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmxhc2hQcm92aWRlci50c3g=) | `71.42% <0.00%> (+28.57%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11015?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11015?src=pr&el=footer). Last update [02ab5cc...5573bc2](https://codecov.io/gh/apache/incubator-superset/pull/11015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] suddjian commented on pull request #11015: build: Reorganize steps

Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #11015:
URL: https://github.com/apache/incubator-superset/pull/11015#issuecomment-697703275


   This lgtm but someone with more docker expertise should check it out


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] craig-rueda merged pull request #11015: build: Reorganize steps

Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #11015:
URL: https://github.com/apache/incubator-superset/pull/11015


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org