You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/12/12 15:15:59 UTC

Review Request 64546: Fixed a flaky test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64546/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.


Bugs: MESOS-8315
    https://issues.apache.org/jira/browse/MESOS-8315


Repository: mesos


Description
-------

Callbacks of already invalidated instances could be called in
'ResubscribeResourceProvider' when simulating a resource provider
restart. This has been resolved by not only restarting a resource
provider's driver, but creating a new 'MockResourceProvider' instance.


Diffs
-----

  src/tests/resource_provider_manager_tests.cpp e37a53ac6a03e2ea58dd6580fc8a399a1398d950 


Diff: https://reviews.apache.org/r/64546/diff/1/


Testing
-------

make check

src/mesos-tests --gtest_filter=*ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider* --gtest_repeat=1000 --gtest_break_on_failure (with 'stress' running in the background)


Thanks,

Jan Schlicht


Re: Review Request 64546: Fixed a flaky test.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64546/#review193794
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/resource_provider_manager_tests.cpp
Lines 1107 (patched)
<https://reviews.apache.org/r/64546/#comment272442>

    Not added here, but the `Some` here is redundant.



src/tests/resource_provider_manager_tests.cpp
Lines 1181 (patched)
<https://reviews.apache.org/r/64546/#comment272444>

    The `Some` here is redundant.


- Benjamin Bannier


On Dec. 14, 2017, 11:35 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64546/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2017, 11:35 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
> 
> 
> Bugs: MESOS-8315
>     https://issues.apache.org/jira/browse/MESOS-8315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Callbacks of already invalidated instances could be called in
> 'ResubscribeResourceProvider' when simulating a resource provider
> restart. This has been resolved by not only restart a resource
> provider's driver, but creating a new 'MockResourceProvider' instance.
> 
> 
> Diffs
> -----
> 
>   src/tests/resource_provider_manager_tests.cpp 41fc4ea592eed49bd03d7e78019fa647f4f6e652 
> 
> 
> Diff: https://reviews.apache.org/r/64546/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> src/mesos-tests --gtest_filter=*ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider* --gtest_repeat=1000 --gtest_break_on_failure (with 'stress' running in the background)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 64546: Fixed a flaky test.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64546/#review193797
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['64546']`

Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64546

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64546/logs/mesos-tests-stdout.log):

```

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2492 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2518 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2374 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2398 ms total)

[----------] Global test environment tear-down
[==========] 835 tests from 85 test cases ran. (321743 ms total)
[  PASSED  ] 825 tests.
[  FAILED  ] 10 tests, listed below:
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending

10 FAILED TESTS
  YOU HAVE 205 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64546/logs/mesos-tests-stderr.log):

```
I1214 13:57:02.502472   412 master.cpp:10154] Updating the state of task c8d043c7-0a77-4769-89a4-cfe9c33a143e of framework 7231118f-edb6-490a-a100-48530a9b028c-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1214 13:57:02.502472  3608 slave.cpp:3400] Shutting down framework 7231118f-edb6-4I1214 13:57:01.825465  5580 exec.cpp:162] Version: 1.5.0
I1214 13:57:01.849465  7120 exec.cpp:237] Executor registered on agent 7231118f-edb6-490a-a100-48530a9b028c-S0
I1214 13:57:01.852466  3796 executor.cpp:171] Received SUBSCRIBED event
I1214 13:57:01.856467  3796 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1214 13:57:01.857465  3796 executor.cpp:171] Received LAUNCH event
I1214 13:57:01.861466  3796 executor.cpp:637] Starting task c8d043c7-0a77-4769-89a4-cfe9c33a143e
I1214 13:57:01.939493  3796 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1214 13:57:02.478459  3796 executor.cpp:650] Forked command at 5696
I1214 13:57:02.504458  6848 exec.cpp:435] Executor asked to shutdown
I1214 13:57:02.505458  3796 executor.cpp:171] Received SHUTDOWN event
I1214 13:57:02.505458  3796 executor.cpp:747] Shutting down
I1214 13:57:02.505458  3796 executor.cpp:854] Sending SIGTERM to process tree at pid 590a-a100-48530a9b028c-0000
I1214 13:57:02.502472  3608 slave.cpp:6114] Shutting down executor 'c8d043c7-0a77-4769-89a4-cfe9c33a143e' of framework 7231118f-edb6-490a-a100-48530a9b028c-0000 at executor(1)@10.3.1.11:57896
I1214 13:57:02.503458  3608 slave.cpp:909] Agent terminating
W1214 13:57:02.503458  3608 slave.cpp:3396] Ignoring shutdown framework 7231118f-edb6-490a-a100-48530a9b028c-0000 because it is terminating
I1214 13:57:02.504458   412 master.cpp:10260] Removing task c8d043c7-0a77-4769-89a4-cfe9c33a143e with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 7231118f-edb6-490a-a100-48530a9b028c-0000 on agent 7231118f-edb6-490a-a100-48530a9b028c-S0 at slave(327)@10.3.1.11:57875 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1214 13:57:02.506456  6548 containerizer.cpp:2337] Destroying container 44fd02f5-ce1c-4ea1-845b-ef6ad2e11894 in RUNNING state
I1214 13:57:02.506456  6548 containerizer.cpp:2939] Transitioning the state of container 44fd02f5-ce1c-4ea1-845b-ef6ad2e11894 from RUNNING to DESTROYING
I1214 13:57:02.507459   412 master.cpp:1305] Agent 7231118f-edb6-490a-a100-48530a9b028c-S0 at slave(327)@10.3.1.11:57875 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1214 13:57:02.507459   412 master.cpp:3364] Disconnecting agent 7231118f-edb6-490a-a100-48530a9b028c-S0 at slave(327)@10.3.1.11:57875 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1214 13:57:02.507459  6956 hierarchical.cpp:344] Removed framework 7231118f-edb6-490a-a100-48530a9b028c-0000
I1214 13:57:02.507459   412 master.cpp:3383] Deactivating agent 7231118f-edb6-490a-a100-48530a9b028c-S0 at slave(327)@10.3.1.11:57875 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1214 13:57:02.507459   896 hierarchical.cpp:766] Agent 7231118f-edb6-490a-a100-48530a9b028c-S0 deactivated
I1214 13:57:02.508482  6548 launcher.cpp:156] Asked to destroy container 44fd02f5-ce1c-4ea1-845b-ef6ad2e11894
I1214 13:57:02.570636   412 containerizer.cpp:2788] Container 44fd02f5-ce1c-4ea1-845b-ef6ad2e11894 has exited
I1214 13:57:02.598671  3212 master.cpp:1147] Master terminating
I1214 13:57:02.600662   896 hierarchical.cpp:609] Removed agent 7231118f-edb6-490a-a100-48530a9b028c-S0
I1214 13:57:02.833515  6464 process.cpp:887] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Dec. 14, 2017, 11:35 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64546/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2017, 11:35 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
> 
> 
> Bugs: MESOS-8315
>     https://issues.apache.org/jira/browse/MESOS-8315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Callbacks of already invalidated instances could be called in
> 'ResubscribeResourceProvider' when simulating a resource provider
> restart. This has been resolved by not only restart a resource
> provider's driver, but creating a new 'MockResourceProvider' instance.
> 
> 
> Diffs
> -----
> 
>   src/tests/resource_provider_manager_tests.cpp 41fc4ea592eed49bd03d7e78019fa647f4f6e652 
> 
> 
> Diff: https://reviews.apache.org/r/64546/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> src/mesos-tests --gtest_filter=*ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider* --gtest_repeat=1000 --gtest_break_on_failure (with 'stress' running in the background)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 64546: Fixed a flaky test.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64546/
-----------------------------------------------------------

(Updated Dec. 14, 2017, 11:35 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.


Changes
-------

Addressed issues.


Bugs: MESOS-8315
    https://issues.apache.org/jira/browse/MESOS-8315


Repository: mesos


Description (updated)
-------

Callbacks of already invalidated instances could be called in
'ResubscribeResourceProvider' when simulating a resource provider
restart. This has been resolved by not only restart a resource
provider's driver, but creating a new 'MockResourceProvider' instance.


Diffs (updated)
-----

  src/tests/resource_provider_manager_tests.cpp 41fc4ea592eed49bd03d7e78019fa647f4f6e652 


Diff: https://reviews.apache.org/r/64546/diff/2/

Changes: https://reviews.apache.org/r/64546/diff/1-2/


Testing
-------

make check

src/mesos-tests --gtest_filter=*ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider* --gtest_repeat=1000 --gtest_break_on_failure (with 'stress' running in the background)


Thanks,

Jan Schlicht


Re: Review Request 64546: Fixed a flaky test.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64546/#review193776
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/resource_provider_manager_tests.cpp
Line 1133 (original), 1137 (patched)
<https://reviews.apache.org/r/64546/#comment272425>

    We need to make sure that the info used below has an id,
    
        ASSERT_TRUE(resourceProvider->info.has_id());



src/tests/resource_provider_manager_tests.cpp
Line 1134 (original), 1138-1139 (patched)
<https://reviews.apache.org/r/64546/#comment272426>

    I'd suggest to just overwrite `resourceProviderInfo`
    
        resourceProviderInfo = resourceProvider->info;
    
    We can then use `resourceProviderInfo.id()` in place of `resourceProviderId`.


- Benjamin Bannier


On Dec. 12, 2017, 4:15 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64546/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 4:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
> 
> 
> Bugs: MESOS-8315
>     https://issues.apache.org/jira/browse/MESOS-8315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Callbacks of already invalidated instances could be called in
> 'ResubscribeResourceProvider' when simulating a resource provider
> restart. This has been resolved by not only restarting a resource
> provider's driver, but creating a new 'MockResourceProvider' instance.
> 
> 
> Diffs
> -----
> 
>   src/tests/resource_provider_manager_tests.cpp e37a53ac6a03e2ea58dd6580fc8a399a1398d950 
> 
> 
> Diff: https://reviews.apache.org/r/64546/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> src/mesos-tests --gtest_filter=*ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider* --gtest_repeat=1000 --gtest_break_on_failure (with 'stress' running in the background)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 64546: Fixed a flaky test.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64546/#review193561
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['64546']`

Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64546

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64546/logs/mesos-tests-stdout.log):

```

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2311 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2332 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2253 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2276 ms total)

[----------] Global test environment tear-down
[==========] 829 tests from 84 test cases ran. (304197 ms total)
[  PASSED  ] 819 tests.
[  FAILED  ] 10 tests, listed below:
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[  FAILED  ] SlaveTest.ResourceProviderPublishAll

10 FAILED TESTS
  YOU HAVE 204 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64546/logs/mesos-tests-stderr.log):

```
I1212 16:37:27.830670  3076 executor.cpp:171] Received SUBSCRIBED event
I1212 16:37:27.834671  3076 executor.cpp:175] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1212 16:37:27.834671  3076 executor.cpp:171] Received LAUNCH event
I1212 16:37:27.838670  3076 executor.cpp:637] Starting task 2768344d-1ac0-45e6-8bc2-3905daa560f4
I1212 16:37:27.911669  3076 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1212 16:37:28.450675  3076 executor.cpp:650] Forked command at 5056
I1212 16:37:28.476675  8596 exec.cpp:435] Executor asked to shutdown
I1212 16:37:28.477675  4156 executor.cpp:171] Received SHUTDOWN event
I1212 16:37:28.477675  4156 executor.cpp:747] Shutting down
I1212 16:37:28.477675  4156 executor.cpp:854] Sending SIGTERM to process tree at pid 54e43-af0a-2d48f2bae027@10.3.1.5:62719
I1212 16:37:28.474678  8848 hierarchical.cpp:405] Deactivated framework 62af06ef-1d7c-4889-9d83-14175ba00a76-0000
I1212 16:37:28.475675  1608 master.cpp:10114] Updating the state of task 2768344d-1ac0-45e6-8bc2-3905daa560f4 of framework 62af06ef-1d7c-4889-9d83-14175ba00a76-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1212 16:37:28.475675   992 slave.cpp:3400] Shutting down framework 62af06ef-1d7c-4889-9d83-14175ba00a76-0000
I1212 16:37:28.475675   992 slave.cpp:6091] Shutting down executor '2768344d-1ac0-45e6-8bc2-3905daa560f4' of framework 62af06ef-1d7c-4889-9d83-14175ba00a76-0000 at executor(1)@10.3.1.5:62740
I1212 16:37:28.475675   992 slave.cpp:909] Agent terminating
W1212 16:37:28.476675   992 slave.cpp:3396] Ignoring shutdown framework 62af06ef-1d7c-4889-9d83-14175ba00a76-0000 because it is terminating
I1212 16:37:28.477675  1608 master.cpp:10220] Removing task 2768344d-1ac0-45e6-8bc2-3905daa560f4 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 62af06ef-1d7c-4889-9d83-14175ba00a76-0000 on agent 62af06ef-1d7c-4889-9d83-14175ba00a76-S0 at slave(326)@10.3.1.5:62719 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 16:37:28.478704   992 containerizer.cpp:2328] Destroying container d662026c-6e79-4319-b016-f1c836a630a1 in RUNNING state
I1212 16:37:28.479676   992 containerizer.cpp:2930] Transitioning the state of container d662026c-6e79-4319-b016-f1c836a630a1 from RUNNING to DESTROYING
I1212 16:37:28.479676   992 launcher.cpp:156] Asked to destroy container d662026c-6e79-4319-b016-f1c836a630a1
I1212 16:37:28.480675  1608 master.cpp:1305] Agent 62af06ef-1d7c-4889-9d83-14175ba00a76-S0 at slave(326)@10.3.1.5:62719 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1212 16:37:28.480675  1608 master.cpp:3364] Disconnecting agent 62af06ef-1d7c-4889-9d83-14175ba00a76-S0 at slave(326)@10.3.1.5:62719 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 16:37:28.480675  1408 hierarchical.cpp:344] Removed framework 62af06ef-1d7c-4889-9d83-14175ba00a76-0000
I1212 16:37:28.480675  1608 master.cpp:3383] Deactivating agent 62af06ef-1d7c-4889-9d83-14175ba00a76-S0 at slave(326)@10.3.1.5:62719 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 16:37:28.481675  8536 hierarchical.cpp:766] Agent 62af06ef-1d7c-4889-9d83-14175ba00a76-S0 deactivated
I1212 16:37:28.503743  8848 containerizer.cpp:2779] Container d662026c-6e79-4319-b016-f1c836a630a1 has exited
I1212 16:37:28.531785  3264 master.cpp:1147] Master terminating
I1212 16:37:28.533778  8536 hierarchical.cpp:609] Removed agent 62af06ef-1d7c-4889-9d83-14175ba00a76-S0
I1212 16:37:28.841305  2284 process.cpp:887] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Dec. 12, 2017, 5:15 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64546/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 5:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
> 
> 
> Bugs: MESOS-8315
>     https://issues.apache.org/jira/browse/MESOS-8315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Callbacks of already invalidated instances could be called in
> 'ResubscribeResourceProvider' when simulating a resource provider
> restart. This has been resolved by not only restarting a resource
> provider's driver, but creating a new 'MockResourceProvider' instance.
> 
> 
> Diffs
> -----
> 
>   src/tests/resource_provider_manager_tests.cpp e37a53ac6a03e2ea58dd6580fc8a399a1398d950 
> 
> 
> Diff: https://reviews.apache.org/r/64546/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> src/mesos-tests --gtest_filter=*ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider* --gtest_repeat=1000 --gtest_break_on_failure (with 'stress' running in the background)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>